+1 to make sure the Benchmark class is normally compiled (or at least during a -Prelease).
JMH is licensed as ASF-incompatible GPL 2.0, but that's OK for a <scope>test</scope> dependency - particularly as a user can just remove it if they don't run the benchmark tests. On 29 June 2016 at 11:27, sebb AT ASF <s...@apache.org> wrote: > This compile error was not picked up because the Benchmark class is > only compiled if the -Pbenchmark profile is used. > > The class cannot currently be compiled in normal mode because it > depends on JMH which is only included as a test dependency by the > profile. > > I'm wondering whether the test dependency on jmh should be made unconditional? > This would allow compilation during the test phase. > The profile would still be needed to run the benchmark itself. > > Would there be any disadvantages to always depending on JMH? > > On 29 June 2016 at 11:21, <s...@apache.org> wrote: >> Repository: commons-crypto >> Updated Branches: >> refs/heads/master 9e7f040b1 -> 8a8bcb0a3 >> >> >> Fallback no longer exists >> >> Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo >> Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/8a8bcb0a >> Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/8a8bcb0a >> Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/8a8bcb0a >> >> Branch: refs/heads/master >> Commit: 8a8bcb0a3293597b306b49ea86f1e592b8b00b47 >> Parents: 9e7f040 >> Author: Sebb <s...@apache.org> >> Authored: Wed Jun 29 11:20:58 2016 +0100 >> Committer: Sebb <s...@apache.org> >> Committed: Wed Jun 29 11:20:58 2016 +0100 >> >> ---------------------------------------------------------------------- >> src/test/java/org/apache/commons/crypto/CryptoBenchmark.java | 2 -- >> 1 file changed, 2 deletions(-) >> ---------------------------------------------------------------------- >> >> >> http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/8a8bcb0a/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java >> ---------------------------------------------------------------------- >> diff --git a/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java >> b/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java >> index b1bd753..9e10311 100644 >> --- a/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java >> +++ b/src/test/java/org/apache/commons/crypto/CryptoBenchmark.java >> @@ -173,8 +173,6 @@ public class CryptoBenchmark { >> private CryptoCipher getCipher(String className) throws Exception { >> Properties properties = new Properties(); >> properties.setProperty(ConfigurationKeys.CIPHER_CLASSES_KEY, >> className); >> - >> properties.setProperty(ConfigurationKeys.ENABLE_FALLBACK_ON_NATIVE_FAILED_KEY, >> "false"); >> - >> CryptoCipher cipher = >> CryptoCipherFactory.getInstance("AES/CBC/PKCS5Padding", properties); >> Assert.assertEquals(className, >> cipher.getClass().getCanonicalName()); >> return cipher; >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > -- Stian Soiland-Reyes Apache Taverna (incubating), Apache Commons http://orcid.org/0000-0001-9842-9718 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
