On Wed, 14 Sep 2016 14:53:29 +0100, Stian Soiland-Reyes wrote:
On 14 September 2016 at 10:14, Gilles <gil...@harfang.homelinux.org>
wrote:
This is a [VOTE] for releasing Apache Commons Rng 1.0 (from RC1).
Commit ID the tag points at:
f8d23082607b9f2c7be7f489eb09627722440ee5
Thanks, Gilles!
I'm afraid my vote is: -0 as the source zip is missing README.md and
CONTRIBUTING.md and the site is not updated.
The site can, and will be fixed, "live" (as it must be done anyway for
the link to the Javadoc, see below).
Everything else looks
good though!
Checked:
+1 checksums
+1 signatures
+1 source zip vs tar.gz
+1 binaries zip vs tar.gz
+1 mvn apache-rat:check (if using ignores from <reporting>)
I don't understand the "if" clause.
Report is clean when generated as part of "mvn site".
+1 maven repo matches source (on -src.tar, -src.zip)
+1 mvn clean install
+1 LICENSE/NOTICE
+1 javadoc
http://home.apache.org/~erans/commons-rng-1.0-RC1-site/apidocs/index.html
+1 RELEASE-NOTES (Should it mention that this was in math before?)
No point IMHO.
There isn't a single file that was not significantly changed
and most are new.
It was developed within the CM repository but the code was never
released as part of CM.
-1 git tag vs source zip
source zip is missing README.md and CONTRIBUTING.md (and doc,
which
I think it's correct to exclude)
-1 binaries vs source
binaries zip is missing README.md and CONTRIBUTING.md (and doc,
which I think it's correct to exclude)
Are those a mandatory part of the distribution?
Commons Math was never released with those files.
I'd rather not redo the release steps just for files that are
meaningful only when browsing the code repository mirror at
Github.
-1 README missing from both source and bniaries
-1 site stlil says "There isn't any release yet" etc on front page.
This was noticed by Gary.
The site is not part of the release and can be fixed anytime (which
I'll do before the announcement).
"Javadoc 1.0" link in menu is broken.
That is always the case; it is also to be fixed when the files are
in their proper place (i.e. not in the RM's "~/public_html").
Regards,
Gilles
Tested with
$ mvn -v
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /home/stain/software/maven
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-36-generic", arch: "amd64", family:
"unix"
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
