On 9 October 2016 at 12:47, Benedikt Ritter <[email protected]> wrote: > Hello, > > <[email protected]> schrieb am Fr., 7. Okt. 2016 um 12:04 Uhr: > >> Author: sebb >> Date: Fri Oct 7 10:04:06 2016 >> New Revision: 1763721 >> >> URL: http://svn.apache.org/viewvc?rev=1763721&view=rev >> Log: >> Unused >> >> Modified: >> >> commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App13Segment.java >> >> Modified: >> commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App13Segment.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App13Segment.java?rev=1763721&r1=1763720&r2=1763721&view=diff >> >> ============================================================================== >> --- >> commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App13Segment.java >> (original) >> +++ >> commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/jpeg/segments/App13Segment.java >> Fri Oct 7 10:04:06 2016 >> @@ -27,7 +27,7 @@ import org.apache.commons.imaging.format >> import org.apache.commons.imaging.formats.jpeg.iptc.PhotoshopApp13Data; >> >> public class App13Segment extends AppnSegment { >> - protected final JpegImageParser parser; >> + private final JpegImageParser parser; // TODO unused >> > > It's better to delete unused fields. >
Yes, if they really are. It only became unused because I disabled the unused public accessor. Maybe I should have made the comment a question instead. >> >> // public final List elements = new ArrayList(); >> // public final boolean isIPTCJpegSegment; >> >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
