On 11 December 2016 at 06:11, Gilles <gil...@harfang.homelinux.org> wrote: >> This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC6). >> Tag name: >> RNG_1_0_RC6 (signature can be checked from git using 'git tag -v') >> >> Tag URL: >> >> >> >> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=4581a4520315657a4219b37c81f5db80e4a4e43c >> >> Commit ID the tag points at: >> 4581a4520315657a4219b37c81f5db80e4a4e43c >> >> Site: >> http://home.apache.org/~erans/commons-rng-1.0-RC6-site >> >> Distribution files (committed at revision 17284): >> https://dist.apache.org/repos/dist/dev/commons/rng/ >> >> Distribution files hashes (SHA1): >> c5e70a523160ed848194eeba0efa2b14d23c7a61 commons-rng-1.0-bin.tar.gz.sha1 >> 66d7701afc90aafa4c4b6e033b8df6cd84365161 commons-rng-1.0-bin.zip.sha1 >> ef56543c8882a0e4771de83ecf8b3be190f122cf commons-rng-1.0-src.tar.gz.sha1 >> 3dc56b0793d8bbd703a4efa68547eb58f6fb5b35 commons-rng-1.0-src.zip.sha1 >> >> KEYS file to check signatures: >> http://www.apache.org/dist/commons/KEYS
NOTE: URL to KEYS should always be with https, not http >> Maven artifacts: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1229/ >> >> Please select one of the following options[1]: >> [ ] +1 Release it. >> [ ] +0 Go ahead; I don't care. >> [ ] -0 There are a few minor glitches: ... >> [ ] -1 No, do not release it because ... >> >> This vote will be open at least 72 hours, i.e. until 2016-12-10T00:00:00Z >> (this is UTC time). >> ---------- > > > Ping? > > Unless I'm mistaken, after 100 hours have elapsed, there are only > 2 votes for RC6. I wouldn't interpret that in any direction.. probably just busy days in December. I just finished putting a dead tree in my living room, so time for some release candidate testing! My vote: +1 (binding) Checked: +1 commit matches tag (signed yay) +1 commit matches src +1 src matches staging repo -sources +1 bin JARs matches staging repo hashes +1 zip vs tar.gz +1 .asc signatures of dist (+1 for sha256 digest) +1 .asc signatures of repo +1 md5/sha1 hashes +0 mvn apache-rat:check (failed on checkstyle/suppressions.xml - tiny, OK for now, fixed in git) +1 no unexpected binaries +1 mvn clean install +1 .. and afterwards in commons-rng-examples +0 binary vs source (bin distro includes -sources.jar and -javadoc.jar which are not built by default from src distro) +1 RELEASE-NOTES +1 LICENSE, NOTICE +1 META-INF/LICENSE and NOTICE in repo JARs (which include MersenneTwister BSD license) +1 site +1 javadoc Great work! Thanks for preparing this release candidate! As this is RC6 I would have preferred that reflected somewhat in the dist folder-name under vote (e.g. /dist/dev/commons/rng-1.0-RC6) , but you included properly the SVN revision number and sha1 hashes, so no doubt in this particular case. The amended apache-rat config was only under <reporting> so it didn't pick up RNG-specific excludes when running mvn apache-rat:check -- I added it also to <plugins> in git and simplified using <excludes combine.children="append">. This does not affect this vote. Why isn't commons-rng-examples part of the normal build when it is deployed to Maven and part of the bin distro; is it because because it needs JDK7? Java 7 no longer counts as "special requirement" -- in fact I would have preferred a first 1.0 release to not commit us to future Java 6 support.. but IMHO we're OK to go for Java 7 or even Java 8 in a future 1.1 release and no longer need to keep commons-rng-examples special. Tested with: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) Maven home: /home/stain/software/maven Java version: 1.8.0_111, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre Default locale: en_GB, platform encoding: UTF-8 OS name: "linux", version: "4.4.0-53-generic", arch: "amd64", family: "unix"+ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
