This time I mean it. Heh... :-) I agree on the items needing fixing. I'm a -1 now. Will get to it Sunday/Monday. Thanks for the sets of eyes everyone.
Cheers, -Rob > On Jun 9, 2017, at 3:08 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > >> On Fri, Jun 9, 2017 at 9:21 AM, Rob Tompkins <chtom...@gmail.com> wrote: >> >> >> >>> On Jun 9, 2017, at 12:17 PM, Oliver Heger <oliver.he...@oliver-heger.de> >> wrote: >>> >>> Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good. >>> >>> Remarks: >>> - The NOTICE file has an incorrect copyright year (-2016). >> > > That should be fixed IMO. > > >>> - The binary distribution has a different structure than binaries >>> released for other components. For instance, it contains only the jar, >>> but no Javadoc or Sources jars. (Not blocking, but may make sense to be >>> conform to other components.) >> > > That should be fixed IMO, it's just confusing. > > >>> - The ant build did not work for me. (Not blocking, could also be >>> dropped IMHO). >> > > IIRC the only reason we still have Ant builds is that some Linux distros > build jars from Scratch using Ant. Why not Maven I do not know. Does anyone > else recall anything about this? > > Otherwise, we could nuke the Ant build. > > Gary > > >>> >>> I think, the copyright date could be a problem. Therefore, I abstain >>> from voting. >> >> What are others thoughts on this point? >> >>> >>> Oliver >>> >>>> Am 06.06.2017 um 20:20 schrieb Rob Tompkins: >>>> Hello all, >>>> >>>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from >> RC5). >>>> >>>> Tag name: >>>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using >> 'git tag -v') >>>> >>>> Tag URL: >>>> https://git-wip-us.apache.org/repos/asf?p=commons- >> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084 >>>> >>>> Commit ID the tag points at: >>>> dd2238b1671644cfead0e87c24a8ac61b4039084 >>>> >>>> Site: >>>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5 >>>> >>>> Distribution files (committed at revision 19901): >>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/ >>>> >>>> Distribution files hashes (SHA1): >>>> commons-fileupload-1.3.3-bin.tar.gz >>>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa) >>>> commons-fileupload-1.3.3-bin.zip >>>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa) >>>> commons-fileupload-1.3.3-src.tar.gz >>>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73) >>>> commons-fileupload-1.3.3-src.zip >>>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52) >>>> >>>> These are the Maven artifacts and their hashes: >>>> commons-fileupload-1.3.3-javadoc.jar >>>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99) >>>> commons-fileupload-1.3.3-sources.jar >>>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673) >>>> commons-fileupload-1.3.3-test-sources.jar >>>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708) >>>> commons-fileupload-1.3.3-tests.jar >>>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232) >>>> commons-fileupload-1.3.3.jar >>>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40) >>>> commons-fileupload-1.3.3.pom >>>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c) >>>> >>>> KEYS file to check signatures: >>>> http://www.apache.org/dist/commons/KEYS >>>> >>>> Maven artifacts: >>>> https://repository.apache.org/content/repositories/ >> orgapachecommons-1249 >>>> >>>> Please select one of the following options[1]: >>>> [ ] +1 Release it. >>>> [ ] +0 Go ahead; I don't care. >>>> [ ] -0 There are a few minor glitches: ... >>>> [ ] -1 No, do not release it because ... >>>> >>>> This vote will be open at least 72 hours, i.e. until >>>> 2017-06-09T19:00:00Z >>>> (this is UTC time). >>>> -------- >>>> >>>> Cheers, >>>> -Rob >>>> >>>> [1] http://apache.org/foundation/voting.html >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
