Github user jbduncan commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/28#discussion_r127782622
  
    --- Diff: 
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java 
---
    @@ -17,24 +17,22 @@
     
     package org.apache.commons.imaging.common.bytesource;
     
    -import static org.junit.Assert.assertTrue;
    +import org.apache.commons.imaging.ImagingTest;
    +import org.junit.Test;
     
    -import java.io.BufferedOutputStream;
    -import java.io.ByteArrayOutputStream;
    -import java.io.File;
    -import java.io.FileOutputStream;
    -import java.io.IOException;
    -import java.io.OutputStream;
    +import java.io.*;
     
    -import org.apache.commons.imaging.ImagingTest;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertTrue;
    +import static org.junit.Assert.fail;
    --- End diff --
    
    I'd keep the ordering and style of the imports as before; no need to 
rearrange them just to import `assertEquals` and `fail`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to