Github user kinow commented on a diff in the pull request:
    --- Diff: 
src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/ ---
    @@ -248,6 +258,35 @@ public PhotoshopApp13Data parsePhotoshopSegment(final 
byte[] bytes,
             return elements;
    +    private String getEncodingCharsetName(byte[] codedCharacterSet){
    +        final Character WHITESPACE = ' ';
    +        String codedCharacterSetString = new String(codedCharacterSet);
    +        try {
    +            if (Charset.isSupported(codedCharacterSetString)) {
    +                return codedCharacterSetString;
    +            }
    +        }catch (IllegalCharsetNameException e){
    --- End diff --
    Might be worth to add at least one comment saying why these exceptions are 
not important, and that can be safely ignored.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to