Looks good AFAICT
Stephen

On 9 October 2017 at 14:39, Emmanuel Bourg <ebo...@apache.org> wrote:
> Le 29/09/2017 à 10:08, Emmanuel Bourg a écrit :
>
>> I'd like to prepare a new release of Commons Lang 2 that addresses the
>> Java 9 compatibility. I have two items in mind for this update, the
>> automatic module name in the manifest of course, but also the
>> SystemUtils.isJavaVersionAtLeast() method that is broken with Java 9 and
>> throws an Exception. This would be a minimal update branched off the
>> latest 2.6 release.
>
> I prepared the changes on GitHub:
>
>   https://github.com/ebourg/commons-lang/tree/LANG_2_X
>
> I started from the 2.x branch since it contained a few fixes worth
> keeping. The exception I was seeing with SystemUtils
> isJavaVersionAtLeast() was actually fixed in 2.6, so I just added the
> automatic module name to the manifest (I used org.apache.commons.lang as
> name assuming commons-lang3 would use org.apache.commons.lang3). I
> updated the release notes but not the site since it's published from the
> master branch.
>
> Please review, I intend to merge the changes and roll the release next week.
>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to