+1 (non-binding) On Thu, Dec 7, 2017 at 12:34 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
> I am looking for more reviews from PMC members please. > > Gary > > On Dec 7, 2017 13:33, "Oliver Heger" <oliver.he...@oliver-heger.de> wrote: > > > > > > > Am 06.12.2017 um 22:26 schrieb Gary Gregory: > > > Oliver, how do you feel about installing Java 9 and trying again? > > > > > > Gary > > > > > > On Tue, Dec 5, 2017 at 1:48 PM, Gary Gregory <garydgreg...@gmail.com> > > wrote: > > > > > >> The test calls the registryGetKeys Windows API and that throws an > > >> exception because Java 9 is not installed on that machine. This is a > > bug in > > >> the test only. Fixed in trunk. Not a showstopper IMO. > > >> > > >> Gary > > > > Agreed that this is not a blocker. Artifacts and site look good. You > > will probably update the Release Information section on index.html. > > There are some checkstyle and findbugs finding, but I assume nothing new > > or critical. > > > > So +1 > > > > Oliver > > > > >> > > >> On Sun, Dec 3, 2017 at 1:44 PM, Oliver Heger < > > oliver.he...@oliver-heger.de > > >>> wrote: > > >> > > >>> Here is the stack trace: > > >>> > > >>> ------------------------------------------------------------ > > >>> ------------------- > > >>> Test set: org.apache.bcel.generic.JDKGenericDumpTestCase > > >>> ------------------------------------------------------------ > > >>> ------------------- > > >>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.657 > > >>> sec <<< FAILURE! - in org.apache.bcel.generic.JDKGenericDumpTestCase > > >>> initializationError(org.apache.bcel.generic.JDKGenericDumpTestCase) > > >>> Time elapsed: 0 sec <<< ERROR! > > >>> com.sun.jna.platform.win32.Win32Exception: Das System kann die > > >>> angegebene Datei nicht finden. > > >>> at > > >>> org.apache.bcel.generic.JDKGenericDumpTestCase.addAllJavaHom > > >>> esOnWindows(JDKGenericDumpTestCase.java:65) > > >>> at > > >>> org.apache.bcel.generic.JDKGenericDumpTestCase.findJavaHomes > > >>> OnWindows(JDKGenericDumpTestCase.java:97) > > >>> at > > >>> org.apache.bcel.generic.JDKGenericDumpTestCase.findJavaHomes > > >>> (JDKGenericDumpTestCase.java:87) > > >>> at > > >>> org.apache.bcel.generic.JDKGenericDumpTestCase.data(JDKGener > > >>> icDumpTestCase.java:82) > > >>> > > >>> Oliver > > >>> > > >>> Am 03.12.2017 um 16:58 schrieb Gary Gregory: > > >>>> Do you have a full stack trace? It smells like the code that looks > for > > >>> JDK > > >>>> and JRE locations is failing. > > >>>> > > >>>> Gary > > >>>> > > >>>> On Dec 3, 2017 08:33, "Oliver Heger" <oliver.he...@oliver-heger.de> > > >>> wrote: > > >>>> > > >>>>> Hi, > > >>>>> > > >>>>> when building on Windows 10 with both Java 1.7 and 1.8 I get the > test > > >>>>> failure below. Does anybody else see this? > > >>>>> > > >>>>> Oliver > > >>>>> > > >>>>> Results : > > >>>>> > > >>>>> Tests in error: > > >>>>> > > >>>>> JDKGenericDumpTestCase.data:82->findJavaHomes:87-> > > >>>>> findJavaHomesOnWindows:97->addAllJavaHomesOnWindows:65 > > >>>>> ▒ Win32 > > >>>>> > > >>>>> Tests run: 107, Failures: 0, Errors: 1, Skipped: 0 > > >>>>> > > >>>>> $ mvn --version > > >>>>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > > >>>>> 2015-11-10T17:41:47+01:00) > > >>>>> Maven home: C:\data\dev\tools\apache-maven-3.3.9 > > >>>>> Java version: 1.8.0_144, vendor: Oracle Corporation > > >>>>> Java home: C:\Program Files\Java\jdk1.8.0_144\jre > > >>>>> Default locale: de_DE, platform encoding: Cp1252 > > >>>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: > "dos" > > >>>>> > > >>>>> > > >>>>> Am 01.12.2017 um 05:17 schrieb Gary Gregory: > > >>>>>> We fixed a few bugs and added some enhancements since we released > > >>> Apache > > >>>>>> Commons BCEL 6.1, so I would like to release Commons BCEL 6.2. > > >>>>>> > > >>>>>> Commons BCEL 6.2 RC1 is available for review here: > > >>>>>> https://dist.apache.org/repos/dist/dev/commons/bcel at svn > > >>> revision: > > >>>>>> 23349 > > >>>>>> > > >>>>>> The tag is here: > > >>>>>> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/ > > >>>>> BCEL_6_2_RC1/ > > >>>>>> (svn revision 1816763) > > >>>>>> N.B. the SVN revision is required because SVN tags are not > > >>> immutable. > > >>>>>> > > >>>>>> Maven artifacts are here: > > >>>>>> https://repository.apache.org/content/repositories/ > > >>>>> orgapachecommons-1294 > > >>>>>> > > >>>>>> These are the Maven artifacts and their hashes > > >>>>>> > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-test-sources.jar > > >>>>>> (SHA1: feef9dc39b67bf76d90a16abf3b5711d894bdafc) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2.jar.asc > > >>>>>> (SHA1: 10911db34eabbf5ed77175147d890431815a66e9) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-tests.jar.asc > > >>>>>> (SHA1: dd32ec245d2d664ee69a70bde304df5f577c3e8b) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-src.tar.gz.asc > > >>>>>> (SHA1: 1b6562ffec86267c8d1935dc1fa33c0fd225a094) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-bin.tar.gz.asc > > >>>>>> (SHA1: b7c31d213469b4044361b780890732f67859ec7e) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-bin.zip.asc > > >>>>>> (SHA1: 7137b7dfbc135aed1b2f8c7c974289e5ad645e3b) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-tests.jar > > >>>>>> (SHA1: 9de7ca4bbce76f7a877700ffc88bc2e36ef065ea) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-javadoc.jar > > >>>>>> (SHA1: 6eba2e55001a6093c8a9aa72132385e93fbe09d3) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-sources.jar > > >>>>>> (SHA1: df05f2afa0f58aefe5c3344fc67295ffc2050d53) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-test-sources.jar.asc > > >>>>>> (SHA1: 4999bb9f6d5ad677f13f1e5e856f8a76fdf3c8fc) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2.pom.asc > > >>>>>> (SHA1: 6fd1c5c4fbc96b83f06c421a99fc3ee7f975c310) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2.jar > > >>>>>> (SHA1: 2c1499b28bf2638cbdb5fa94350d41a46d2bd4e0) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-bin.tar.gz > > >>>>>> (SHA1: 9116cfccfb5f55a5a9e46fb685c7aa344712d52e) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-src.zip.asc > > >>>>>> (SHA1: 4b86e83b5c0dcd0e3abe86fda7ff5a9aaa1ab67d) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-bin.zip > > >>>>>> (SHA1: 95e191ca708c0187292dbef4fe42fd60f52d1d1a) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-sources.jar.asc > > >>>>>> (SHA1: 7e36d6e1ba882adf877306940184732f49c0385b) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-javadoc.jar.asc > > >>>>>> (SHA1: bee5e89f33d3e29d0d2c2d6ab6c56e0c06f0d20c) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-src.tar.gz > > >>>>>> (SHA1: 496c6f58f74ae55f513ed14c7268833289649236) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2.pom > > >>>>>> (SHA1: 3932199e50571760ae8acdd0f153a32891b5696c) > > >>>>>> /org/apache/bcel/bcel/6.2/bcel-6.2-src.zip > > >>>>>> (SHA1: 42c1b8e8ae6d3dafc56ae9c05c3f3ca0819c782c) > > >>>>>> > > >>>>>> I have tested this with Oracle Java 7 using Maven 3.5.2 on Windows > > 10. > > >>>>>> > > >>>>>> Details of changes since 6.1 are in the release notes: > > >>>>>> https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE- > > >>>>> NOTES.txt > > >>>>>> > > >>>>>> > > >>>>>> Site: > > >>>>>> https://people.apache.org/~ggregory/commons-bcel-3.2-RC1- > > site.zip > > >>>>>> (note some *relative* links are broken and the 1.2 directories > are > > >>>>>> not yet created - these will be OK once the site is deployed) > > >>>>>> > > >>>>>> The Clirr and RAT Reports (compared to 6.1) are in the zipped > site. > > >>>>>> > > >>>>>> KEYS: > > >>>>>> https://www.apache.org/dist/commons/KEYS > > >>>>>> > > >>>>>> Please review the release candidate and vote. This vote will close > > no > > >>>>>> sooner that 72 hours from now, sometime after 05:00 UTC 4-December > > >>> 2017 > > >>>>>> > > >>>>>> [ ] +1 Release these artifacts > > >>>>>> [ ] +0 OK, but... > > >>>>>> [ ] -0 OK, but really should fix... > > >>>>>> [ ] -1 I oppose this release because... > > >>>>>> > > >>>>>> Thanks! > > >>>>>> > > >>>>>> Gary Gregory, > > >>>>>> Apache Commons PMC Chair > > >>>>>> > > >>>>> > > >>>>> ------------------------------------------------------------ > > --------- > > >>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > >>>>> For additional commands, e-mail: dev-h...@commons.apache.org > > >>>>> > > >>>>> > > >>>> > > >>> > > >>> ------------------------------------------------------------ > --------- > > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > >>> For additional commands, e-mail: dev-h...@commons.apache.org > > >>> > > >>> > > >> > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > >
