On Thu, Dec 14, 2017 at 1:32 PM, Oliver Heger <oliver.he...@oliver-heger.de> wrote:
> > > Am 14.12.2017 um 01:38 schrieb Gary Gregory: > > On Wed, Dec 13, 2017 at 2:03 PM, Oliver Heger < > oliver.he...@oliver-heger.de> > > wrote: > > > >> Hi, > >> > >> thank you for your patience. > >> > >> Build works fine with Java 1.7 on Windows 10 (because of the Java 8 > >> Javadoc errors I built the site with 1.7). > >> > >> I have some minor findings: > >> - As Bruno already noticed, the release notes contain this strange text. > >> - In README.md the current version for the dependency should be updated. > >> - The jars with the sources contain spurious folders. > >> > > > > Can you be more specific please? > > If you open for instance commons-jcs-core-2.2.1-sources.jar from the > binary distribution, the jar contains a folder with an empty name and > one empty folder named "commons-jcs-core-2.2.1-sources". The folder with > the empty name has a path of sub folders down to > commons-jcs-core-2.2.1-sources.jar\\tmp\commons-jcs- > 2.2.1-RC3\commons-jcs-core\target\classes\META-INF\ > Yuck! ;-) Gary > > Oliver > > > > > Gary > > > > > >> - There are many Findbugs violations. > >> > >> The text in the release notes is really annoying, the other things are > >> not really blocking. But in total it prevents me from voting +1. So I am > >> rather +0. > >> > >> Oliver > >> > >> Am 13.12.2017 um 09:02 schrieb Romain Manni-Bucau: > >>> As discussed quite verbosely already I'd like to release JCS 2.2.1. I > >>> followed the commons procedure this time and hope it works for you. > >>> > >>> JCS 2.2.1 RC3 is available for review here: > >>> https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision > >> 23702) > >>> > >>> The tag is here: > >>> > >>> http://svn.apache.org/repos/asf/commons/proper/jcs/tags/ > >> commons-jcs-2.2.1-RC3/ > >>> (svn revision 1817933) > >>> > >>> Maven artifacts are here: > >>> https://repository.apache.org/content/repositories/ > >> orgapachecommons-1298 > >>> > >>> I have tested this with JDK 7, 8 using Maven 3.5.0. > >>> > >>> Details of changes since 2.2 are in the release notes: > >>> https://dist.apache.org/repos/dist/dev/commons/jcs/RELEASE- > NOTES.txt > >>> > >>> http://home.apache.org/~rmannibucau/commons-jcs-2.2.1- > >> RC3/changes-report.html > >>> > >>> Site: > >>> http://home.apache.org/~rmannibucau/commons-jcs-2.2.1-RC3/ > >>> > >>> Clirr Report (compared to 2.2): > >>> > >>> http://home.apache.org/~rmannibucau/commons-jcs-2.2.1- > >> RC3/commons-jcs-core/clirr-report.html > >>> > >>> RAT Report: > >>> > >>> http://home.apache.org/~rmannibucau/commons-jcs-2.2.1- > >> RC3/rat-report.html > >>> (the zipcodes.txt file is intended to not have headers) > >>> > >>> KEYS: > >>> https://www.apache.org/dist/commons/KEYS > >>> > >>> Please review the release candidate and vote. > >>> This vote will close no sooner that 72 hours from now, > >>> i.e. sometime after 08:15 UTC 16-December 2017 > >>> > >>> [ ] +1 Release these artifacts > >>> [ ] +-0 Don't care > >>> [ ] -1 I oppose this release ${because} > >>> > >>> Thanks! > >>> Romain > >>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
