[ X ] -1 I oppose this release because... For now, as I was not able to build commons-dbcp with 2.5.0 (see previous thread at [1]). See last part of this e-mail for more. Happy to change my vote in case anyone else can verify we will be able to update commons-dbcp to use commons-pool 2.5.0.
Build from tag passing with on errors with `mvn clean test site` on Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2 Java version: 1.8.0_151, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-oracle/jre Default locale: en_NZ, platform encoding: UTF-8 OS name: "linux", version: "4.4.0-103-generic", arch: "amd64", family: "unix" Site generated correctly. No new issues found, actually Checkstyle got several warnings fixed (kudos!). Coverage slightly increased. Checked signature of files in Maven repository and in the dist area. All looking good. Had a look at the fix for POOL-335 (commit 3956eedbfcd8f57263892bb6667d21a839f67990), code looks good. Did a `mvn install -DskipTests` to get the 2.5.0 jar in my local Maven repository. Then cloned commons-dbcp. Had to checkout one commit before the master head due to build failures (see comment here for more https://github.com/apache/commons-dbcp/commit/7b9fba0be5f9ae7daf55d995b980646838f8975e). Ran `mvn clean test` on commons-dbcp; no errors. Updated commons-pool version to 2.4.3 and got test failures as before POOL-335. Finally, updated the pom.xml to 2.5.0. Didn't get the same error as before, but the build just hang with the messages below. I left it running for some good 10 minutes with no different output. Then stopped it and did another `mvn clean test` (which worked with 2.4.3, same commit 91edebfed2377e4d5d39335538a53f029c3ddc50), and it just got stuck again. --- snip --- ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.commons.dbcp2.managed.TestBasicManagedDataSource Exception in thread "Thread-2" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-3" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-4" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-14" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-9" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-13" Exception in thread "Thread-6" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-8" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-12" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-5" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-11" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-10" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) Exception in thread "Thread-7" java.lang.NoClassDefFoundError: Could not initialize class org.apache.commons.pool2.impl.DefaultPooledObject at org.apache.commons.dbcp2.managed.PoolableManagedConnectionFactory.makeObject(PoolableManagedConnectionFactory.java:98) at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337) at org.apache.commons.dbcp2.managed.BasicManagedDataSource.createPoolableConnectionFactory(BasicManagedDataSource.java:205) at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056) at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533) at org.apache.commons.dbcp2.TestBasicDataSource.getConnection(TestBasicDataSource.java:52) at org.apache.commons.dbcp2.TestConnectionPool.newConnection(TestConnectionPool.java:87) at org.apache.commons.dbcp2.TestConnectionPool$TestThread.run(TestConnectionPool.java:620) at java.lang.Thread.run(Thread.java:748) --- snip --- Cheers Bruno [1] http://markmail.org/message/pmyjbzyjc26kbljs ________________________________ From: Gary Gregory <[email protected]> To: Commons Developers List <[email protected]> Sent: Sunday, 17 December 2017 11:35 AM Subject: [VOTE] Release Apache Commons Pool 2.5.0 based on RC1 We have fixed quite a few bugs and added some enhancements since Apache Commons Pool 2.4.3 was released, so I would like to release Apache Commons Pool 2.5.0. Apache Commons Pool 2.5.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/pool/ (svn revision 23755) The tag is here: https://git-wip-us.apache.org/repos/asf?p=commons-pool.git;a=tag;h=dac29bd1ce13349fd989ca279df178ff73935d1d Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1299 These are the Maven artifacts and their hashes /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0.jar.asc (SHA1: 8c1f55975ebfef185209c12429f587bc1256636e) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-javadoc.jar.asc (SHA1: 83d3316533c776413f2a0dd42526a6a31ac46e46) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-sources.jar (SHA1: e2aae3697db27fd0de4d26c7d370e7d802eea3f6) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0.pom (SHA1: 2e13032776a6d3a641a58e1c1ea64bd605661130) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-tests.jar (SHA1: af3d96706a0a45d143e5b479cfa8da8d3835ab47) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-bin.zip.asc (SHA1: 3b54c00d08748dcbe7ab9a65d510bfa86f81f700) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-tests.jar.asc (SHA1: 647578272eb02c850143965888f70d2e1d5e161e) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-src.zip (SHA1: 6baf8c229e09252b3e158dcde61cfdbe21b31920) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-sources.jar.asc (SHA1: 7671f1a41493442091a87bea06ded52efe149af8) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0.jar (SHA1: cb7d05e6308ad795decc4a12ede671113c11dd98) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-javadoc.jar (SHA1: ca115b4c6777d03cd5e172c517e14010719dd9fd) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-src.tar.gz (SHA1: bd4fbc00e7ce2d294ffeda9d12ebda5265ad2fe3) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-src.zip.asc (SHA1: 9ec1d48c147e5646ff39b61d14c5abefac401edc) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0.pom.asc (SHA1: 39f587b18ec6df7dbf5341f1e7b9da6353400578) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-bin.zip (SHA1: 43b1b0b5662696f701c2be63cfc2f42fbc8f238e) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-test-sources.jar (SHA1: e7bfd87691e44a91c6ef19ba9076c1d7cc9f4147) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-bin.tar.gz (SHA1: 00828dfb4830c2f69208d51e5db30737cbef44a3) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-bin.tar.gz.asc (SHA1: 7b7e9ebfc54962aa5fd77b8847ac01caa527a644) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-src.tar.gz.asc (SHA1: 09c73953f752cbe382ff862b15809e7c9be4ecd3) /org/apache/commons/commons-pool2/2.5.0/commons-pool2-2.5.0-test-sources.jar.asc (SHA1: 1a09c518ea54bc9e5792091fddcdccdc18b58b61) I have tested 'mvn clean install' with: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T01:58:13-06:00) Maven home: C:\Java\apache-maven-3.5.2\bin\.. Java version: 1.7.0_80, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_80\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows" Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T01:58:13-06:00) Maven home: C:\Java\apache-maven-3.5.2\bin\.. Java version: 1.8.0_152, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.8.0_152\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T01:58:13-06:00) Maven home: C:\Java\apache-maven-3.5.2\bin\.. Java version: 9.0.1, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk-9.0.1 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T01:58:13-06:00) Maven home: C:\Java\apache-maven-3.5.2\bin\.. Java version: 10-ea, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk-10 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Java(TM) SE Runtime Environment (build 10-ea+29) Java HotSpot(TM) 64-Bit Server VM (build 10-ea+29, mixed mode) Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T01:58:13-06:00) Maven home: C:\Java\apache-maven-3.5.2\bin\.. Java version: 1.8.0, vendor: IBM Corporation Java home: C:\eclipse\IBM-6.4.5\ibm_sdk80\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "x86", family: "windows" Note that some unit test classes take more than one minute to complete. Note that TestGenericKeyedObjectPool fails randomly as it has more me for a long time. Details of changes since 2.4.3 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt The change report is included in the site zip. Site: https://dist.apache.org/repos/dist/dev/commons/pool/size.zip at revision: 23756 (note some *relative* links are broken and the 2.5.0 directories are not yet created - these will be OK once the site is deployed) Clirr Report (compared to 2.4.3): Run mvn clirr:check RAT Report: Run mvn apache-rat:check or see the site zip. KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now, i.e. sometime after 04:00 UTC 31-March 2010 [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thanks! Gary --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
