Hi Jörg,

Thank you for taking the time to review.

The -sources jar are built by 'mvn deploy' I believe. How are they broken
for you?

Gary

On Fri, Dec 22, 2017 at 12:28 PM, Jörg Schaible <joerg.schai...@gmx.de>
wrote:

> Hi,
>
> the build from source is fine for my compiler zoo from Java 1.7 to 9.
> However, if the final release contains
> broken -sources files, my vote is -1.
>
> Those files are very valuable e.g. developing with Eclipse, because they
> are used in the debugger to jump
> directly into the source, if you depend on commons-jcs.
>
> Sadly those files are not build when calling
>   mvn clean package
>
> Therefore I could not check, if I'd get the same strange result.
>
> Cheers,
> Jörg
>
> Am Wed, 13 Dec 2017 09:02:55 +0100 schrieb Romain Manni-Bucau:
>
> > As discussed quite verbosely already I'd like to release JCS 2.2.1. I
> > followed the commons procedure this time and hope it works for you.
> >
> > JCS 2.2.1 RC3 is available for review here:
> >     https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision
> >     23702)
> >
> > The tag is here:
> >
> > http://svn.apache.org/repos/asf/commons/proper/jcs/tags/
> commons-jcs-2.2.1-RC3/
> > (svn revision 1817933)
> >
> > Maven artifacts are here:
> >     https://repository.apache.org/content/repositories/
> orgapachecommons-1298
> >
> > I have tested this with JDK 7, 8 using Maven 3.5.0.
> >
> > Details of changes since 2.2 are in the release notes:
> >     https://dist.apache.org/repos/dist/dev/commons/jcs/RELEASE-NOTES.txt
> >
> > http://home.apache.org/~rmannibucau/commons-jcs-2.2.1-
> RC3/changes-report.html
> >
> > Site:
> >         http://home.apache.org/~rmannibucau/commons-jcs-2.2.1-RC3/
> >
> > Clirr Report (compared to 2.2):
> >
> > http://home.apache.org/~rmannibucau/commons-jcs-2.2.1-
> RC3/commons-jcs-core/clirr-report.html
> >
> > RAT Report:
> >
> > http://home.apache.org/~rmannibucau/commons-jcs-2.2.1-
> RC3/rat-report.html
> > (the zipcodes.txt file is intended to not have headers)
> >
> > KEYS:
> >   https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner that 72 hours from now,
> > i.e. sometime after 08:15 UTC 16-December 2017
> >
> >   [ ] +1 Release these artifacts [ ] +-0 Don't care [ ] -1 I oppose this
> >   release ${because}
> >
> > Thanks!
> > Romain
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Reply via email to