On 19/06/18 16:03, Gary Gregory wrote: > What is odd is that you've added generics to places where there are none.
Ah. Found it. My local DBCP workspace depends on the local Pool workspace rather than the 2.5.0 release. I was picking up genrics changes that will be in the next pool release and adapting DBCP too them. I'll revert those premature changes shortly. Mark > > Gary > > On Tue, Jun 19, 2018 at 8:42 AM Mark Thomas <ma...@apache.org> wrote: > >> On 19 June 2018 15:23:52 BST, Gary Gregory <garydgreg...@gmail.com> wrote: >>> Mark, >>> >>> I'm not sure what compiler you are using, but these changes break the >>> build >>> in Jenkins, in my local Eclipse workspace, and with Maven and Orcale >>> Java >>> 8. Please fix: >> >> Odd. I'm using Eclipse and Java 8 and was seeing generics warnings before >> these changes. I checked Eclipse was set to compile for Java 8 before >> making the change. I did see something along these lines in the Tomcat 8 >> build that uses the same code but that builds with Java 7. >> >> Let me recheck all my compilation settings and also test with Maven on the >> command line and see if I can figure out what is going on here. >> >> Mark >> >> >> >>> >>> [ERROR] COMPILATION ERROR : >>> [INFO] ------------------------------------------------------------- >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java:[2297,42] >>> type org.apache.commons.pool2.impl.GenericObjectPoolConfig does not >>> take >>> parameters >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java:[2466,61] >>> type org.apache.commons.pool2.impl.GenericObjectPoolConfig does not >>> take >>> parameters >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java:[312,47] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java:[312,118] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java:[74,47] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java:[74,118] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java:[185,47] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java:[185,118] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java:[2262,38] >>> type org.apache.commons.pool2.impl.GenericObjectPoolConfig does not >>> take >>> parameters >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java:[2262,95] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericObjectPoolConfig >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java:[176,43] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] >> >>> /C:/vcs/git/apache/commons/commons-dbcp/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java:[176,110] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> >>> Gary >>> >>> ---------- Forwarded message --------- >>> From: Apache Jenkins Server <jenk...@builds.apache.org> >>> Date: Tue, Jun 19, 2018 at 4:13 AM >>> Subject: Build failed in Jenkins: commons-dbcp #237 >>> To: <notificati...@commons.apache.org> >>> >>> >>> See < >>> >> https://builds.apache.org/job/commons-dbcp/237/display/redirect?page=changes >>>> >>> >>> Changes: >>> >>> [markt] Fill in some gaps in the Javadoc >>> >>> ------------------------------------------ >>> Started by an SCM change >>> [EnvInject] - Loading node environment variables. >>> Building remotely on H10 (Hadoop) in workspace < >>> https://builds.apache.org/job/commons-dbcp/ws/> >>>> git rev-parse --is-inside-work-tree # timeout=10 >>> Fetching changes from the remote Git repository >>>> git config remote.origin.url >>> https://git-wip-us.apache.org/repos/asf/commons-dbcp.git # timeout=10 >>> Fetching upstream changes from >>> https://git-wip-us.apache.org/repos/asf/commons-dbcp.git >>>> git --version # timeout=10 >>>> git fetch --tags --progress >>> https://git-wip-us.apache.org/repos/asf/commons-dbcp.git >>> +refs/heads/*:refs/remotes/origin/* >>>> git rev-parse refs/remotes/origin/master^{commit} # timeout=10 >>>> git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10 >>> Checking out Revision ac934778af1eeb4d6dba25a7351c59430a3c8fc9 >>> (refs/remotes/origin/master) >>>> git config core.sparsecheckout # timeout=10 >>>> git checkout -f ac934778af1eeb4d6dba25a7351c59430a3c8fc9 >>> Commit message: "Fill in some gaps in the Javadoc" >>>> git rev-list --no-walk c50607e7c834422c7fd926a345b1badebd1a2675 # >>> timeout=10 >>> Parsing POMs >>> Established TCP socket on 48797 >>> maven35-agent.jar already up to date >>> maven35-interceptor.jar already up to date >>> maven3-interceptor-commons.jar already up to date >>> [commons-dbcp] $ /home/jenkins/tools/java/latest1.8/bin/java -Xmx2g >>> -Xms256m -cp >> >>> /home/jenkins/jenkins-slave/maven35-agent.jar:/home/jenkins/tools/maven/latest3/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/latest3/conf/logging >>> jenkins.maven3.agent.Maven35Main /home/jenkins/tools/maven/latest3/ >>> /home/jenkins/jenkins-slave/slave.jar >>> /home/jenkins/jenkins-slave/maven35-interceptor.jar >>> /home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 48797 >>> <===[JENKINS REMOTING CAPACITY]===> channel started >>> Executing Maven: -B -f < >>> https://builds.apache.org/job/commons-dbcp/ws/pom.xml> >>> -Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/0 -V >>> clean install --batch-mode -Dgpg.skip -Prelease >>> [1mApache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; >>> 2017-10-18T07:58:13Z) [m >>> Maven home: /usr/local/asfpackages/maven/apache-maven-3.5.2 >>> Java version: 1.8.0_172, vendor: Oracle Corporation >>> Java home: /usr/local/asfpackages/java/jdk1.8.0_172/jre >>> Default locale: en_US, platform encoding: ISO-8859-1 >>> OS name: "linux", version: "3.13.0-137-generic", arch: "amd64", family: >>> "unix" >>> [INFO] Scanning for projects... >>> [WARNING] The project >>> org.apache.commons:commons-dbcp2:jar:2.5.0-SNAPSHOT >>> uses prerequisites which is only intended for maven-plugin projects but >>> not >>> for non maven-plugin projects. For such purposes you should use the >>> maven-enforcer-plugin. See >>> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html >>> [INFO] >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] Building Apache Commons DBCP 2.5.0-SNAPSHOT >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] >>> [INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ >>> commons-dbcp2 >>> --- >>> [INFO] Deleting <https://builds.apache.org/job/commons-dbcp/ws/target> >>> [INFO] >>> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce >>> (enforce-maven-version) @ >>> commons-dbcp2 --- >>> [INFO] >>> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-maven-3) @ >>> commons-dbcp2 --- >>> [INFO] >>> [INFO] --- build-helper-maven-plugin:3.0.0:parse-version >>> (parse-version) @ >>> commons-dbcp2 --- >>> [INFO] >>> [INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @ >>> commons-dbcp2 >>> --- >>> [INFO] Executing tasks >>> >>> main: >>> [copy] Copying 2 files to < >>> https://builds.apache.org/job/commons-dbcp/ws/target/apidocs/META-INF> >>> [INFO] Executed tasks >>> [INFO] >>> [INFO] --- maven-remote-resources-plugin:1.5:process >>> (process-resource-bundles) @ commons-dbcp2 --- >>> [INFO] >>> [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ >>> commons-dbcp2 --- >>> [INFO] Executing: /bin/sh -c cd '< >>> https://builds.apache.org/job/commons-dbcp/ws/'> && 'git' 'rev-parse' >>> '--verify' 'HEAD' >>> [INFO] Working directory: >>> <https://builds.apache.org/job/commons-dbcp/ws/> >>> [INFO] Storing buildNumber: ac934778af1eeb4d6dba25a7351c59430a3c8fc9 at >>> timestamp: 1529403164143 >>> [WARNING] Cannot get the branch information from the git repository: >>> Detecting the current branch failed: fatal: ref HEAD is not a symbolic >>> ref >>> >>> [INFO] Executing: /bin/sh -c cd '< >>> https://builds.apache.org/job/commons-dbcp/ws/'> && 'git' 'rev-parse' >>> '--verify' 'HEAD' >>> [INFO] Working directory: >>> <https://builds.apache.org/job/commons-dbcp/ws/> >>> [INFO] Storing buildScmBranch: UNKNOWN >>> [INFO] >>> [INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @ >>> commons-dbcp2 --- >>> [INFO] Using 'UTF-8' encoding to copy filtered resources. >>> [INFO] Copying 1 resource >>> [INFO] Copying 2 resources to META-INF >>> [INFO] >>> [INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ >>> commons-dbcp2 --- >>> [INFO] Changes detected - recompiling the module! >>> [INFO] Compiling 60 source files to < >>> https://builds.apache.org/job/commons-dbcp/ws/target/classes> >>> [INFO] ------------------------------------------------------------- >>> [ERROR] COMPILATION ERROR : >>> [INFO] ------------------------------------------------------------- >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java >>> :[2297,42] >>> type org.apache.commons.pool2.impl.GenericObjectPoolConfig does not >>> take >>> parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java >>> :[2466,61] >>> type org.apache.commons.pool2.impl.GenericObjectPoolConfig does not >>> take >>> parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java >>> :[176,43] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java >>> :[176,110] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java >>> :[2262,38] >>> type org.apache.commons.pool2.impl.GenericObjectPoolConfig does not >>> take >>> parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java >>> :[2262,95] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericObjectPoolConfig >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java >>> :[312,47] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java >>> :[312,118] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java >>> :[185,47] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java >>> :[185,118] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java >>> :[74,47] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java >>> :[74,118] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [INFO] 12 errors >>> [INFO] ------------------------------------------------------------- >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] BUILD FAILURE >>> [INFO] >>> ------------------------------------------------------------------------ >>> [INFO] Total time: 24.199 s >>> [INFO] Finished at: 2018-06-19T10:12:57Z >>> [INFO] Final Memory: 30M/402M >>> [INFO] >>> ------------------------------------------------------------------------ >>> Waiting for Jenkins to finish collecting data >>> [ERROR] Failed to execute goal >>> org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile >>> (default-compile) on project commons-dbcp2: Compilation failure: >>> Compilation failure: >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java >>> :[2297,42] >>> type org.apache.commons.pool2.impl.GenericObjectPoolConfig does not >>> take >>> parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java >>> :[2466,61] >>> type org.apache.commons.pool2.impl.GenericObjectPoolConfig does not >>> take >>> parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java >>> :[176,43] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java >>> :[176,110] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java >>> :[2262,38] >>> type org.apache.commons.pool2.impl.GenericObjectPoolConfig does not >>> take >>> parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java >>> :[2262,95] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericObjectPoolConfig >>> [ERROR] reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericObjectPoolConfig >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java >>> :[312,47] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java >>> :[312,118] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java >>> :[185,47] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java >>> :[185,118] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java >>> :[74,47] >>> type org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig does >>> not >>> take parameters >>> [ERROR] < >>> >> https://builds.apache.org/job/commons-dbcp/ws/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java >>> :[74,118] >>> cannot infer type arguments for >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] reason: cannot use '<>' with non-generic class >>> org.apache.commons.pool2.impl.GenericKeyedObjectPoolConfig >>> [ERROR] -> [Help 1] >>> [ERROR] >>> [ERROR] To see the full stack trace of the errors, re-run Maven with >>> the -e >>> switch. >>> [ERROR] Re-run Maven using the -X switch to enable full debug logging. >>> [ERROR] >>> [ERROR] For more information about the errors and possible solutions, >>> please read the following articles: >>> [ERROR] [Help 1] >>> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException >>> [JENKINS] Archiving >>> <https://builds.apache.org/job/commons-dbcp/ws/pom.xml> >>> to >> >>> org.apache.commons/commons-dbcp2/2.5.0-SNAPSHOT/commons-dbcp2-2.5.0-SNAPSHOT.pom >>> Sending e-mails to: notificati...@commons.apache.org >>> channel stopped >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
