Hi.
On Wed, 25 Jul 2018 08:56:23 -0600, Gary Gregory wrote:
-0:
- Don't forget to set the date in
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/changes-report.html
and changes.xml, I try to remember to do this in an RC, not after.
It's in
doc/release/release.howto.txt
;-)
- When I've recently emailed an announcement for a release, the email
bounced because I did not have a link to the download page. So I
added that
to the RELEASE NOTES file which is what I use as the content of the
announcement email.
- There is no Jacoco report, it is empty:
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/jacoco-aggregate/index.html
Jacoco reports are per module.
-
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/rat-report.html:
It is OK to include old release notes IMO, it shows history in one
place.
In fact, I keep all RNs in the one file.
From src zip: ASC, SHA1, SHA256 all OK.
Running 'mvn clean package' I get:
[INFO] Running
org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time
elapsed:
6.799 s - in
org.apache.commons.rng.sampling.distribution.DiscreteSamplerParametricTest
[INFO] Running org.apache.commons.rng.sampling.ListSamplerTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time
elapsed:
0.008 s - in org.apache.commons.rng.sampling.ListSamplerTest
[INFO] Running org.apache.commons.rng.sampling.PermutationSamplerTest
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time
elapsed:
0.002 s - in org.apache.commons.rng.sampling.PermutationSamplerTest
[INFO] Running org.apache.commons.rng.sampling.UnitSphereSamplerTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time
elapsed:
0.536 s - in org.apache.commons.rng.sampling.UnitSphereSamplerTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ContinuousSamplerParametricTest.testSampling:53->check:127
Box-Muller Gaussian deviate
[rng=org.apache.commons.rng.core.source32.MersenneTwister]: Too many
failures for sample size = 20000 (4 out of 50 tests failed,
chi2=[22.72,
25.762, 22.699, 27.368000000000002]
[ERROR] ContinuousSamplerParametricTest.testSampling:53->check:127
org.apache.commons.math3.distribution.LevyDistribution@9635fa
(inverse
method) [rng=org.apache.commons.rng.core.source64.TwoCmres (Cmres:
[0xedce446814d3b3d9L, 33, 330658535] + Cmres: [0xc5b3cf786c806df7L,
33,
331932042])]: Too many failures for sample size = 20000 (3 out of 50
tests
failed, chi2=[25.312000000000005, 26.64, 24.348999999999997]
[INFO]
[ERROR] Tests run: 77, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Commons RNG 1.1 ............................. SUCCESS [
9.260 s]
[INFO] Apache Commons RNG Client API ...................... SUCCESS [
3.074 s]
[INFO] Apache Commons RNG Core ............................ SUCCESS [
17.107 s]
[INFO] Apache Commons RNG Simple .......................... SUCCESS [
11.149 s]
[INFO] Apache Commons RNG Sampling ........................ FAILURE
[01:21
min]
[INFO] Apache Commons RNG Examples ........................ SKIPPED
[INFO] Stress test example ................................ SKIPPED
[INFO] Sampling example ................................... SKIPPED
[INFO] Quadrature example ................................. SKIPPED
[INFO] JMH Benchmark ...................................... SKIPPED
[INFO] JPMS Integration test .............................. SKIPPED
[INFO] JPMS module example (library) ...................... SKIPPED
[INFO] JPMS module example (application) .................. SKIPPED
[INFO] Apache Commons RNG (full distribution) 1.1 ......... SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 02:03 min
[INFO] Finished at: 2018-07-25T08:51:16-06:00
[INFO]
------------------------------------------------------------------------
Using:
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime:
C:\Program
Files\Java\jdk1.8.0_181\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family:
"windows"
I do not think we can ship unless we give clear instructions in the
readme
and release notes, set expectations, and provide instructions (Maven
commands.)
One of the items we should document is: The build the jars while
skipping
the tests, run 'mvn clean package -DskipTests'
I don't think that this is good advice.
Better let people inquire here about why it sometimes fails.
[They might contribute improvement to the unit test suite,
or the sampling code if it turns out that the test indeed
fails too often (see below).]
In the above case, we clearly do not expect the failure since we give
a
nice and simple message 'Too many failures for sample size'. So
either this
is a bug in the main code or in the test code. You tell me.
It is easy to make the failures much less frequent: just
change the threshold from 3 to 4; but before doing so, we
*must* ensure that it is correct to do so, according to
stat theory.
Rob has indicated that he'd have a look after the release
(thanks!).
Regards,
Gilles
Gary
On Wed, Jul 25, 2018 at 7:17 AM Rob Tompkins <chtom...@apache.org>
wrote:
We have added some significant enhancements since Apache Commons RNG
(full
distribution) 1.0 was released, so I would like to release Apache
Commons
RNG (full distribution) 1.1.
Apache Commons RNG (full distribution) 1.1 RC3 is available for
review
here:
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3 (svn
revision 28335, site added at 28336)
The Git tag RNG_1_1_RC3 commit for this RC is available for review
here:
https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC3
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1357
These are the Maven artifacts and their hashes in Nexus:
#Nexus SHA-1s
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.pom
(SHA1: a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-test-sources.jar
(SHA1: 9e8216ee90a537c5c884d7993f31a08571d37a65)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-javadoc.jar
(SHA1: ceb66adfa6d665bbfdb9be1e7e28f9febf01214a)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-tests.jar
(SHA1: e1430499f6fcf341f342fd9f9960daacd08c9635)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1.jar
(SHA1: 22ec28d4a80034502bcda89fa7f55f332269f874)
/org/apache/commons/commons-rng-simple/1.1/commons-rng-simple-1.1-sources.jar
(SHA1: 2cf4cda85ee44cf0e17ce5a14cc176939613d79b)
/org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1.pom
(SHA1: 3f7ea1a87752477a10e62bdbf991acc86791b0a9)
/org/apache/commons/commons-rng-parent/1.1/commons-rng-parent-1.1-site.xml
(SHA1: 6e1df36b720e14eed524396107481e509ff42c7c)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.jar
(SHA1: 004f4e3ba04b662c1ccbcbadad01f0a7dac4c6df)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-sources.jar
(SHA1: d24f113fc5192d769be65b937356bd05d7fe59ef)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-tests.jar
(SHA1: 5549762e88fd2505caeae712636066f956bc0465)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-test-sources.jar
(SHA1: 641105db090f267b46b73d56b8741fff2805800b)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1.pom
(SHA1: 26ec84056b9a4526bc5e05ecf4ece8d9c3d57aad)
/org/apache/commons/commons-rng-client-api/1.1/commons-rng-client-api-1.1-javadoc.jar
(SHA1: 75712250264765649948fa589beb3ac883e492d4)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-javadoc.jar
(SHA1: 26046b6582982748cf912130c1b047b0fa0554ae)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-sources.jar
(SHA1: 32b694cc43e9ae7e9f41a519c08b300a35cdbc95)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-tests.jar
(SHA1: 03e5baff332fe16f8279d5800782af1cabcdf57d)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.jar
(SHA1: 4b9a38a5abf0118811a599472ffd06f666ddf7dd)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1-test-sources.jar
(SHA1: 2f71531f4aa2b590561e378dbd31d04dc467e3f7)
/org/apache/commons/commons-rng-examples-sampling/1.1/commons-rng-examples-sampling-1.1.pom
(SHA1: 04c2a060613758d5ca233f4bbc2b6fd947693207)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-javadoc.jar
(SHA1: 863a507e373ee5c6c9d3bcc64fe950562a044cd1)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-sources.jar
(SHA1: 296007f2657ae0d162f45da84a727ba967a691f7)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.pom
(SHA1: 6af16fa13e06fbba809d64803fae689bd40e2679)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-tests.jar
(SHA1: 6fb83e23389388133bc4840f9feb9412800567fe)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1-test-sources.jar
(SHA1: c8ebe6da223727039e41938765533b60ac1e5308)
/org/apache/commons/commons-rng-examples-jpms-app/1.1/commons-rng-examples-jpms-app-1.1.jar
(SHA1: 12c795044794f698c9d14c5df66e7cc3a0743c05)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1.jar
(SHA1: 7d2b707dfb680393de55ea79f1a781a3c604bdb6)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1-javadoc.jar
(SHA1: 885cfe9f3d90b3d6210b4b2880973605f60ad807)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1.pom
(SHA1: cd4b2d45949778e8fbee15eda94faac1d0a4b460)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1-test-sources.jar
(SHA1: 2f4ef16a825ebda770398604ecd3c53e3d77f543)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1-sources.jar
(SHA1: 9ee3bc25c80505e82efc6e2715e1d4351f0072a3)
/org/apache/commons/commons-rng-examples-quadrature/1.1/commons-rng-examples-quadrature-1.1-tests.jar
(SHA1: ac7cfd8c0f602b30363d83be9d17294fc3ee5876)
/org/apache/commons/commons-rng-core/1.1/commons-rng-core-1.1-tests.jar
(SHA1: 3ee2f86a7ef4be313a33a72bea7490ebe18fa9aa)
/org/apache/commons/commons-rng-core/1.1/commons-rng-core-1.1-sources.jar
(SHA1: 5a0fade6d4477ecec61b3b6e1fad2de5bd77aebe)
/org/apache/commons/commons-rng-core/1.1/commons-rng-core-1.1-javadoc.jar
(SHA1: 34c6b85d1d5d4aa0788d902778e9d41a493d513a)
/org/apache/commons/commons-rng-core/1.1/commons-rng-core-1.1-test-sources.jar
(SHA1: 622ae6f6c5d8d49c92c2407d41a44545ff903ac7)
/org/apache/commons/commons-rng-core/1.1/commons-rng-core-1.1.jar
(SHA1: e52b54680d92dadbe95efa60ab6c9326ed0ef9a4)
/org/apache/commons/commons-rng-core/1.1/commons-rng-core-1.1.pom
(SHA1: 196e691038f3eb7eb3a45693315b9ca1e4d73e90)
/org/apache/commons/commons-rng-examples/1.1/commons-rng-examples-1.1.pom
(SHA1: 33dfc5f171501a66350bdf79ceb9c5d5e67b7a9f)
/org/apache/commons/commons-rng-examples-jpms/1.1/commons-rng-examples-jpms-1.1.pom
(SHA1: 26750469ded4dedb49d9a3cabf773d7bac8f3895)
/org/apache/commons/commons-rng-examples-jmh/1.1/commons-rng-examples-jmh-1.1-sources.jar
(SHA1: bf149e02990339a339a3f415df3334b433632c5f)
/org/apache/commons/commons-rng-examples-jmh/1.1/commons-rng-examples-jmh-1.1-tests.jar
(SHA1: ded2d8712d5fe918e997ee49f0c504bc0c60f5f8)
/org/apache/commons/commons-rng-examples-jmh/1.1/commons-rng-examples-jmh-1.1-javadoc.jar
(SHA1: f167f46897c80dd5bf226e4f8281a42d378c898d)
/org/apache/commons/commons-rng-examples-jmh/1.1/commons-rng-examples-jmh-1.1-test-sources.jar
(SHA1: edd0e9704e35d3d18f946cbad316078304c744a9)
/org/apache/commons/commons-rng-examples-jmh/1.1/commons-rng-examples-jmh-1.1.jar
(SHA1: e6a63152fe5c19c630adde42f5ee405453117104)
/org/apache/commons/commons-rng-examples-jmh/1.1/commons-rng-examples-jmh-1.1.pom
(SHA1: ba8c971bbcf39e7732ff115fd074c6434c80e9c2)
/org/apache/commons/commons-rng-examples-jpms-lib/1.1/commons-rng-examples-jpms-lib-1.1-sources.jar
(SHA1: dcca33bd6569da8dbbcff0fc08de12f3fae3a03c)
/org/apache/commons/commons-rng-examples-jpms-lib/1.1/commons-rng-examples-jpms-lib-1.1.pom
(SHA1: 26f632574209c421f432b682acd7a4b8bc62a0e6)
/org/apache/commons/commons-rng-examples-jpms-lib/1.1/commons-rng-examples-jpms-lib-1.1-tests.jar
(SHA1: a97d7126c23506ec3cf290a156df6bad42f2218d)
/org/apache/commons/commons-rng-examples-jpms-lib/1.1/commons-rng-examples-jpms-lib-1.1-test-sources.jar
(SHA1: 6ed6b821b56563dd45440dd77b597de623ca1e43)
/org/apache/commons/commons-rng-examples-jpms-lib/1.1/commons-rng-examples-jpms-lib-1.1-javadoc.jar
(SHA1: f6304baedb4fa3faf0a7f63c44e35bf223487cda)
/org/apache/commons/commons-rng-examples-jpms-lib/1.1/commons-rng-examples-jpms-lib-1.1.jar
(SHA1: 2085eb0ed9ca9e6941f084ffd04a933b21f6198d)
/org/apache/commons/commons-rng-examples-stress/1.1/commons-rng-examples-stress-1.1-tests.jar
(SHA1: 8593aff451d58a8aca2f806d46aa08742f708310)
/org/apache/commons/commons-rng-examples-stress/1.1/commons-rng-examples-stress-1.1.jar
(SHA1: f387d662f5a59ac5ed42f24bcdc14e3d00872c71)
/org/apache/commons/commons-rng-examples-stress/1.1/commons-rng-examples-stress-1.1-javadoc.jar
(SHA1: 256efdb5d7603b4a781a5990046c500a18a894ed)
/org/apache/commons/commons-rng-examples-stress/1.1/commons-rng-examples-stress-1.1.pom
(SHA1: 47a453485200b2334436ec4d0886c2999642792a)
/org/apache/commons/commons-rng-examples-stress/1.1/commons-rng-examples-stress-1.1-sources.jar
(SHA1: 4168333045cdc8bb44f49e03041529c0543f6c4a)
/org/apache/commons/commons-rng-examples-stress/1.1/commons-rng-examples-stress-1.1-test-sources.jar
(SHA1: 014d9dc0e34d435aeb0b51ea4e0c102b3ced7bb7)
/org/apache/commons/commons-rng-sampling/1.1/commons-rng-sampling-1.1-javadoc.jar
(SHA1: 5a8931d559324a1159733e47837cf4820ade3338)
/org/apache/commons/commons-rng-sampling/1.1/commons-rng-sampling-1.1-test-sources.jar
(SHA1: 957c1e38edb6414c96b09a6498e9a7089669da42)
/org/apache/commons/commons-rng-sampling/1.1/commons-rng-sampling-1.1-tests.jar
(SHA1: c63ab94ff093743b3998e3bb1b1e5efe81c2a9a7)
/org/apache/commons/commons-rng-sampling/1.1/commons-rng-sampling-1.1-sources.jar
(SHA1: 1126b2cf1b46d1cc0bc76ae16c90e97f79a21904)
/org/apache/commons/commons-rng-sampling/1.1/commons-rng-sampling-1.1.jar
(SHA1: 3f99620546e31f299bb6473850d1ded09f94c03a)
/org/apache/commons/commons-rng-sampling/1.1/commons-rng-sampling-1.1.pom
(SHA1: 6321863616bf687731d2c3d28fe6ec9c9f340e90)
#Release SHA-1s
#Tue Jul 24 21:30:19 EDT 2018
commons-rng-1.1-bin-tar.gz.asc=953fb98e1e43617d5bd11d483cbddd1b5707656b
commons-rng-1.1-src-zip=553bb218e8b06ad30ddff68abd2126a8b0809a3d
commons-rng-1.1-bin-zip=017ebcd97e063698824f4730f9dea42f1a67a6c6
commons-rng-1.1-pom.asc=a0fa10159b7aa7ad2952b3f880c3733269eaf22d
commons-rng-1.1-bin-tar.gz=a80c84173f3b0790c233131329aa057f0932df96
commons-rng-1.1-src-tar.gz=eb08c2dcbbb8e6a4a57ef2e40f7ee7c0853e73a0
commons-rng-1.1-bin-zip.asc=a01d0de808088502938c5572c90f15cf3a3a7e35
commons-rng-1.1-src-tar.gz.asc=3f3c0f35cba3d2cbf1fd7ac91e3d430332ae14cb
commons-rng-1.1-src-zip.asc=af5ee528ca5e18ab369712894692719c69ff1517
#Release SHA-256s
#Tue Jul 24 21:30:19 EDT 2018
commons-rng-1.1-bin-tar.gz.asc=c10242b030a26d5eb3626768111fea0fdecc1b40668d5ea67610dc12b4c7bff9
commons-rng-1.1-src-zip=61b438e71c0eb95f6eaae8b23bb36853244a133ae7f193d720093a1a69f7a3c2
commons-rng-1.1-bin-zip=804d17bc82d0d30d390f27e55233a5b81cb84fb8c4269412b00494a9cced4804
commons-rng-1.1-pom.asc=c6fca52c76737230edb57961fef5b0714904dabe96db009fc60ef6306a5899d9
commons-rng-1.1-bin-tar.gz=63ac366f08378acf381231f40a752c00b5a809631ca45b2e3f0a0ac0d848b453
commons-rng-1.1-src-tar.gz=042ae7479aa4966dd6323a23373005bd15eb53b09a2317455897f10af8cbcd90
commons-rng-1.1-bin-zip.asc=3143eebf36ae07b176f1e13dd6fb5461fc22f93a9b56118510e53e04f713aa39
commons-rng-1.1-src-tar.gz.asc=08998df28b91ef636c8afbbc475ec348be951bcbc43e483da6c45132ddacda9f
commons-rng-1.1-src-zip.asc=ca9d6b2157996bee6fbff6c9c59cdd1a6e4767a4dc2a5f6a3044ed9e01285f99
(no need for .asc hashes!)
I have tested this with ***'mvn clean install site'*** using:
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T14:33:14-04:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 9.0.4, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.6", arch: "x86_64", family:
"mac"
Details of changes since 1.0 are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/changes-report.html
Site:
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site
(note some *relative* links are broken and the 1.1 directories
are not
yet created - these will be OK once the site is deployed.)
CLIRR Report (compared to 1.0):
(See the submodule reports)
RAT Report: (Note, the two RELEASE-NOTES-*.txt files should have
been
excluded via pom, but weren't)
https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC3/site/rat-report.html
KEYS:
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Rob Tompkins,
Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
