I don’t think that my validations can overcome @Gary’s points. -Rob
> On Jul 30, 2018, at 10:21 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > > On Mon, Jul 30, 2018 at 1:29 PM Oliver Heger <oliver.he...@oliver-heger.de > <mailto:oliver.he...@oliver-heger.de>> > wrote: > >> Hi Gary, >> >> Am 30.07.2018 um 16:25 schrieb Gary Gregory: >>> -1 >>> >>> :-( RAT check fails: >>> - Unzip src zip & run 'mvn apache-rat:check' >>> >>> I know it might be trivial but this kind of check must pass IMO to give >> us >>> and users confidence that we are on solid ground WRT licenses. >> >> this is very strange. When building the site the RAT report is clean >> (also in the referenced site). >> > > This is because the RAT check is _only_ configured in the POM's reporting > section. I added the RAT check to the build section in trunk so that 'mvn > apache-rat:check' passes. > > The files affected are not new and are contained in the code-base since >> multiple releases. They actually do not contain license headers (AFAIK >> comments are not even supported by JSON). Therefore, they have been >> excluded from the RAT report (lines 801-802 in pom.xml). Obviously, this >> is not effective when invoking the plugin directly. Any idea how to fix >> this? >> >> As the site build is not affected, and the solution will probably be >> adding another exclude somewhere, do you consider this blocking for the >> release? >> > > I would like to see another RC to pick up the change to trunk I just made > and a couple of items below. Overall, the rest of my local build is fine > but this should be addressed: > > In changes.xml and changes-report.html, the 2.3 release date says "In SVN", > it should be the date of the RC. > > Another hiccup are these easy fixes from Checkstyle: > > [INFO] --- maven-checkstyle-plugin:2.15:check (default) @ > commons-configuration2 --- > [INFO] There are 7 errors reported by Checkstyle 6.1.1 with > C:\vcs\svn\apache\commons\trunks-proper\configuration/conf/checkstyle.xml > ruleset. > [ERROR] > src\main\java\org\apache\commons\configuration2\AbstractYAMLBasedConfiguration.java[0] > (misc) NewlineAtEndOfFile: File does not end with a newline. > [ERROR] > src\main\java\org\apache\commons\configuration2\builder\fluent\INIBuilderParameters.java[0] > (misc) NewlineAtEndOfFile: File does not end with a newline. > [ERROR] > src\main\java\org\apache\commons\configuration2\builder\INIBuilderParametersImpl.java[0] > (misc) NewlineAtEndOfFile: File does not end with a newline. > [ERROR] > src\main\java\org\apache\commons\configuration2\builder\INIBuilderProperties.java[0] > (misc) NewlineAtEndOfFile: File does not end with a newline. > [ERROR] > src\main\java\org\apache\commons\configuration2\JSONConfiguration.java[0] > (misc) NewlineAtEndOfFile: File does not end with a newline. > [ERROR] > src\main\java\org\apache\commons\configuration2\XMLListReference.java[0] > (misc) NewlineAtEndOfFile: File does not end with a newline. > [ERROR] > src\main\java\org\apache\commons\configuration2\YAMLConfiguration.java[0] > (misc) NewlineAtEndOfFile: File does not end with a newline. > > There are lots of Javadocs warnings building with Java 8 but I am not > worried about this for this release. > > Gary > >> >> Oliver >> >>> >>> Gary >>> >>> ***************************************************** >>> >>> Files with unapproved licenses: >>> >>> src/test/resources/test.json >>> src/test/resources/test.yaml >>> >>> On Sat, Jul 28, 2018 at 2:38 PM Oliver Heger < >> oliver.he...@oliver-heger.de> >>> wrote: >>> >>>> We have fixed quite a few bugs and added some significant enhancements >>>> since Apache Commons Configuration 2.2 was released, so I would like to >>>> release Apache Commons Configuration 2.3. >>>> >>>> Apache Commons Configuration 2.3 RC1 is available for review here: >>>> >> https://dist.apache.org/repos/dist/dev/commons/configuration/2.3-RC1 >>>> (svn revision 28408) >>>> >>>> The Subversion tag for this RC is here: >>>> >>>> >>>> >> http://svn.apache.org/repos/asf/commons/proper/configuration/tags/CONFIGURATION_2_3_RC1/ >>>> (svn revision 1836945) >>>> N.B. the SVN revision is required because SVN tags are not >> immutable. >>>> >>>> Maven artifacts are here: >>>> >>>> >>>> >> https://repository.apache.org/content/repositories/orgapachecommons-1359/org/apache/commons/commons-configuration2/2.3/ >>>> >>>> These are the Maven artifacts and their hashes in Nexus: >>>> >>>> #Release SHA-1s >>>> #Sat Jul 28 21:39:45 CEST 2018 >>>> >>>> >> commons-configuration2-2.3-javadoc-javadoc=39271069902b856f39aaab2feb67fe5c747918e2 >>>> >>>> >> commons-configuration2-2.3-test-sources-java-source=a24a39532a443675d66f660ca6f36240bdde5f08 >>>> >> commons-configuration2-2.3-jar.asc=830e60da68e4e55d0d9f90fbc89d7b43d91234b1 >>>> >>>> >> commons-configuration2-2.3-bin-tar.gz.asc=3a0133fa3ac1461c0ccc7247090024951946b9fd >>>> >>>> >> commons-configuration2-2.3-bin-zip.asc=fef5041fd94e19bacb85f38f19718650b157971f >>>> >>>> >> commons-configuration2-2.3-sources-java-source=3f1eb983c8e8fb14fa4beef7b007886b75fc17e7 >>>> >>>> >> commons-configuration2-2.3-test-sources-jar.asc=29678f2e18b7dadd00f8be550093e96896fc15ee >>>> >>>> >> commons-configuration2-2.3-sources-jar.asc=99951b89187ed154482bcb61879c83b868624e25 >>>> >>>> >> commons-configuration2-2.3-src-tar.gz.asc=a66c4810bbc31edcc975a553999c3a6a40d96089 >>>> >> commons-configuration2-2.3-src-zip=a8a1dd83c98bed2933736e3b37b9e1028a649ec7 >>>> >>>> >> commons-configuration2-2.3-tests-test-jar=63dc740e7bd7495cedd34224525d90c1bcdbd56e >>>> >> commons-configuration2-2.3-bin-zip=086b2195b31e871b5102d9a29882bd7d4c44aa0c >>>> >>>> >> commons-configuration2-2.3-src-zip.asc=416cffc6aec9173f2fc30665ee78b46ae8c23ee3 >>>> >>>> >> commons-configuration2-2.3-tests-jar.asc=5a80150876658784b2711521c6496270f6c76b9d >>>> >>>> >> commons-configuration2-2.3-src-tar.gz=7f7f4219c1783c66236c144845150d7d1fcfa80a >>>> >>>> >> commons-configuration2-2.3-javadoc-jar.asc=be4a78a18a0e347dd7ada170ffa09a2111fbd4c7 >>>> >> commons-configuration2-2.3-pom.asc=f6a8007fe0f7d74fdcee98e9e465e5ebc3c32e51 >>>> >>>> >> commons-configuration2-2.3-bin-tar.gz=c51eab5074927576b7397c32dd4c78ca969b26ea >>>> >>>> #Release SHA-256s >>>> #Sat Jul 28 21:39:45 CEST 2018 >>>> >>>> >> commons-configuration2-2.3-javadoc-javadoc=3ad123d2a3f09f8e59ce157bd5e3aad7664f3524a3a8be01905f6b769bdc5b09 >>>> >>>> >> commons-configuration2-2.3-test-sources-java-source=695d9f975bb02a3c2317560cff4980a0ae22c3c7c83bb2183066273a7b452c18 >>>> >>>> >> commons-configuration2-2.3-jar.asc=b2f8d71b0005611ff90725de351cb59d74b885ed4be2c835c10fd4b9964fb6b4 >>>> >>>> >> commons-configuration2-2.3-bin-tar.gz.asc=9dc01e19c967a0f633a9ca072843aabfa14ae0bdb13581ab627c8861ae94a865 >>>> >>>> >> commons-configuration2-2.3-bin-zip.asc=6e94b7274866b3494eeda81cb2b602fb6e4c94f918145fccbeb6fdfc39fc4dac >>>> >>>> >> commons-configuration2-2.3-sources-java-source=73f20c446fd082655b130e515ab06f1cc1eb4ba3a3e9db463b55a4fe82bc941f >>>> >>>> >> commons-configuration2-2.3-test-sources-jar.asc=007d3c1712a8a5ce7da56fd387422dab180b3ec49437b8ae0835e61a638d2965 >>>> >>>> >> commons-configuration2-2.3-sources-jar.asc=8015460d832424b5127bb798a88c814afbe48a471c8eeee6abe67099c2d06ea5 >>>> >>>> >> commons-configuration2-2.3-src-tar.gz.asc=51ab6a928377810be85df3f14ed0ac5d50f1ab7f9ee6d71a8871a526f94645ab >>>> >>>> >> commons-configuration2-2.3-src-zip=232608f64a1eee7ff3f00fbb65005fce00fa7dc20065d1227585adea93c2e734 >>>> >>>> >> commons-configuration2-2.3-tests-test-jar=07954d825f11fd9b006a2a6c4fa8e3558fc919208e52e7be01e96a6e60a5f51e >>>> >>>> >> commons-configuration2-2.3-bin-zip=f2d5e53e1ed86acac8cca3de6986c79bbb3c227f174804c83cb43ad3f365d54e >>>> >>>> >> commons-configuration2-2.3-src-zip.asc=889482ee837b06ffb7d3bc3d4a789691f2e5250816b6a526acf649915d04a1b3 >>>> >>>> >> commons-configuration2-2.3-tests-jar.asc=ca25085acf2234f590bcedcdd4dd06576e0b476a60fba28d9a9af9771301c496 >>>> >>>> >> commons-configuration2-2.3-src-tar.gz=f963ce5cf9eaaec22353d8a9d72a6d491f85442f6280fe27b3cda9d8ab083af5 >>>> >>>> >> commons-configuration2-2.3-javadoc-jar.asc=f6a19adb4bb5c087394d5071e4e715c81b56c9d744e6e3473fa87f443d0ec650 >>>> >>>> >> commons-configuration2-2.3-pom.asc=1321aaab060b97bedc1d1d027d77ac30329d69cf53a7dd949594ef5a7e22d904 >>>> >>>> >> commons-configuration2-2.3-bin-tar.gz=bd74b0d47721478d55fceab0881a4788626f76863b45792ec8816f19d0e94db0 >>>> >>>> >>>> (no need for .asc hashes!) >>>> >>>> I have tested this with ***'mvn clean install site'*** using: >>>> >>>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >>>> 2018-06-17T20:33:14+02:00) >>>> Maven home: C:\data\dev\tools\apache-maven-3.5.4 >>>> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program >>>> Files\Java\jdk1.8.0_172\jre >>>> Default locale: de_DE, platform encoding: Cp1252 >>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >>>> >>>> Details of changes since 2.2 are in the release notes: >>>> >>>> >>>> >> https://dist.apache.org/repos/dist/dev/commons/configuration/2.3-RC1/RELEASE-NOTES.txt >>>> >>>> >>>> >> https://dist.apache.org/repos/dist/dev/commons/configuration/2.3-RC1/site/changes-report.html >>>> >>>> Site: >>>> >>>> >>>> >> https://dist.apache.org/repos/dist/dev/commons/configuration/2.3-RC1/site/index.html >>>> (note some *relative* links are broken and the 2.3 directories are >>>> not yet created - these will be OK once the site is deployed.) >>>> >>>> CLIRR Report (compared to version 2.2): >>>> >>>> >>>> >> https://dist.apache.org/repos/dist/dev/commons/configuration/2.3-RC1/site/clirr-report.html >>>> >>>> RAT Report: >>>> >>>> >>>> >> https://dist.apache.org/repos/dist/dev/commons/configuration/2.3-RC1/site/rat-report.html >>>> >>>> KEYS: >>>> https://www.apache.org/dist/commons/KEYS >>>> >>>> Please review the release candidate and vote. >>>> This vote will close no sooner that 72 hours from now. >>>> >>>> [ ] +1 Release these artifacts >>>> [ ] +0 OK, but... >>>> [ ] -0 OK, but really should fix... >>>> [ ] -1 I oppose this release because... >>>> >>>> Thank you, >>>> >>>> Oliver >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org
