Not a blocker IMO. We can release 3.8 and work on this for 3.9. Gary
On Tue, Aug 14, 2018, 05:13 Bruno P. Kinoshita <brunodepau...@yahoo.com.br.invalid> wrote: > Hi Rob! > > Thanks for RM'ing lang 3.8! > > > I think it would be good to fix for LANG-1339, as we get closer to > supporting Java 9 someday... > > I believe the summary from the last comments in the discussion in the > mailing list is that looks like Observable/Observable won't be removed from > the JDK, but marked as deprecated and not maintained. We can't just copy > the JVM code into our codebase (even if internal). And java.util.concurrent > provides the building blocks for the DIY observer/observable pattern. > > Alas, it could take a while until we had a proper replacement for the > observable/observer. So maybe we could discuss merging the pull request, > and adding the deprecated note for existing circuit breakers? The cons of > this solution, is that the new circuit breakers would rely on code being > marked as deprecated in JDK 9 I think :/ (unless someday we got a proper > replacement in something like Java 12, 13, ...) > > > But I wouldn't want to block the release if it appears it'd take too long > to fix it. WDYT? > > Cheers > Bruno > > > https://issues.apache.org/jira/browse/LANG-1339 > > https://github.com/apache/commons-lang/pull/275 > ________________________________ > From: Rob Tompkins <chtom...@gmail.com> > To: Commons Developers List <dev@commons.apache.org> > Sent: Tuesday, 14 August 2018 12:36 PM > Subject: [lang] preparing for 3.8 > > > > Hello all, > > > I’m planning on working on 3.8 for lang later this week. Does anyone want > to get any specific jira's in? I think that I can quickly button up > LANG-1408 (selfishly want to get that in). > > > Cheers, > > -Rob > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >