On Thu, Aug 16, 2018 at 4:19 PM Rob Tompkins <chtom...@gmail.com> wrote:

>
>
> > On Aug 16, 2018, at 5:07 PM, Gary Gregory <garydgreg...@gmail.com>
> wrote:
> >
> > On Thu, Aug 16, 2018 at 2:33 PM Oliver Heger <
> oliver.he...@oliver-heger.de>
> > wrote:
> >
> >> Build works fine with Java 1.7 and 1.8 on Windows 10. Artifacts and site
> >> look good.
> >>
> >> One minor nit: I was a bit confused by the sentence in the release notes
> >> "Lang 3.0 and onwards now targets Java 5.0...". This sounds as if the
> >> minimum Java requirement was 5.0. A bit later it is correctly stated
> >> that Java 7 is required.
> >>
> >
> > I agree, the structure of the text makes this confusing. The Java 7 req
> > should be front and center and we should NOT talk about Java 5. Not a
> > blocker IMO and can be updated after the VOTE.
> >
>
> I thought about this while going through the release prep and thought it
> odd too but left it due to the last set of RELEASE-NOTES. I can change it
> upon promotion.
>

+1

Gary


>
> -Rob
>
>
> > Gary
> >
> >
> >> +1
> >>
> >> Oliver
> >>
> >>> Am 16.08.2018 um 03:54 schrieb Rob Tompkins:
> >>> We have fixed quite a few bugs and added some significant enhancements
> >> since Apache Commons Lang 3.7 was released, so I would like to release
> >> Apache Commons Lang 3.8.
> >>>
> >>> Apache Commons Lang 3.8 RC1 is available for review here:
> >>>    https://dist.apache.org/repos/dist/dev/commons/lang/3.8-RC1
> >> (revision 28761)
> >>>
> >>> The Git tag LANG_3_8_RC1 commit for this RC is
> >> 9801e2fb9fcbf7ddd19221e9342608940d778f8c which you can browse here:
> >>>
> >>
> https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=tag;h=refs/tags/LANG_3_8_RC1
> >>>
> >>> Maven artifacts are here:
> >>>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1368/org/apache/commons/commons-lang3/3.8/
> >>>
> >>> These are the Maven artifacts and their hashes in Nexus:
> >>>
> >>> #Nexus SHA-1s
> >>> commons-lang3-3.8-sources.jar
> >>> (SHA1: 546b07aafba4fe00a514627bfb854ffc0c23406a)
> >>> commons-lang3-3.8-tests.jar
> >>> (SHA1: c57207c4a515d2ebf764324e042c9c950b15f1cd)
> >>> commons-lang3-3.8-test-sources.jar
> >>> (SHA1: 3916bf439aa10c0fa7d4b81cb2b6b880a1ad78e8)
> >>> commons-lang3-3.8.pom
> >>> (SHA1: e536d0d78a5e3d3f0b297d221c3304b134483d7d)
> >>> commons-lang3-3.8-javadoc.jar
> >>> (SHA1: 4da9bb80271149d6199aecb592e018f72e4650fe)
> >>> commons-lang3-3.8.jar
> >>> (SHA1: 222fc4cf714a63f27cbdafdbd863efd0d30c8a1e)
> >>>
> >>> #Release SHA-1s
> >>> #Wed Aug 15 21:37:09 EDT 2018
> >>>
> >>
> commons-lang3-3.8-test-sources-java-source=3916bf439aa10c0fa7d4b81cb2b6b880a1ad78e8
> >>>
> commons-lang3-3.8-tests-test-jar=c57207c4a515d2ebf764324e042c9c950b15f1cd
> >>> commons-lang3-3.8-src-zip=284e181b3fe3b32f1538b984bdd08189a1700dca
> >>> commons-lang3-3.8-src-tar.gz=bb2e1631483cad0287b9751a5d6cfd2241c1abc2
> >>> commons-lang3-3.8-bin-zip=15ca9898683ec3e21af1f0806366099aa2628644
> >>> commons-lang3-3.8-bin-tar.gz=cdf6ecbc93355be416875aba51010b8bc51d9352
> >>>
> >>
> commons-lang3-3.8-javadoc-javadoc=4da9bb80271149d6199aecb592e018f72e4650fe
> >>>
> >>
> commons-lang3-3.8-sources-java-source=546b07aafba4fe00a514627bfb854ffc0c23406a
> >>>
> >>> #Release SHA-256s
> >>> #Wed Aug 15 21:37:09 EDT 2018
> >>>
> >>
> commons-lang3-3.8-test-sources-java-source=1d5520746e1a49d259eed468bb90e4b2469bc5a358dedcd3932ff8078ecb189d
> >>>
> >>
> commons-lang3-3.8-tests-test-jar=30490d1099ec915f276489383e93ea23bd906400a8598487496abe46b368f5de
> >>>
> >>
> commons-lang3-3.8-src-zip=38dc4b78ea9e6ee5b8348357be29eaa938bfb550e7daea83f3b8eac3e642be4f
> >>>
> >>
> commons-lang3-3.8-src-tar.gz=600dcd0bfe1b5afc52be0c66962611f3e91d3b8042deb3ae276ca6fe2b717378
> >>>
> >>
> commons-lang3-3.8-bin-zip=c008a7a278cedf8db065b3664435cb9dc8aaeed52aeb60581563f460d7dd79ae
> >>>
> >>
> commons-lang3-3.8-bin-tar.gz=70c659a90805cec1f546ebe812e571d00f8ca5b3fcd968c7149df6f6b740193e
> >>>
> >>
> commons-lang3-3.8-javadoc-javadoc=95dea8706a65eae013ad58aba3731568092c6624e8b17ead6726bae91dbdf558
> >>>
> >>
> commons-lang3-3.8-sources-java-source=4be2bb042cee507fe8f3d93b15cf4f5d7bc6c69c41dc48df303c7ebe5fe8a8eb
> >>>
> >>>
> >>>
> >>> I have tested this with 'mvn clean install site' using:
> >>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> >> 2018-06-17T14:33:14-04:00)
> >>> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> >>> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> >> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> >>> Default locale: en_US, platform encoding: UTF-8
> >>> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
> >>>
> >>> Details of changes since 3.7 are in the release notes:
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/lang/3.8-RC1/RELEASE-NOTES.txt
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/lang/3.8-RC1/site/changes-report.html
> >>>
> >>> Site:
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/lang/3.8-RC1/site/index.html
> >>>    (note some *relative* links are broken and the 3.8 directories are
> >> not yet created - these will be OK once the site is deployed.)
> >>>
> >>> CLIRR Report (compared to 3.7):
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/lang/3.8-RC1/site/clirr-report.html
> >>>
> >>> JApiCmp Report (compared to 3.7):
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/lang/3.8-RC1/site/japicmp.html
> >>>
> >>> RAT Report:
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/lang/3.8-RC1/site/rat-report.html
> >>>
> >>> KEYS:
> >>>  https://www.apache.org/dist/commons/KEYS
> >>>
> >>> Please review the release candidate and vote.
> >>> This vote will close no sooner that 72 hours from now.
> >>>
> >>>  [ ] +1 Release these artifacts
> >>>  [ ] +0 OK, but...
> >>>  [ ] -0 OK, but really should fix...
> >>>  [ ] -1 I oppose this release because...
> >>>
> >>> Thank you,
> >>>
> >>> Rob Tompkins,
> >>> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314)
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >>> For additional commands, e-mail: dev-h...@commons.apache.org
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >> For additional commands, e-mail: dev-h...@commons.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Reply via email to