> On Sep 19, 2018, at 1:58 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > > +1 but please fix the following before publishing the site: > > The POM says Java 8 but the site says: > > - The current stable release 3.8.1 > > <https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1/site/javadocs/api-3.8.1/index.html> > [Java > 7 and up]" > > The page > https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1/site/release-history.html > should also say Java 8 for 3.8 AND 3.8.1. > > This is confusing to me in the release notes: > > Lang 3.0 and onwards now targets Java 5.0, making use of features that > arrived with Java 5.0 such as generics, > variable arguments, autoboxing, concurrency and formatted output.
Agreed here. That’s this in master: https://github.com/apache/commons-lang/blob/master/src/changes/release-notes.vm#L46-L47 <https://github.com/apache/commons-lang/blob/master/src/changes/release-notes.vm#L46-L47> Thoughts on what we should put in the published release-notes?? I put this in the 3.8 release notes: "Lang 3.0 and onwards now targets Java 7.0, making use of features that arrived with Java 7.0.” I’ll add that to the release-notes.txt in the site and change the notes out in the dist area. > > IMO we should say: > > Lang 3.8 and onward now targets Java 8. > I think you were looking at the pom.xml in master, and not on the tags: https://github.com/apache/commons-lang/blob/LANG_3_8/pom.xml#L560-L577 <https://github.com/apache/commons-lang/blob/LANG_3_8/pom.xml#L560-L577> https://github.com/apache/commons-lang/blob/LANG_3_8_1/pom.xml#L560-L578 <https://github.com/apache/commons-lang/blob/LANG_3_8_1/pom.xml#L560-L578> That seem reasonable?? -Rob > -- > ASC, SHA1, SHA256 OK. > Builds OK with 'mvn clean package site' and > > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; > 2018-06-17T12:33:14-06:00) > Maven home: C:\Java\apache-maven-3.5.4\bin\.. > Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_181\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Reports LGTM. > > Gary > Gary > > > On Wed, Sep 19, 2018 at 10:04 AM Rob Tompkins <chtom...@apache.org> wrote: > >> We have fixed LANG-1419 "Restore BundleSymbolicName / regression in >> version 3.8.0", so I would like to release Apache Commons Lang 3.8.1. >> >> Apache Commons Lang 3.8.1 RC1 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1 (svn >> revision 29514) >> >> >> The Git tag LANG_3_8_1_RC1 commit for this RC is >> eb5b11a25c9e61f9b25a540682816ebb103b735c which you can browse here: >> >> https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=tag;h=refs/tags/LANG_3_8_1_RC1 >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1381/org/apache/commons/commons-lang3/3.8.1/ >> >> These are the Maven artifacts and their hashes in Nexus: >> >> #Nexus SHA-1s >> commons-lang3-3.8.1-tests.jar >> (SHA1: 05f58ffeafc75593ce46d73062165dc5d6cca765) >> commons-lang3-3.8.1.jar >> (SHA1: 6505a72a097d9270f7a9e7bf42c4238283247755) >> commons-lang3-3.8.1-sources.jar >> (SHA1: e9748d7783594da3735ad9724390a10e7cebc01d) >> commons-lang3-3.8.1-test-sources.jar >> (SHA1: 1308a9d4723d5cd2a4f1c3e0cec0054a48ccf2d2) >> commons-lang3-3.8.1.pom >> (SHA1: 59092f9d06947b986318dfbe297312e08379b0ae) >> commons-lang3-3.8.1-javadoc.jar >> (SHA1: e7e19f37a0e712862967e39558b888fb59ee5b6a) >> >> #Release SHA-1s >> #Wed Sep 19 11:24:27 EDT 2018 >> >> commons-lang3-3.8.1-javadoc-javadoc=e7e19f37a0e712862967e39558b888fb59ee5b6a >> commons-lang3-3.8.1-bin-zip=77bcf40ff7df6da4012411f121000b6576b96ca7 >> >> commons-lang3-3.8.1-sources-java-source=e9748d7783594da3735ad9724390a10e7cebc01d >> >> commons-lang3-3.8.1-test-sources-java-source=1308a9d4723d5cd2a4f1c3e0cec0054a48ccf2d2 >> commons-lang3-3.8.1-tests-test-jar=05f58ffeafc75593ce46d73062165dc5d6cca765 >> commons-lang3-3.8.1-src-tar.gz=cc04982add9f5eb6c3759fa43a5878d9f11caeb7 >> commons-lang3-3.8.1-src-zip=b94464fd51e8f322d9216327dfb82e602101fb0a >> commons-lang3-3.8.1-bin-tar.gz=62c84f0b3b99803d24f2e242dd05087f1ab0fed0 >> >> #Release SHA-256s >> #Wed Sep 19 11:24:27 EDT 2018 >> >> commons-lang3-3.8.1-javadoc-javadoc=9581660137ce6b90a2f2b56775bddbac6fe2924bc73bcec1869cfb1af2908928 >> >> commons-lang3-3.8.1-bin-zip=5bb02b0e30221c8545cdfadcf140df2fc1bcd8591da25ce93a930e78e69271e0 >> >> commons-lang3-3.8.1-sources-java-source=a6589a5acef187a9c032b2afe22384acc3ae0bf15bb91ff67db8731ebb4323ca >> >> commons-lang3-3.8.1-test-sources-java-source=a2f26272ccc1817fc590f8b2544403bf4235f33c8de9dbdba89182eb19864c93 >> >> commons-lang3-3.8.1-tests-test-jar=1594433d480e6e9ba7f2e6d2f60f18b855db42db1a35dbf0b4bc72e388b3c86e >> >> commons-lang3-3.8.1-src-tar.gz=9682e67375b6f03700e5bbaa2acceac60bc2f9049e11cafae3ce411ccaf633fb >> >> commons-lang3-3.8.1-src-zip=3109bf11a85342ddd31aa17e720bf5ca2f88f666e2cd073158d3a2f72b97b89c >> >> commons-lang3-3.8.1-bin-tar.gz=56fab92fb3e8a84385cac0d579bb85aa0bdb9f26f975a74a73d63edc121e7ff5 >> >> >> >> I have tested this with mvn clean install site' using: >> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> 2018-06-17T14:33:14-04:00) >> Maven home: /usr/local/Cellar/maven/3.5.4/libexec >> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: >> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre >> Default locale: en_US, platform encoding: UTF-8 >> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac" >> >> Details of changes since 3.8 are in the release notes: >> >> https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1/RELEASE-NOTES.txt >> >> https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1/site/changes-report.html >> >> Site: >> https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1/site >> (note some *relative* links are broken and the 3.8.1 directories are >> not yet created - these will be OK once the site is deployed.) >> >> CLIRR Report (compared to 3.8): >> >> https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1/site/clirr-report.html >> >> JApiCmp Report (compared to 3.8): >> >> https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1/site/japicmp.html >> >> RAT Report: >> >> https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1/site/rat-report.html >> >> KEYS: >> https://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner that 72 hours from now. >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thank you, >> >> Rob Tompkins, >> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >>
