Github user grimreaper commented on the issue:
https://github.com/apache/commons-pool/pull/17
The new test doesn't fail for me if I reverse the original change:
```
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.commons.pool2.impl.TestGenericObjectPool
[INFO] Tests run: 84, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
106.528 s - in org.apache.commons.pool2.impl.TestGenericObjectPool
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 84, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:57 min
[INFO] Finished at: 2018-11-20T22:58:11-08:00
[INFO]
------------------------------------------------------------------------
mvn test -Dtest=TestGenericObjectPool 34.10s user 7.66s system 34% cpu
1:59.76 total; max RSS 305800Ki
[45682 22:58:11.583 eax@FlyingEagle ...ache/commons/commons-pool]â´git
diff (git:commons-pool)-[masterâ]
diff --git i/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
w/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
index b92b87a9..2fc9ffd8 100644
--- i/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
+++ w/src/main/java/org/apache/commons/pool2/impl/EvictionTimer.java
@@ -94,7 +94,7 @@ static synchronized void schedule(
static synchronized void cancel(
final BaseGenericObjectPool<?>.Evictor task, final long
timeout, final TimeUnit unit) {
task.cancel();
- if (executor != null && executor.getQueue().size() == 0) {
+ if (executor.getQueue().size() == 0) {
executor.shutdown();
try {
executor.awaitTermination(timeout, unit);
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
