I think we still need to address what happens if null gets returned in create(). This was something I missed. Not sure if it got addressed in the meantime?
LieGrue, strub > Am 26.11.2018 um 14:26 schrieb Rob Tompkins <chtom...@gmail.com>: > > > >> On Nov 26, 2018, at 8:16 AM, Mark Struberg <strub...@yahoo.de.INVALID> wrote: >> >> Hi Gary! >> >> I've added multi-line comments in the middle of code blocks I touched. >> e.g. >> https://github.com/apache/commons-pool/blob/016a1f67263fe1cde1d910dc7002d972811951c5/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java#L919 >> >> I also tried to write extensive commit comments. > > Sounds good. I’ll try to get to starting the release today. > > -Rob > >> >> LieGrue, >> strub >> >>> Am 23.11.2018 um 16:18 schrieb Gary Gregory <garydgreg...@gmail.com>: >>> >>> On Fri, Nov 23, 2018 at 2:57 AM Mark Struberg <strub...@yahoo.de.invalid> >>> wrote: >>> >>>> should read: This change (putting a new item back to the idle pool) was >>>> needed to prevent a dead-lock.... >>>> >>>> *grabbing a fresh coffee* >>>> >>>>> Am 23.11.2018 um 10:49 schrieb Mark Struberg <strub...@yahoo.de>: >>>>> >>>>> This change (putting a new item back to the idle pool was needed to >>>> prevent a dead-pool >>>> >>> >>> Hi Mark, >>> >>> Would you mind adding some comments to the code to help future maintainers? >>> >>> Gary (currently sipping coffee) >>> >>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
