vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810868
##########
File path: src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java
##########
@@ -18,13 +18,16 @@
package org.apache.commons.crypto;
/**
- * JNI interface of {@see CryptoRandom} implementation for OpenSSL.
+ * JNI interface of @see CryptoRandom implementation for OpenSSL.
* The native method in this class is defined in
* OpenSslCryptoRandomNative.h (generated at build time by javah)
* and implemented in the file
* src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
*/
-class OpenSslInfoNative {
+public class OpenSslInfoNative {
Review comment:
Why public? Users of the library should not need to care about this.
It seems you're just calling this from Crypto.java so package private should
be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
