> On Jan 26, 2019, at 11:24 AM, Gary Gregory <garydgreg...@gmail.com> wrote:
> 
> On Sat, Jan 26, 2019 at 10:19 AM Gilles Sadowski <gillese...@gmail.com>
> wrote:
> 
>> Le sam. 26 janv. 2019 à 14:01, Gary Gregory <garydgreg...@gmail.com> a
>> écrit :
>>> 
>>> Are we talking about formatting [numbers] specific classes or JRE
>> classes?
>> 
>> They are classes that aim to customize the output from classes in
>> [Numbers],
>> (specifically, the way to display a {{Fraction}} or {{BigFraction}}
>> object).
>> 
> 
> Well, then that code does not belong in [text] since it requires [number]
> classes.

We could use the old [lang] pattern here where the number parsing/formatting 
lives with number as opposed to with the text utilities. If that is an 
insufficient pattern, then we should look at how the JDK organizes this and try 
to mirror them.

-Rob

> 
> Gary
> 
> 
>> The classes provide accessors to the numerator and denominator which can be
>> used by outside code to display the fraction as it wishes.
>> 
>> Side note: Similar formatting classes in Commons Math are more of a
>> nuisance
>> than anything, e.g. displaying small numbers as "0" (in exception
>> messages),
>> because the default is to provide 6 decimal digits, thus discarding
>> all significant
>> information.
>> 
>> Gilles
>> 
>>> 
>>> Gary
>>> 
>>> On Sat, Jan 26, 2019 at 7:14 AM Gilles Sadowski <gillese...@gmail.com>
>>> wrote:
>>> 
>>>> Hi.
>>>> 
>>>> In reference to the current changes in module
>> "commons-numbers-fraction"
>>>> (on the "fraction-dev"), my opinion is that the formatting classes
>> should
>>>> be
>>>> removed.[1]
>>>> At the level of a math component, it's safer to stick to a single,
>>>> locale-independent format.[2]
>>>> 
>>>> Regards,
>>>> Gilles
>>>> 
>>>> [1] Rationale is that pretty-printing is not the purpose of the library
>>>> (better
>>>>     leave that to [Text], or a dedicated module).
>>>> [2] There is a pending issue (NUMBERS-88) that suggests hard-coding the
>>>>    format.
>>>> 
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>> 
>>>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to