I am canceling this VOTE to fix the tests and other nits. Gary
On Sun, Jan 27, 2019 at 10:28 AM Gary Gregory <ggreg...@apache.org> wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons VFS Distribution 2.2 was released, so I would like to > release Apache Commons VFS Distribution 2.3. > > Apache Commons VFS Distribution 2.3 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1 (svn > revision 32156) > > The Subversion tag for this RC is here: > > http://svn.apache.org/repos/asf/commons/proper/vfs/tags/commons-vfs2-project-2.3-rc1/ > (svn revision 1852298) > N.B. the SVN revision is required because SVN tags are not immutable. > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1416 > > These are the Maven artifacts and their hashes in Nexus: > > #Release SHA-512s > #Sun Jan 27 09:38:10 EST 2019 > > commons-vfs2-distribution-2.3-src-zip.asc=8f7d574cc0ffd0ffc22eefe95221b35aebfd16002934b35266c4be1978b7a0599ab68d3af64c20fe280a644f23adec2579d3fdc847edf3f243514788907614d8 > > commons-vfs2-distribution-2.3-pom.asc=59610c8a7df4bbde92276074ae8ac837cc4bb7210f96322391843601e30046b83111df7b3fc8cc28de275d313ad8f9ea4d6377cdefdd6486c106b526a89703b1 > > commons-vfs2-distribution-2.3-bin-zip=baf9f9a80cf8d3948acd970ec174d03757e50b64988f1a9367c88fc15bf0c9e22e1989c6a61c95395e30eef19caaa4281efdc6290d3baf8a1710a346d3b4e9ff > > commons-vfs2-distribution-2.3-bin-tar.gz=b5c71f6b42c8a67a14caf33bafecb0fa159f22cc4bc33cb9d67710ad87a3fb7f5917c6740ece414ab3a6f933085644826c3706e75c4bead017a2812d3a288107 > > commons-vfs2-distribution-2.3-bin-tar.gz.asc=ddc2f7c8b5109cbf5b3c2170bf46c0921a57b38d8e13a162de21f6fc74813d7099c8da313e7640ed7936f7941044ef9a5b04fb7e88279bb9be4c9fcf37633959 > > commons-vfs2-distribution-2.3-src-zip=8226e2e8bfe41e744569c6f5cbb2bfb890b203e9d935822b4d8a77520837c160200d867b4e871bdef7d9e89d032fcc4c3f30f0677ceb29c18f5ed86b1b2469e7 > > commons-vfs2-distribution-2.3-bin-zip.asc=e76131162a6e4632e070b4b6b463f3f10ca54216e1a81b4b04f13f07b5af381eb1f4a10707b64c2fe8305d21fa7213fc2009b7bd7746e5daee55477714bd7830 > > commons-vfs2-distribution-2.3-src-tar.gz=0d68b7b05a5a5a01fac41ef97fbf8d2ab343b1b1a48a3428237078e8a4d06a6f3996f0ed310dbd409f2c29b67c238e3451f01829f2ed5cceeae905ebc88af3c8 > > commons-vfs2-distribution-2.3-src-tar.gz.asc=771ac16522ed22748a342ed3ea6a2981b4082f1d6f773ce032e03d7409d771c2eeb01eb11ab4f61aee8eb2103e3e5d7bf21599a60fea76bb816db4c48308cc24 > > (no need for .asc hashes!) > > I have tested this with 'mvn clean install site' using: > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > 2018-10-24T14:41:47-04:00) > Maven home: C:\Java\apache-maven-3.6.0\bin\.. > Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_202\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > and then 'mvn test' using: > > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > 2018-10-24T14:41:47-04:00) > Maven home: C:\Java\apache-maven-3.6.0\bin\.. > Java version: 11.0.2, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk-11.0.2 > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Which yields some test failures to be dealt with in a later release. > > Tests in error: > > AbstractFtpsProviderTestCase$FtpProviderTestSuite>AbstractTestSuite.run:137->setUp:153->AbstractTestSuite.setUp:166 > » FileSystem > > AbstractFtpsProviderTestCase$FtpProviderTestSuite>AbstractTestSuite.run:137->setUp:153->AbstractTestSuite.setUp:166 > » FileSystem > MultipleConnectionTestCase.testConnectRoot:55->resolveRoot:49 » > FileSystem Cou... > MultipleConnectionTestCase.testUnderlyingConnect:65 » SSL Unsupported or > unrec... > > Details of changes since 2.2 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/site/changes-report.html > > Site: > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/site > (note some *relative* links are broken and the 2.3 directories are not > yet created - these will be OK once the site is deployed.) > > CLIRR Report (compared to 2.2): 'mvn clirr:check' is OK but no report was > generated. > The Clirr check should have failed because Clirr does not know about Java > 8 default methods, specifically the addition of the default method > org.apache.commons.vfs2.provider.ftp.FtpClient.getReplyString(). > That said there is no API breakage in 2.3. > > JApiCmp Report (compared to 2.2) is empty due to some funkiness in > commons-parent. > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/site/japicmp.html > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/vfs/2.3-RC1/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) >