kinow commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report URL: https://github.com/apache/commons-text/pull/102#issuecomment-465915589 >The magic numbers probably could be resolved by adding: I am not sure if Checkstyle issues are a blocker for a release. I don't think so (and they would be fixed in 2.0). I am more concerned that they seem to have stopped the build of progressing. I believe we have Javadocs issues from master, before I merged the pull request. >I think, it would be better to deprecate the whole class instead of the methods. Is there any reason to duplicate the code and not use the class `JaroWinklerSimilarity`? What about: @jmkeil but in this case we would drop the edit distance, and have only the similarity (I believe it would be better to have both, for consistency). What was implemented in the other pull request is similar to the other edit distance & similarity scores we already have (just fixing jaro winkler). And is also similar to what we can use in [other Java libraries](https://github.com/tdebatty/java-string-similarity#jaro-winkler) or with [JS](https://github.com/Yomguithereal/talisman/blob/51756b23cfd7e32c61f11c2f5a31f6396d15812a/src/metrics/distance/jaro.js#L108), [Python](https://github.com/nap/jaro-winkler-distance/blob/835bede1913232a8255c9e18533c430989c55bde/pyjarowinkler/distance.py#L32), etc.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
