Hi,
I have studied EMAIL-186. My impression is, that all commons jar files
should provide a fixed module name, rather than trusting in the choice
of the JDK. Thus, it seems best to handle this in parent. So, here's
my proposal for a change. Please, let me know, what you think of that,
so that I can either fix it, op proceed with committing.
Thanks,
Jochen
$ git diff pom.xml
diff --git a/pom.xml b/pom.xml
index 2612dd6..54a88e4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -570,6 +570,7 @@
<Implementation-Build>${implementation.build}</Implementation-Build>
<X-Compile-Source-JDK>${maven.compiler.source}</X-Compile-Source-JDK>
<X-Compile-Target-JDK>${maven.compiler.target}</X-Compile-Target-JDK>
+
<Automatic-Module-Name>${commons.module.name}</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
@@ -1608,6 +1609,9 @@
<maven.compiler.source>1.3</maven.compiler.source>
<maven.compiler.target>1.3</maven.compiler.target>
+ <!-- Module name for Java 9, and beyond -->
+ <commons.module.name>${project.artifactId}</commons.module.name>
+
<!-- compiler and surefire plugin settings for "java" profiles -->
<commons.compiler.fork>false</commons.compiler.fork>
<commons.compiler.compilerVersion />
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
