On Wed, Apr 10, 2019 at 7:44 PM Rob Tompkins <chtom...@gmail.com> wrote:
> > > > On Apr 10, 2019, at 7:20 PM, Gary Gregory <garydgreg...@gmail.com> > wrote: > > > > Hi All: > > > > In BCEL, we log a warning to the console: > > > > > https://github.com/apache/commons-bcel/blob/master/src/main/java/org/apache/bcel/classfile/Attribute.java#L240 > > > > Which you can't really do anything about since it does not tell you what > > class file it is complaining about. > > > > 1) Should remove the logging? > > Uncertain here. In the general case, I feel like we should either do > nothing or throw an exception. But the logic feels like it warrants some > explanation, so I don’t know > > > or, > > 2) Should we improve the logging? > > This should be our minimal plan, if removing it doesn’t make sense. > > > or, > > 3) Do nothing? > > Because you brought it up, it feels like something should be done? > I see these possible solutions: 1) Remove the logging (simple) 2) Make logging configurable (bleh) 3) Use a logging API (Log4j 2 for example) 4) Throw an exception in the next major version if this is _really_ an incorrect state but that does not seem like it would help anyone. I favor (1). Gary > > > > Gary > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
