On Fri, Jun 14, 2019 at 4:23 PM Mark Thomas <ma...@apache.org> wrote:
> On 14/06/2019 20:43, Mark Thomas wrote: > > On 14/06/2019 20:39, Gary Gregory wrote: > >> On Fri, Jun 14, 2019 at 3:36 PM Mark Thomas <ma...@apache.org> wrote: > >> > >>> On 14/06/2019 20:31, Gary Gregory wrote: > >>>> This one: https://github.com/apache/commons-daemon/pull/11 > >>> > >>> Review for what? Looks pretty uncontroversial to me. > >>> > >> > >> I've not taken the time to setup my new laptop to build the C part of > this > >> project. So instead of asking for a review, I should have asked "Did I > >> break the compile or cause runtime error?" > > > > Ah. Right. Let me fire up my VM and check... > > All good. > > What I did notice while testing is that you didn't reformat all of the > messages. > I took another pass at the file (in the PR now). Gary > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
