I've created a pull request: https://github.com/apache/commons-numbers/pull/55
This pull request exterminates most the code duplication between the two classes. There is still some duplication left, most notably in the method testDigitLimitConstructor(), but I've found out that the Fraction(double, double, int, int) constructor (and the corresponding BigFraction constructor, which seems to have been copy-pasted from Fraction) doesn't work properly anyway, because it doesn't always generate the closest possible approximation within the given bounds. For example, 5/8 = 0.625 is closer to 0.6152 than 3/5 = 0.6, but apparently, the constructor returns 3/5 when 9 is passed as maxDenominator, and since the test asserts this, the test is useless. I saw that there's a class ContinuedFraction, maybe this class can somehow be used within the constructor instead of duplicating broken code between two classes, so I didn't bother extracting the above tests. Also, I created a new branch and renamed the commits to include the number of the JIRA ticket, which means that the revision numbers are now different from those in the branch I previously referenced, but the changes made in the commits are the same, in case anyone is confused. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
