On Mon, Jul 15, 2019 at 7:20 AM Gary Gregory <garydgreg...@gmail.com> wrote:
> I build with -Ddoclint=none > I'm happy to get help fixing Javadocs for the next go around as well :-) Gary > > Gary > > On Sun, Jul 14, 2019, 23:12 Rob Tompkins <chtom...@gmail.com> wrote: > >> I’m getting a bunch of javadoc build failures. Should I be building with >> warn/errors turned off? Should we check that in to the properties? Given >> that last time we released VFS we added the ignore flag to the build I >> would be willing to go with the release. I just want to see what folks >> think. >> >> -Rob >> >> > On Jul 12, 2019, at 10:27 AM, Gary Gregory <ggreg...@apache.org> wrote: >> > >> > We have fixed quite a few bugs and added some significant enhancements >> > since Apache Commons VFS Project 2.3 was released, so I would like to >> > release Apache Commons VFS Project 2.4. >> > >> > Apache Commons VFS Project 2.4 RC1 is available for review here: >> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.4-RC1 (svn >> > revision 34865) >> > >> > The Git tag commons-vfs-2.4-RC1 commit for this RC is >> > 796408d2f8423e22edc750b3f95ec6611b980704 which you can browse here: >> > >> > >> https://gitbox.apache.org/repos/asf?p=commons-vfs.git;a=commit;h=796408d2f8423e22edc750b3f95ec6611b980704 >> > You may checkout this tag using: >> > git clone https://gitbox.apache.org/repos/asf/commons-vfs.git >> --branch >> > commons-vfs-2.4-RC1 commons-vfs-2.4-RC1 >> > >> > Maven artifacts are here: >> > >> > >> https://repository.apache.org/content/repositories/orgapachecommons-1447/org/apache/commons/commons-vfs2-project/2.4/ >> > >> > These are the artifacts and their SHA-512 hashes on >> > https://dist.apache.org/repos/dist/dev/commons/vfs/2.4-RC1: >> > >> > commons-vfs-2.4-bin.tar.gz >> > >> b4bc9277c00ebaf0c8fe6534165b232db0766b9276709994d6b16e826c2531440c50261035fc40dbf48d0da0a90147ca094a3895b62577b7ee1018cab05419f6 >> > commons-vfs-2.4-bin.zip >> > >> 45c25d7d0b9ab30353d377e0fa80b55fc5eb5c228d43505635e17d3d43d3de0fd1521a5af2f9ebe669571fbbe5ff1aa863c4cad528a4b56e6cfa81c2e6112a65 >> > commons-vfs-2.4-src.tar.gz >> > >> ba8011b1779fae7202d22dee24c6ab94b751739e932499a0230c7764b57d8042734aaaa1b17841ac7dff298fb1ee321aa974223362313413e8d5d76d98e4b214 >> > commons-vfs-2.4-src.zip >> > >> 938d16546db0130316cb7b28872253c90dedc5c4b400ee5b50021dd4889bfcae9c09d52d355c2868bbd70c8486496737f14777758841c5f24485f11f41485669 >> > >> > The following artifacts have been staged in Nexus: >> > >> > >> /org/apache/commons/commons-vfs2-distribution/2.4/commons-vfs2-distribution-2.4-javadoc.jar.asc >> > (SHA1: 3be32ff790c0785b20f2b6ff2c1d2eb1b046a3ef) >> > >> /org/apache/commons/commons-vfs2-distribution/2.4/commons-vfs2-distribution-2.4-javadoc.jar >> > (SHA1: 592efe7f1e778fc5d3a2332b052d2be7822d405f) >> > >> /org/apache/commons/commons-vfs2-distribution/2.4/commons-vfs2-distribution-2.4.pom >> > (SHA1: f05651107067d2995e339c9ad49de3af9ad3af5b) >> > >> /org/apache/commons/commons-vfs2-distribution/2.4/commons-vfs2-distribution-2.4.pom.asc >> > (SHA1: c15fb439ae5155979521acac99b08a3b98b66e1a) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4-test-sources.jar >> > (SHA1: 2cae50abccee652cb3637136ff0d28e7fece0795) >> > >> /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4-test-sources.jar.asc >> > (SHA1: 7de44b57140d9a52a66f1645ea427fbdbfefdd11) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4.jar >> > (SHA1: 085e8f1fc37279c89c1504393a4a748159d91046) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4-javadoc.jar.asc >> > (SHA1: 00521b3fa0617777ac8ba6cc739f4fc895f82aec) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4.pom >> > (SHA1: bafc6da7a594ab33222c70cc67788a2fa1b63ffa) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4-javadoc.jar >> > (SHA1: 06b4e4f58e9c5a7e609c74ba1e8a6e311f56f8c4) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4-sources.jar.asc >> > (SHA1: dab139a477b22ebddcdf16bd79c2d3fa18f79832) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4.pom.asc >> > (SHA1: 891a6e8eec524b0ef2a41e83bd2955a16aecc914) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4-sources.jar >> > (SHA1: afa50c0895aa002adb7c0c5614d9885abd70fb2a) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4-tests.jar >> > (SHA1: 3b4f76fb2c9c0b1e5c8c00715e271e6c7514e825) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4.jar.asc >> > (SHA1: 94cc44bc43ba99f3b771ca6f5e9249a5923f344e) >> > /org/apache/commons/commons-vfs2/2.4/commons-vfs2-2.4-tests.jar.asc >> > (SHA1: 0466ac93c8eec703e2ae1b7fb6db76159872e19f) >> > >> /org/apache/commons/commons-vfs2-project/2.4/commons-vfs2-project-2.4.pom.asc >> > (SHA1: 18b9b81a9a1e55495d746c11f90b6c11b35e9bfa) >> > >> /org/apache/commons/commons-vfs2-project/2.4/commons-vfs2-project-2.4.pom >> > (SHA1: 17c963b66f27497a36618c851ccbee8b3006f9ea) >> > >> /org/apache/commons/commons-vfs2-project/2.4/commons-vfs2-project-2.4-site.xml.asc >> > (SHA1: 713c993dc4342b36c1c3c5243369b485e069693f) >> > >> /org/apache/commons/commons-vfs2-project/2.4/commons-vfs2-project-2.4-site.xml >> > (SHA1: baca67a9f6be69b52869c2ec49b7487bdbd6bc9f) >> > >> /org/apache/commons/commons-vfs2-project/2.4/commons-vfs2-project-2.4-javadoc.jar >> > (SHA1: 22a19ca2c9d4ad2f3fb5179c5f058a4216e71d2e) >> > >> /org/apache/commons/commons-vfs2-project/2.4/commons-vfs2-project-2.4-javadoc.jar.asc >> > (SHA1: 032892276f7814b6a51a0e231450450a3d710cab) >> > >> /org/apache/commons/commons-vfs2-examples/2.4/commons-vfs2-examples-2.4.jar >> > (SHA1: 01a8b92efa47e9ff54800bb4626d1907f6134bc1) >> > >> /org/apache/commons/commons-vfs2-examples/2.4/commons-vfs2-examples-2.4-sources.jar >> > (SHA1: b070600f9ed7d51b9bb24dd9a3b68a121e9ab188) >> > >> /org/apache/commons/commons-vfs2-examples/2.4/commons-vfs2-examples-2.4-javadoc.jar.asc >> > (SHA1: e8e3cc9dab30b608debd52f2552a7d413f4cc3c5) >> > >> /org/apache/commons/commons-vfs2-examples/2.4/commons-vfs2-examples-2.4.pom.asc >> > (SHA1: aa71fa4359c4996b8ff904ff07440b612aa1db4d) >> > >> /org/apache/commons/commons-vfs2-examples/2.4/commons-vfs2-examples-2.4.pom >> > (SHA1: 3ee6f6a4feb6ed6daa0fc79c8c004d0ff66274a9) >> > >> /org/apache/commons/commons-vfs2-examples/2.4/commons-vfs2-examples-2.4-javadoc.jar >> > (SHA1: 2156df5bf402d3e3cac9d243ecac31ff1c798cc8) >> > >> /org/apache/commons/commons-vfs2-examples/2.4/commons-vfs2-examples-2.4.jar.asc >> > (SHA1: 36ed9fc1fb3e6038ebf243394f2dec8230048db1) >> > >> /org/apache/commons/commons-vfs2-examples/2.4/commons-vfs2-examples-2.4-sources.jar.asc >> > (SHA1: a3c1811cc3f85ac62705b7808104ed36490b79b5) >> > >> > I tested this with 'mvn -V clean install site' using the following JDKs: >> > >> > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; >> > 2019-04-04T15:00:29-04:00) >> > Maven home: C:\Java\apache-maven-3.6.1\bin\.. >> > Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: C:\Program >> > Files\Java\jdk1.8.0_212\jre >> > Default locale: en_US, platform encoding: Cp1252 >> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >> > >> > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; >> > 2019-04-04T15:00:29-04:00) >> > Maven home: C:\Java\apache-maven-3.6.1\bin\.. >> > Java version: 11.0.3, vendor: Oracle Corporation, runtime: C:\Program >> > Files\Java\jdk-11.0.3 >> > Default locale: en_US, platform encoding: Cp1252 >> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >> > >> > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; >> > 2019-04-04T15:00:29-04:00) >> > Maven home: C:\Java\apache-maven-3.6.1\bin\.. >> > Java version: 12.0.1, vendor: Oracle Corporation, runtime: C:\Program >> > Files\Java\openjdk\jdk-12.0.1 >> > Default locale: en_US, platform encoding: Cp1252 >> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >> > >> > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; >> > 2019-04-04T15:00:29-04:00) >> > Maven home: C:\Java\apache-maven-3.6.1\bin\.. >> > Java version: 13-ea, vendor: Oracle Corporation, runtime: C:\Program >> > Files\Java\openjdk\jdk-13 >> > Default locale: en_US, platform encoding: Cp1252 >> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >> > >> > >> > Details of changes since 2.3 are in the release notes: >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4-RC1/RELEASE-NOTES.txt >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4-RC1/site/changes-report.html >> > >> > Site: >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4-RC1/site/index.html >> > (note some *relative* links are broken and the 2.4 directories are >> not >> > yet created - these will be OK once the site is deployed.) >> > >> > There is no CLIRR Report, see JApiCmp below. >> > >> > JApiCmp Report (compared to 2.3): >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4-RC1/site/commons-vfs2/japicmp.html >> > >> > Note that Clirr reports several issues. >> > These are considered OK for the reasons stated below. >> > These exceptions are also noted in the Release Notes. >> > >> > - Source incompatibility: >> > org.apache.commons.vfs2.FileFilter.accept(FileSelectInfo) now throws >> > checked exception FileSystemException. >> > - Public API note: The overridden methods getURI() and getFriendlyURI() >> in >> > org.apache.commons.vfs2.provider.local.LocalFileName where removed but >> are >> > implemented in a superclass. >> > - Public API note: The overridden method >> > org.apache.commons.vfs2.provider.sftp.SftpFileObject#refresh() was >> removed >> > but is implemented in a superclass. >> > - Public API note: The overridden method >> > org.apache.commons.vfs2.provider.sftp.SftpFileProvider#init() was >> removed >> > but is implemented in a superclass. >> > >> > RAT Report: >> > >> > >> https://dist.apache.org/repos/dist/dev/commons/vfs/2.4-RC1/site/rat-report.html >> > >> > KEYS: >> > https://www.apache.org/dist/commons/KEYS >> > >> > Please review the release candidate and vote. >> > This vote will close no sooner that 72 hours from now. >> > >> > [ ] +1 Release these artifacts >> > [ ] +0 OK, but... >> > [ ] -0 OK, but really should fix... >> > [ ] -1 I oppose this release because... >> > >> > Thank you, >> > >> > Gary Gregory, >> > Release Manager (using key 86fdc7e2a11262cb) >> > >> > For following is intended as a helper and refresher for reviewers. >> > >> > Validating a release candidate >> > ============================== >> > >> > These guidelines are NOT complete. >> > >> > Requirements: Git, Java, Maven. >> > >> > You can validate a release from a release candidate (RC) tag as follows. >> > >> > 1) Clone and checkout the RC tag >> > >> > git clone https://gitbox.apache.org/repos/asf/commons-vfs.git --branch >> > commons-vfs-2.4-RC1 commons-vfs-2.4-RC1 >> > cd commons-vfs-2.4-RC1 >> > >> > 2) Check Apache licenses >> > >> > This step is not required if the site includes a RAT report page which >> you >> > then must check. >> > >> > mvn apache-rat:check >> > >> > 3) Check binary compatibility >> > >> > Older components still use Apache Clirr: >> > >> > Use JApiCmp with the japicmp Maven Profile: >> > >> > This step is not required if the site includes a JApiCmp report page >> which >> > you then must check. >> > >> > mvn install -DskipTests -P japicmp japicmp:cmp >> > >> > 4) Build the package >> > >> > mvn -V clean package >> > >> > You can record the Maven and Java version produced by -V in your VOTE >> reply. >> > To gather OS information from a command line: >> > Windows: ver >> > Linux: uname -a >> > >> > 5) Build the site for a single module project >> > >> > Note: Some plugins require the components to be installed instead of >> > packaged. >> > >> > mvn site >> > Check the site reports in: >> > - Windows: target\site\index.html >> > - Linux: target/site/index.html >> > >> > 6) Build the site for a multi-module project >> > >> > mvn site >> > mvn site:stage >> > Check the site reports in: >> > - Windows: target\site\index.html >> > - Linux: target/site/index.html >> > >> > -the end- >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >>