We all understood each other in a brief email thread, remarkable! :-) Gary
On Wed, Aug 14, 2019 at 9:00 AM Matt Sicker <boa...@gmail.com> wrote: > Yes, I think you understand us. A strategy pattern with default sensible > strategies to choose. > > On Wed, Aug 14, 2019 at 06:08, Stefan Bodewig <bode...@apache.org> wrote: > > > On 2019-08-13, Matt Sicker wrote: > > > > > The enum makes sense. Are there any feasible ways to, say, configure > > > some sort of handler class that can implement logic around unknown > > > fields? > > > > Not really. The only extension point here currently is plugging in your > > own implementations of ZipExtraField via the static > > ExtraFieldUtils.register - which could use some ServiceLoader magic one > > day :-) > > > > IIUC you and Gary are both saying the same thing. The enum values are > > sensible defaults but it would be good to provide a way to do the same > > things with custom code (callbacks or interface implementations). > > > > It should be possible to split ExtraFieldParsingMode into a strategy > > pattern interface implemented by the enum providing default > > implementations. This may also reduce some other implementation quirks > > (I'm not too happy with the current exception handler inside > > mergeExtraFields). > > > > Thanks! > > > > Stefan > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > -- > Matt Sicker <boa...@gmail.com> >
