+1 >From git tag:
- Apache RAT check OK. - Apache CLIRR check OK. - Release notes typo "can not" -> "cannot". - Build with 'mvn clean install site -P jacoco -P japicmp' OK using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_221\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" JApiCmp report on RC vote site https://stefan.samaflost.de/staging/commons-compress-1.19/japicmp.html looks OK but it seems to use 1.19-SNAPSHOT instead of 1.19. The one I generated locally compared 1.19 to itself somehow. - Then 'mvn test' OK using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 11.0.4, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk-11.0.4 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 12.0.2, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk-12.0.2 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 13, vendor: Oracle Corporation, runtime: C:\Program Files\Java\openjdk\jdk-13 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" For 14-EA, it does not look like the version of JaCoCo used works: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 14-ea, vendor: Oracle Corporation, runtime: C:\Program Files\Java\openjdk\jdk-14 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" ... Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 58 at org.jacoco.agent.rt.internal_1f1cc91.asm.ClassReader.<init>(ClassReader.java:184) ... But the build succeeds. Gary On Sat, Aug 24, 2019 at 12:48 PM Stefan Bodewig <bode...@apache.org> wrote: > It's been more than a year since the last release of Commons Compress > and it is about time to get the fixes and enhancements out of the > door. > > Compress 1.19 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/compress/ (svn > revision 35357) > > The tag is here: > > https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=tag;h=b2a7871ae59a71e7558baa2ac28af357d6fbd11f > on commit > > https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=commit;h=516f76ac1fe48be9a5162e53e4d0a99f23774565 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1459/org/apache/commons/commons-compress/1.19/ > > These are the Maven artifacts and their sha256 hashes > > ff2d59fad74e867630fbc7daab14c432654712ac624dbee468d220677b124dd5 > commons-compress-1.19.jar > aff72b1713b4c5227f18182fb927dfaf76c0b9dabdc8ea1c101e0d981490c250 > commons-compress-1.19-javadoc.jar > 9d5a690d1dea6a747e0dd8e74e64447167f395cb8f148010b8241334f58b525b > commons-compress-1.19.pom > 3952fb4e01ea5fc03ae25e0dab2f3d5b4f71a71d3750c7f03dffa6aba8075757 > commons-compress-1.19-sources.jar > a92b92e2b4c7ea4167e50bac4f55a3f03301164d0e52f33d0db357dacf0166f6 > commons-compress-1.19-tests.jar > db59bff01c65ac3b8d078d1f4271c6f4f1754a05e79decb910c2e586f4649483 > commons-compress-1.19-test-sources.jar > > I have tested this with Java 8 using Maven 3.5.4. > > Details of changes since 1.18 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/compress/RELEASE-NOTES.txt > > https://stefan.samaflost.de/staging/commons-compress-1.19/changes-report.html > > Site: > https://stefan.samaflost.de/staging/commons-compress-1.19/ > > Note, as usual when I cut the release this is *not* the site I'm going > to publish. I'll modify it once the release date is fixed. As usual the > download page or the javadocs for the 1.19 release will not work. > > japicmp Report (compared to 1.18): > https://stefan.samaflost.de/staging/commons-compress-1.19/japicmp.html > > For some reason japicmp decided to compare 1.19 to itself, so I > rebuilt the report on master. I hope to figure out what is going on > before preparing the final site. > > The binary incompatible changes to PKWareExtraHeader and its X_* > subclasses are noted inside the release notes and are extremely > unlikely to affect anybody as nobody will be using the methods with > added throws clauses directly. > > RAT Report: > > https://stefan.samaflost.de/staging/commons-compress-1.19/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. This vote will close no > sooner that 72 hours from now, i.e. sometime after 17:00 UTC 27-Aug 2019 > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
