And my +1. Gary
On Fri, Sep 20, 2019, 15:44 Gary Gregory <ggreg...@apache.org> wrote: > We have fixed quite a few bugs and added some enhancements since Apache > Commons BCEL 6.3.1 was released, so I would like to release Apache Commons > BCEL 6.4.0. > > Apache Commons BCEL 6.4.0 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2 (svn > revision 35956) > > The Git tag commons-bcel-6.4.0-RC2 commit for this RC is > bbaf623d750f030d186ed026dc201995145c63ec which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=bbaf623d750f030d186ed026dc201995145c63ec > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > --branch commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1470 > > These are the artifacts and their hashes: > > #Release SHA-512s > #Fri Sep 20 15:18:20 EDT 2019 > > bcel-6.4.0-bin.tar.gz=adb0907fb538a7c1a6eeb9cffde9769cdc49690e1d74f71b00a1bb59f15fe8ed724199cfb2c53c4416936f38bfb2b1c9b6b82662198449bba3dc66f1ea66bf89 > > bcel-6.4.0-bin.zip=63e4ab394f517803a823945a9772933ce6e13edcbb4e1453e852b7f769f8dd0289926dc16678e7a2fe3f01f6141fbf1cc2bdd4372127a1ce5292e04347095201 > > bcel-6.4.0-javadoc.jar=d34cccc064830c51747dacc0ddc321da365e37fe754bb145fb9d00a309e9865c43318d427c0bdc775f125e3686531998666ba247b113a88148b05c634ca9e40a > > bcel-6.4.0-sources.jar=f9de34aa59768dcb0b4aaf7c0ffc833302e77e4e01db85816553530d4ba1a6f87778b02bcbc9097fa699069ce85c3d372ec860002dd4c39d9e7093dd31d7771b > > bcel-6.4.0-src.tar.gz=998c0b4669739b449d918c2c41d83bdd682375f98ca646fba982d53a4216badb67e4200e945cc4958fe481bcc9a48e1635c7e15a3cb6accd5c27d326289f8b22 > > bcel-6.4.0-src.zip=7488601f243b1e31644002358ee50889c1dc1dfdc5c19c4c6cda04270cc47ac6b4495e733065bc451b40bcc3bae2130d56314d7bedb3b99fbb5b7b5658c48912 > > bcel-6.4.0-test-sources.jar=2cfcca5c63986a46952d83df2544e510e6464991a2506d48c2797fdf183df0353fa18c81f25c0e97bf5ddd293a0bab663069e726f727157a9366bf08366f380b > > bcel-6.4.0-tests.jar=b2f8f00bd523f36227e2978218ebf8a6d9538288eaa7e9fbabb0609e444f133f2e39fb3d14c4ea7ad3ab09cd61784cea546455ec6b0c88928bff381fffb14fba > > I have tested this with > > mvn -V -Duser.name=%my_apache_id% > -Dcommons.release-plugin.version=1.7-SNAPSHOT -Ddoclint=none -Prelease > -Ptest-deploy clean package site deploy > > using: > > Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; > 2019-08-27T11:06:16-04:00) > Maven home: C:\Java\apache-maven-3.6.2\bin\.. > Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_221\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Details of changes since 6.3.1 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/index.html > (note some *relative* links are broken and the 6.4.0 directories are > not yet created - these will be OK once the site is deployed.) > > No CLIRR Report, we use JApiCmp instead: > > JApiCmp Report (compared to 6.3.1): > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/japicmp.html > > Note the addition of default methods to the interface > org.apache.bcel.classfile.Visitor > which provides binary compatibility. > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.4.0-RC2/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > ============================== > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git --branch > commons-bcel-6.4.0-RC2 commons-bcel-6.4.0-RC2 > cd commons-bcel-6.4.0-RC2 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which you > then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Older components still use Apache Clirr: > > This step is not required if the site includes a Clirr report page which > you then must check. > > Newer components use JApiCmp with the japicmp Maven Profile: > > This step is not required if the site includes a JApiCmp report page which > you then must check. > > mvn install -DskipTests -P japicmp japicmp:cmp > > 4) Build the package > > mvn -V clean package > > You can record the Maven and Java version produced by -V in your VOTE > reply. > To gather OS information from a command line: > Windows: ver > Linux: uname -a > > 5) Build the site for a single module project > > Note: Some plugins require the components to be installed instead of > packaged. > > mvn site > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > 6) Build the site for a multi-module project > > mvn site > mvn site:stage > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > -the end- >
