On 28/09/2019 17:42, Mark Thomas wrote: > On 28/09/2019 17:06, Gary Gregory wrote: >> On Sat, Sep 28, 2019 at 12:04 PM Gary Gregory <garydgreg...@gmail.com> >> wrote:
<snip/> >>> I can build without errors but with warnings: >>> >>> .\..\..\apps\prunsrv\prunsrv.c(323): warning C4996: '_wfopen': This >>> function or variable may be unsafe. Consider using _wfopen_s instead. To >>> disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for >>> details. >>> C:\Program Files (x86)\Windows >>> Kits\10\include\10.0.17763.0\ucrt\corecrt_wstdio.h(130): note: see >>> declaration of '_wfopen' >>> .\..\..\apps\prunsrv\prunsrv.c(347): warning C4996: '_wfopen': This >>> function or variable may be unsafe. Consider using _wfopen_s instead. To >>> disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for >>> details. >>> C:\Program Files (x86)\Windows >>> Kits\10\include\10.0.17763.0\ucrt\corecrt_wstdio.h(130): note: see >>> declaration of '_wfopen' >>> .\..\..\apps\prunsrv\prunsrv.c(1339): warning C4996: '_snprintf': This >>> function or variable may be unsafe. Consider using _snprintf_s instead. To >>> disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for >>> details. >>> C:\Program Files (x86)\Windows >>> Kits\10\include\10.0.17763.0\ucrt\stdio.h(1961): note: see declaration of >>> '_snprintf' >>> .\..\..\apps\prunsrv\prunsrv.c(1341): warning C4996: '_snprintf': This >>> function or variable may be unsafe. Consider using _snprintf_s instead. To >>> disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for >>> details. >>> C:\Program Files (x86)\Windows >>> Kits\10\include\10.0.17763.0\ucrt\stdio.h(1961): note: see declaration of >>> '_snprintf' >>> rc /l 0x409 /d "NDEBUG" /i ".\..\..\include" /fo >>> WINXP_X86_EXE_RELEASE\prunsrv.res .\..\../apps/prunsrv/prunsrv.rc These have been fixed in 1d0243e I also tried turning up warnings from -W3 (the compiler default) to -W4 and I fixed a reasonable proportion (but not all) of the additional warnings that generated. <snip/> >>>>>> It seems we should NOT deliver the following folders in the src zip >>>>> which >>>>>> now contain objs and exes: >>>>>> >>>>>> src\native\windows\apps\prunmgr\WINXP_X86_GUI_RELEASE >>>>>> src\native\windows\apps\prunsrv\WINXP_X86_EXE_RELEASE >>>>>> src\native\windows\apps\prunsrv\WINXP_X64_EXE_RELEASE >>>>>> >>>>>> WDYT? >>>>> >>>>> Looks like the build created the files in the wrong directories? I've modified the assembly descriptors to always exclude these files. >>>>> The src zip also contains: >>>>> src/native/unix/configure >>>>> AIUI this is a generated file; I would expect it to be in the binary >>>>> artifact, if anywhere > > No. The configure script is generated but it *is* meant to be in the > source distribution. Without it, building from source is more difficult. > I forgot this for the 1.2.0 release and there were complaints as a result. I disagree with adding this to source control since it goes against the standard convention and will not be what developers will expect. >>>>> Also there are some Git files missing from the src zip. >>>>> Not sure if that is intentional? >>>>> >>>>> CONTRIBUTING.md >>>>> HOWTO-RELEASE.txt >>>>> README.md All fixed. I want to do some test builds locally and then I should be ready to tag RC2. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
