On Thu, 24 Oct 2019 at 16:36, Alex Herbert <[email protected]> wrote: > > > > > On 24 Oct 2019, at 16:23, Gilles Sadowski <[email protected]> wrote: > > > > Hello. > > > > "Commons RNG" page on GitHub[1] now links to the LGTM report[2]. > > > > Unfortunately, the one "alert" there[3] is a false positive. > > Perhaps, we could make it go away by rewriting the "while" loop > > as a "for" loop... (or changing the bound to "size - 1”). > > I saw that. > > The loop was written to avoid an if statement within the loop. I’ll see if a > variant can pass the LGTM check.
If you do change the code, best to add a comment as to why the particular syntax is being used. > Alex > > > > > > Regards, > > Gilles > > > > [1] https://github.com/apache/commons-rng > > [2] https://lgtm.com/projects/g/apache/commons-rng/context:java > > [3] > > https://lgtm.com/projects/g/apache/commons-rng/snapshot/8504c91b999959c38e97a69ed1d9f71f41e3bd40/files/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Long2IntArray.java > > > >> [...] > >> > >> commit 5461d28594d006365b20a4748957656208c3a599 > >> Author: Gilles Sadowski <[email protected]> > >> AuthorDate: Thu Oct 24 17:08:08 2019 +0200 > >> > >> Badge. > >> [...] > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
