> On 6 Nov 2019, at 18:17, Gilles Sadowski <gillese...@gmail.com> wrote:
>
>> [...]
>>
>>
>> Any objections to updating multiply/divide/isNaN to match the standard?
>
> Let me think... ;-)
OK, I’ll fix it and double check the other tests against the c reference.
>
>>
>> I'll add unit tests to hit the edge cases that should fail with the
>> current implementation.
>
> Thanks,
> Gilles
Are changes to numbers going under Jira tickets?
It looks like it needs an update to checkstyle, PMD, spotbugs, the
commons-parent and travis.
Checkstyle config from commons-rng finds:
[INFO] There are 115 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-core/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 202 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-complex/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 102 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-complex-streams/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 276 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-primes/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 68 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-quaternion/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 289 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-fraction/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 10 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-angle/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 3503 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-gamma/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 56 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-combinatorics/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 50 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-arrays/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 10 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-field/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 4 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-rootfinder/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
The mass of errors is white space style in the test classes. Without the test
classes the result is:
[INFO] There are 12 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-core/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 54 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-complex/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 19 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-complex-streams/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 49 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-primes/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 5 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-quaternion/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 6 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-fraction/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 3 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-angle/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 20 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-gamma/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 19 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-combinatorics/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 4 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-arrays/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
[INFO] There are 6 errors reported by Checkstyle 8.20 with
/Users/ah403/git/commons-numbers/commons-numbers-field/../src/main/resources/checkstyle/checkstyle.xml
ruleset.
Also looking at Complex it would benefit from:
public Complex subtractFrom(double minuend) {
return new Complex(minuend - real, imaginary);
}
This would avoid:
Complex a = …;
double b = …;
Complex c = Complex.ofCartesian(b - a.real(), a.imag());
Complex d = Complex.ofReal(b).subtract(a).conj();
With
Complex a = …;
double b = …;
Complex c = a.subtractFrom(b);
>
>>
>>
>> [1] http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf
>>
>> [2] http://www.open-std.org/JTC1/SC22/WG14/www/standards
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
