I usually run site builds with -P jacoco and -P japicmp Gary
On Mon, Nov 11, 2019 at 12:55 PM Alex Herbert <[email protected]> wrote: > On 11/11/2019 16:43, Gary Gregory wrote: > > The JApiCmp and JaCoCo reports are empty. You'll want to make sure you > fix > > that before publishing the site. > > Good spot. Unfortunately I've already pushed to the live site so I'll > have to fix it in-place. > > > JAPIcmp was introduced in parent-49 but set to disabled by default. RNG > did not use it for this release. It still appears in the menu but the > report is empty. So is this an issue with commons-parent? > > I can fix JAPIcmp by running the report because I have made the master > branch use JAPIcmp. > > > Something strange is happening with JaCoCo for the multi-module site build. > > These are fine: > > > https://commons.apache.org/proper/commons-rng/commons-rng-core/jacoco/index.html > > > https://commons.apache.org/proper/commons-rng/commons-rng-sampling/jacoco/index.html > > > https://commons.apache.org/proper/commons-rng/commons-rng-simple/jacoco/index.html > > This is missing: > > > https://commons.apache.org/proper/commons-rng/commons-rng-client-api/jacoco-aggregate/index.html > > The client API module has only interfaces. There are no tests. So when > jacoco runs it states: > > [INFO] --- jacoco-maven-plugin:0.8.4:report (report) @ > commons-rng-client-api --- > [INFO] Skipping JaCoCo execution due to missing execution data file. > > But for some reason it still runs the aggregate report. The same is true > for the top level web site page which is why there is a JaCoCo Aggregate > report listed here: > > https://commons.apache.org/proper/commons-rng/project-reports.html > > But is it empty. > > This may have always been the case. > > It may be due to an update to JaCoCo which is now running the aggregate > report by default when previously it did not. > > The JaCoCo docs [1] state that: > > "Creates a structured code coverage report (HTML, XML, and CSV) from > multiple projects within reactor. The report is created from all modules > this project depends on." > > So all the modules that have dependencies to other modules get an > aggregate report. But it also appears for those with no dependencies to > other modeles. Either way this is not needed for RNG as each module has > tests to ensure coverage within the module. It is more a report for > coverage of integration tests. > > I will try and find out why these are running and just remove them. > > > [1] https://www.eclemma.org/jacoco/trunk/doc/report-aggregate-mojo.html > > > > > > Gary > > > > On Tue, Nov 5, 2019 at 11:36 AM Alex Herbert <[email protected]> > wrote: > > > >> We have fixed quite a few bugs and added some significant enhancements > >> since Apache Commons RNG 1.2 was released, so I would like to release > >> Apache Commons RNG 1.3. > >> > >> Apache Commons RNG 1.3 RC1 is available for review here: > >> https://dist.apache.org/repos/dist/dev/commons/rng/1.3-RC1/ > >> https://home.apache.org/~aherbert/commons-rng-1.3-RC1-site/ > >> > >> Tag name: > >> RNG_1_3_RC1 (signature can be checked from git using 'git tag -v > >> RNG_1_3_RC1') > >> > >> Tag URL: > >> > >> > https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=43f290e68c31e5bea6cde97c7e999c2e1f2562b2 > >> > >> Commit ID the tag points at: > >> 43f290e68c31e5bea6cde97c7e999c2e1f2562b2 > >> > >> Maven artifacts are here: > >> > >> > https://repository.apache.org/content/repositories/orgapachecommons-1476/org/apache/commons/ > >> > >> These are the artifacts and their SHA 512 hashes: > >> > 310c0582b80c60fb159846f9615c7952b3c405265955392d77b16d7cfac9e8c5f2c680686e526b412ab8b4356ef9ecd07977764c31db8e02bef40e37b47ac27a > >> > >> commons-rng-1.0-bin.tar.gz > >> > e0247ea82aff57cc86ac904ae482c193b7edd5253d26f87fc590b50a738d5fa5c4a6b3b24cd6a48c459e18156ade2588d8c9d12c9a04d15570780240d29ef406 > >> > >> commons-rng-1.0-bin.zip > >> > f33b922a9d8bc6098bd0e9a98859b17e1cdda21922f136b568868b21af274fdf3d78456a5c73c26c665205a22493836d59b1d33822c4a5c58e82ba64eadcb5e1 > >> > >> commons-rng-1.0-src.tar.gz > >> > ef4fe63ebbd76e8d95b5f054fed76a40a85f5dd99ca2406a31fb95b593ed3d96b29389bf82424e18895192751689d7590404c8b1d90b28878271c79cad3be18b > >> > >> commons-rng-1.0-src.zip > >> > >> The source code contains examples that are not part of the public API. > >> These examples contain Java 9 modules and are enabled using a profile > >> (see below). > >> > >> An error when building the Java 9 modules site/javadoc under JDK 11 is a > >> known issue as the javadoc command errors when documenting Java 9 > >> modules that include code from the unamed module. > >> > >> Note: Testing randomness using statistical thresholds results in > >> failures at a given probability. The 'maven-surefire-plugin' is > >> configured to re-run tests that fail, and pass the build if they succeed > >> within the allotted number of reruns (the test will be marked as 'flaky' > >> in the report). > >> > >> I have tested this with: > >> > >> 'mvn clean install site' using: > >> > >> *** > >> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > >> 2018-10-24T19:41:47+01:00) > >> Maven home: /usr/local/apache-maven-3.6.0 > >> Java version: 1.8.0_222, vendor: Private Build, runtime: > >> /usr/lib/jvm/java-8-openjdk-amd64/jre > >> Default locale: en_GB, platform encoding: UTF-8 > >> OS name: "linux", version: "4.4.0-166-generic", arch: "amd64", family: > >> "unix" > >> *** > >> > >> *** > >> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > >> 2018-10-24T19:41:47+01:00) > >> Maven home: /usr/local/apache-maven-3.6.0 > >> Java version: 11.0.5, vendor: AdoptOpenJDK, runtime: > >> /usr/lib/jvm/jdk-11.0.5+10 > >> Default locale: en_GB, platform encoding: UTF-8 > >> OS name: "linux", version: "4.4.0-166-generic", arch: "amd64", family: > >> "unix" > >> *** > >> > >> Java 9 modules in the examples modules. > >> > >> 'mvn -Pcommons-rng-examples clean install site' using: > >> > >> *** > >> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > >> 2018-10-24T19:41:47+01:00) > >> Maven home: /usr/local/apache-maven-3.6.0 > >> Java version: 9, vendor: Oracle Corporation, runtime: /usr/lib/jvm/jdk-9 > >> Default locale: en_GB, platform encoding: UTF-8 > >> OS name: "linux", version: "4.4.0-166-generic", arch: "amd64", family: > >> "unix" > >> *** > >> > >> 'mvn -Pcommons-rng-examples clean install' using: > >> > >> *** > >> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; > >> 2018-10-24T19:41:47+01:00) > >> Maven home: /usr/local/apache-maven-3.6.0 > >> Java version: 11.0.5, vendor: AdoptOpenJDK, runtime: > >> /usr/lib/jvm/jdk-11.0.5+10 > >> Default locale: en_GB, platform encoding: UTF-8 > >> OS name: "linux", version: "4.4.0-166-generic", arch: "amd64", family: > >> "unix" > >> *** > >> > >> Details of changes since 1.2 are in the release notes: > >> > >> > https://dist.apache.org/repos/dist/dev/commons/rng/1.3-RC1/RELEASE-NOTES.txt > >> > >> > https://home.apache.org/~aherbert/commons-rng-1.3-RC1-site/changes-report.html > >> > >> Site: > >> https://home.apache.org/~aherbert/commons-rng-1.3-RC1-site/index.html > >> (note some *relative* links are broken and the 1.3 directories are > >> not yet created - these will be OK once the site is deployed.) > >> > >> CLIRR Report (compared to 1.2): > >> > >> > https://home.apache.org/~aherbert/commons-rng-1.3-RC1-site/commons-rng-client-api/clirr-report.html > >> > >> > https://home.apache.org/~aherbert/commons-rng-1.3-RC1-site/commons-rng-core/clirr-report.html > >> > >> > https://home.apache.org/~aherbert/commons-rng-1.3-RC1-site/commons-rng-simple/clirr-report.html > >> > >> > https://home.apache.org/~aherbert/commons-rng-1.3-RC1-site/commons-rng-sampling/clirr-report.html > >> > >> RAT Report: > >> > https://home.apache.org/~aherbert/commons-rng-1.3-RC1-site/rat-report.html > >> > >> KEYS: > >> https://www.apache.org/dist/commons/KEYS > >> > >> Please review the release candidate and vote. > >> This vote will close no sooner that 72 hours from now. > >> > >> [ ] +1 Release these artifacts > >> [ ] +0 OK, but... > >> [ ] -0 OK, but really should fix... > >> [ ] -1 I oppose this release because... > >> > >> Thank you, > >> > >> Alex Herbert, > >> Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567) > >> > >> For following is intended as a helper and refresher for reviewers. > >> > >> Validating a release candidate > >> ============================== > >> > >> These guidelines are NOT complete. > >> > >> Requirements: Git, Java, Maven. > >> > >> You can validate a release from a release candidate (RC) tag as follows. > >> > >> 1) Clone and checkout the RC tag > >> > >> git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch > >> RNG_1_3_RC1 commons-rng-1.3-RC1 > >> cd commons-rng-1.3-RC1 > >> > >> 2) Check Apache licenses > >> > >> This step is not required if the site includes a RAT report page which > >> you then must check. > >> > >> mvn apache-rat:check > >> > >> 3) Check binary compatibility > >> > >> Older components still use Apache Clirr: > >> > >> This step is not required if the site includes a Clirr report page which > >> you then must check. > >> > >> mvn clirr:check > >> > >> JApiCmp is not used in this component. > >> > >> > >> 4) Build the package > >> > >> mvn -V clean package > >> > >> You can record the Maven and Java version produced by -V in your VOTE > >> reply. > >> To gather OS information from a command line: > >> Windows: ver > >> Linux: uname -a > >> > >> 5) Build the site for a multi-module project > >> > >> mvn site > >> mvn site:stage > >> Check the site reports in: > >> - Windows: target\site\index.html > >> - Linux: target/site/index.html > >> > >> -the end- > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
