On 22/11/2019 18:11, Gary Gregory wrote: > On Fri, Nov 22, 2019 at 12:29 PM Mark Thomas <ma...@apache.org> wrote: > >> On 21/11/2019 19:29, ggreg...@apache.org wrote: >>> This is an automated email from the ASF dual-hosted git repository. >>> >>> ggregory pushed a commit to branch master >>> in repository https://gitbox.apache.org/repos/asf/commons-daemon.git >>> >>> >>> The following commit(s) were added to refs/heads/master by this push: >>> new 8a46539 [DAEMON-414] prunsrv uses its log is before it is >> initialized. >>> 8a46539 is described below >>> >>> commit 8a46539bd0a7fe42fab667a249a1c59906faf9ab >>> Author: Gary Gregory <gardgreg...@gmail.com> >>> AuthorDate: Thu Nov 21 14:29:25 2019 -0500 >> >> >> Sorry, this needs to be reverted. >> >> You've moved the logging initialisation above the code that reads the >> logging configuration. This breaks the logging. >> >> A better fix would probably be to change the two lines that write to the >> log file before it is ready to write to stderr instead. >> > > Reverted. Thank you for reviewing.
Thanks, and sorry I missed that first time around. > Two items: > > 1) There is a LOT of logging I feel we are missing. I want to turn on DEBUG > logging and see EVERYTHING that happens at init time to be able to help > users figure out why a service cannot be registered or, seemingly > registered OK but getting a weird error on service start. The classic > example, is using 64-bit prunsrv with 32-bit Java. Or, having JAVA_HOME > pointing to the "wrong" place where "wrong" can be wrong in all sorts of > ways. Having spent several hours last night debugging why the Java start mode wasn't working to find it was a typo in the location of JAVA_HOME in the registry I completely agree with you. > 2) When I do turn on DEBUG logging, I only see ERROR on stderr on startup. > > So I'd like help in getting help for our users :-) I'm happy to help out where I can. My normal approach is to add debug logging when I'm trying to fix something and I can't figure out what went wrong. I'm expecting to be adding a log of debug logging to the start-up process after last night and the next bug on my TODO list is start-up related as well. It won't be completely comprehensive but it should be better than what we have. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
