Gary, I appreciate the sentiment of not wanting to make a major change, but if you look at the commit history and the emails from 2013 you'll realize this last commit is actually fairly small. The only reason this wasn't done in 2013 was that the release process didn't seem to want to work for me, and so I gave up and forked the code.
Also, it should be noted that this is released as dbutils2 and so it won't conflict with people pulling in previous versions. Take a look at the changes, and provide feedback... But don't judge this simply on how large it is. Thanks! Bill- On Mon, Dec 30, 2019, 8:09 PM Gary Gregory <garydgreg...@gmail.com> wrote: > I think we should look at the current code base we have in master and work > in new features and bug fixes one PR at a time. > > Trying some big bang port from some now 'foreign' code base is likely to > not get reviewed if it comes in one giant PR. > > Gary > > On Mon, Dec 30, 2019 at 5:17 PM Carl Hall <thecarlh...@apache.org> wrote: > > > There was a 2_0 branch started several years ago[1]. That release was > > abandoned, the code wasn’t merged into master, and a fork was spurred > > outside of Apache[2]. I’d like to rectify this and work to a release. > > > > The code was moved to a different package in both repos, so merging isn’t > > straightforward. I can attempt to copy in the classes from the 2_0 branch > > in gitbox or manually copy the classes from Bill’s GitHub account. Both > > seem like a lot of work with chances for accidentally unwinding more > recent > > changes. I think a more detailed review would be better, but time isn’t > on > > my side for that. > > > > Any suggestions for how to best proceed on this? Bill, if there’s anyway > > you could work the merge, I’ll manage the release. > > > > 1 > > > https://gitbox.apache.org/repos/asf?p=commons-dbutils.git;a=shortlog;h=refs/heads/2_0 > > < > > > https://gitbox.apache.org/repos/asf?p=commons-dbutils.git;a=shortlog;h=refs/heads/2_0 > > > > > 2 https://github.com/wspeirs/sop4j-dbutils/tree/dbutils-2.2 < > > https://github.com/wspeirs/sop4j-dbutils/tree/dbutils-2.2> > > > > >
