> On 4 Feb 2020, at 19:36, Jochen Wiedmann <jochen.wiedm...@gmail.com> wrote:
>
> On Mon, Feb 3, 2020 at 3:57 PM Gary Gregory <garydgreg...@gmail.com> wrote:
>
>> The commit
>> https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=commit;h=2ea44b2adae8da8e3e7f55cc226479f9431feda9
>> broke
>> the Travis build due to Checktyle errors.
>
> As the responsible person, I apologize for that. I am sure, that I did
> a "mvn clean install" before committing, and pushing. Obviously, that
> is not enough. What other Maven targets should I use?
Travis just uses ‘mvn’. This triggers the default goal in the pom which does
this:
mvn clean verify apache-rat:check clirr:check checkstyle:check spotbugs:check
javadoc:javadoc
It is checkstyle that you missed. There are a lot of tabs in your main file
Stream.java. Not sure if that is the problem or trailing whitespace. Fixing it
should be trivial.
I did note when I had a look that the main javadoc gives the example:
* Using a {@link FailableStream}, this can be rewritten as follows:
* <pre>
* ObjectStreams.failable(stream).forEach((m) -> m.invoke(o, args));
* </pre>
Should ObjectStreams.failable be changed to ‘Streams.stream’?
This is what the class currently allows. Or use of the public constructor for
FailableStream:
new FailableStream(stream)...
Is it intentional to have a public constructor here?
>
> Thanks,
>
> Jochen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
