> On 18 Feb 2020, at 03:06, Matt Juntunen <[email protected]> wrote:
>
> Hi Alex,
>
> Thanks for the updates on this. FYI, the current geometry build fails due to
> a missing import:
> https://travis-ci.org/apache/commons-geometry/jobs/651768129#L3806.
Sorry. I blindly trusted my IDE to clean-up the code to add ‘final’. It removed
an import.
I’ve tweaked a few more rules and the count of violations is more reasonable.
I get a clean build now using ‘mvn’.
>
>
> -Matt
> ________________________________
> From: Alex Herbert <[email protected]>
> Sent: Monday, February 17, 2020 7:18 PM
> To: Commons Developers List <[email protected]>
> Subject: [geometry] PMD failures
>
> I’ve just updated PMD and checkstyle on [rng], [numbers] and [geometry].
> After a few glitches I have fixed [rng] and [numbers].
>
> [geometry] has a lot of PMD issues:
>
> [INFO] You have 64 PMD violations. For more details see:
> /Users/ah403/git/commons-geometry/commons-geometry-core/target/pmd.xml
> [INFO] You have 244 PMD violations. For more details see:
> /Users/ah403/git/commons-geometry/commons-geometry-euclidean/target/pmd.xml
> [INFO] You have 14 PMD violations. For more details see:
> /Users/ah403/git/commons-geometry/commons-geometry-enclosing/target/pmd.xml
> [INFO] You have 113 PMD violations. For more details see:
> /Users/ah403/git/commons-geometry/commons-geometry-spherical/target/pmd.xml
> [INFO] You have 16 PMD violations. For more details see:
> /Users/ah403/git/commons-geometry/commons-geometry-hull/target/pmd.xml
>
> Many of these are easy to fix such as use of final and literals in condition
> statements.
>
> For now I have disabled the failOnViolation for geometry. After fixing the
> obvious ones we can add exclusions for those items that are deemed fine and
> reinstate PMD to fail on violation.
>
> Alex
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
