Thanks for that set of eyes. I’ll be sure to change the NOTICE.txt

-Rob

> On Mar 8, 2020, at 1:31 PM, Oliver Heger <oliver.he...@oliver-heger.de> wrote:
> 
> Hi Rob,
> 
> many thanks for working on the release.
> 
> I also did a check. The builds of the jar and the site were successful
> with the configuration below. Artifacts and site look good.
> 
> The NOTICE file has still a copyright year of 2019; so if you re-roll
> the RC, you should adapt this. Otherwise, I found no problems.
> 
> Oliver
> 
> Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 1.8.0_242, vendor: Amazon.com Inc., runtime:
> /opt/amazon-corretto-8.242.08.1-linux-x64/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "5.3.0-40-generic", arch: "amd64", family: "unix"
> 
>> Am 08.03.20 um 18:04 schrieb Rob Tompkins:
>> This vote is cancelled.
>> 
>> I’m not particular as to how it’s built. My convention was to use latest 
>> long term support, hence my using java 11 here. Thus, based on your point 
>> below, I’ll re-roll the RC later today.
>> 
>> Many thanks for the eyes there,
>> -Eob
>> 
>>>> On Mar 8, 2020, at 9:53 AM, Gary Gregory <garydgreg...@gmail.com> wrote:
>>> 
>>> Hm... I do not think we should be build Java 8 components with Java 11.
>>> It's too risky to bind to Buffer APIs that have different return types
>>> starting in Java 9 and end up with potential problems when running on Java
>>> 8.
>>> 
>>> Sure, it's nice to have searchable Javadocs but if we really want that, we
>>> can build the Javadoc with Java 9+ as a separate step.
>>> 
>>> Gary
>>> 
>>>> On Sat, Mar 7, 2020 at 3:32 PM Rob Tompkins <chtom...@apache.org> wrote:
>>>> 
>>>> We have fixed quite a few bugs and added some significant enhancements
>>>> since Apache Commons Configuration 2.6 was released, so I would like to
>>>> release Apache Commons Configuration 2.7.
>>>> 
>>>> Apache Commons Configuration 2.7 RC1 is available for review here:
>>>>   https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC1
>>>> (svn revision 38432)
>>>> 
>>>> The Git tag commons-configuration-2.7-RC1 commit for this RC is
>>>> 6bb7c21c14849169415b2afdfb2d2057bc2adb08 which you can browse here:
>>>> 
>>>> https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=6bb7c21c14849169415b2afdfb2d2057bc2adb08
>>>> You may checkout this tag using:
>>>>   git clone
>>>> https://gitbox.apache.org/repos/asf/commons-configuration.git --branch
>>>> commons-configuration-2.7-RC1 commons-configuration-2.7-RC1
>>>> 
>>>> Maven artifacts are here:
>>>> 
>>>> https://repository.apache.org/content/repositories/orgapachecommons-1493/org/apache/commons/commons-configuration2/2.7/
>>>> 
>>>> These are the artifacts and their hashes:
>>>> 
>>>> #Nexus SHA-1s
>>>> 
>>>> commons-configuration2-2.7-sources.jar=818bedbcfee18f8d845714f2f25bc134b5c55df6
>>>> commons-configuration2-2.7.pom=161b149bcc081f3bb7424e2240eb40bcc42d5e63
>>>> 
>>>> commons-configuration2-2.7-javadoc.jar=60e703ae819555b5e11f1809d1eed9a796e30785
>>>> 
>>>> commons-configuration2-2.7-test-sources.jar=7e6ae52be57ae2bf55a3c78da9d7ddf1f34c5e72
>>>> 
>>>> commons-configuration2-2.7-tests.jar=30e2de8e75127812dfd0065798ba57960530b940
>>>> commons-configuration2-2.7.jar=c3774a0e5125e7c517e09dafd838b526cca7f3af
>>>> 
>>>> #Release SHA-512s
>>>> #Sat Mar 07 14:51:49 EST 2020
>>>> 
>>>> commons-configuration2-2.7-src.zip=67f7243d9c9af313689d772340421e282956f0435df53afc117ae5b6b37947903157078845a8fb78e4ec4de565fd692f01cb7c145ae41fb8484b836d08343dca
>>>> 
>>>> commons-configuration2-2.7-bin.tar.gz=ee03921e17e3998c5f613956e518caff5a324b5b33b23e85751394f92f19221079d6a1b3e6d1f71e704f531f017ccd28a6bd7c2e555bc37431e34be48bb96f57
>>>> 
>>>> commons-configuration2-2.7-src.tar.gz=b7570dc57a065d15229faa84babdb5d0be223322444b787cb190345105e69c67a86cbf673c0df0b62b30223451d052695e84a5337c3273c5a599eaa19bb541a1
>>>> 
>>>> commons-configuration2-2.7-bin.zip=331c11e96d3361c6414b7eb9b19dbdcde3d3b495ad6b46237db0da594d86d46df29e44a3a5c038503dc47ef7e3aeb04af4c733fa26c13e7373301a319b9b3071
>>>> 
>>>> 
>>>> 
>>>> I have tested this with 'mvn clean install site' using:
>>>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
>>>> Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec
>>>> Java version: 11.0.6, vendor: Amazon.com Inc., runtime:
>>>> /Library/Java/JavaVirtualMachines/amazon-corretto-11.jdk/Contents/Home
>>>> Default locale: en_US, platform encoding: UTF-8
>>>> OS name: "mac os x", version: "10.15.3", arch: "x86_64", family: "mac"
>>>> 
>>>> 
>>>> Details of changes since 2.6 are in the release notes:
>>>> 
>>>> https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC1/RELEASE-NOTES.txt
>>>> 
>>>> https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC1/site/changes-report.html
>>>> 
>>>> Site:
>>>> 
>>>> https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC1/site/index.html
>>>> 
>>>> RAT Report:
>>>> 
>>>> https://dist.apache.org/repos/dist/dev/commons/configuration/2.7-RC1/site/rat-report.html
>>>> 
>>>> KEYS:
>>>> https://www.apache.org/dist/commons/KEYS
>>>> 
>>>> Please review the release candidate and vote.
>>>> This vote will close no sooner that 72 hours from now.
>>>> 
>>>> [ ] +1 Release these artifacts
>>>> [ ] +0 OK, but...
>>>> [ ] -0 OK, but really should fix...
>>>> [ ] -1 I oppose this release because...
>>>> 
>>>> Thank you,
>>>> 
>>>> -Rob
>>>> 
>>>> Rob Tompkins,
>>>> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314)
>>>> 
>>>> For following is intended as a helper and refresher for reviewers.
>>>> 
>>>> Validating a release candidate
>>>> ==============================
>>>> 
>>>> These guidelines are NOT complete.
>>>> 
>>>> Requirements: Git, Java, Maven.
>>>> 
>>>> You can validate a release from a release candidate (RC) tag as follows.
>>>> 
>>>> 1) Clone and checkout the RC tag
>>>> 
>>>> git clone https://gitbox.apache.org/repos/asf/commons-configuration.git
>>>> --branch commons-configuration-2.7-RC1 commons-configuration-2.7-RC1
>>>> cd commons-configuration-2.7-RC1
>>>> 
>>>> 2) Check Apache licenses
>>>> 
>>>> This step is not required if the site includes a RAT report page which you
>>>> then must check.
>>>> 
>>>> mvn apache-rat:check
>>>> 
>>>> 3) Check binary compatibility
>>>> 
>>>> Older components still use Apache Clirr:
>>>> 
>>>> This step is not required if the site includes a Clirr report page which
>>>> you then must check.
>>>> 
>>>> mvn clirr:check
>>>> 
>>>> Newer components use JApiCmp with the japicmp Maven Profile:
>>>> 
>>>> This step is not required if the site includes a JApiCmp report page which
>>>> you then must check.
>>>> 
>>>> mvn install -DskipTests -P japicmp japicmp:cmp
>>>> 
>>>> 4) Build the package
>>>> 
>>>> mvn -V clean package
>>>> 
>>>> You can record the Maven and Java version produced by -V in your VOTE
>>>> reply.
>>>> To gather OS information from a command line:
>>>> Windows: ver
>>>> Linux: uname -a
>>>> 
>>>> 5) Build the site for a single module project
>>>> 
>>>> Note: Some plugins require the components to be installed instead of
>>>> packaged.
>>>> 
>>>> mvn site
>>>> Check the site reports in:
>>>> - Windows: target\site\index.html
>>>> - Linux: target/site/index.html
>>>> 
>>>> 6) Build the site for a multi-module project
>>>> 
>>>> mvn site
>>>> mvn site:stage
>>>> Check the site reports in:
>>>> - Windows: target\site\index.html
>>>> - Linux: target/site/index.html
>>>> 
>>>> -the end-
>>>> 
>>>> 
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>> 
>>>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to