Going from less to more visibility is not going to break BC, so that's OK. Gary
On Mon, Jun 1, 2020 at 9:48 PM Mark Roberts <mar...@cs.washington.edu> wrote: > It’s the other way around - it was protected in 6.4.1 and we need it to be > public or else there is no way to manipulate annotations. Without that > we're dead. > > Mark > > (There was never a pr because I could never get anybody to say it was > okay. ) > > -----Original Message----- > From: Gary Gregory [mailto:garydgreg...@gmail.com] > Sent: Monday, June 1, 2020 6:46 PM > To: Commons Developers List <dev@commons.apache.org> > Subject: Re: [bcel] Anything pending for a 6.4.2 release? > > If something is public in 6.4.1, we cannot change that. Basically, we > cannot break BC. > > Gary > > > On Mon, Jun 1, 2020 at 9:44 PM Gary Gregory <garydgreg...@gmail.com> > wrote: > > > Did I miss a PR? I do not see an open PR from you. > > > > Gary > > > > On Mon, Jun 1, 2020 at 7:54 PM Mark Roberts <mar...@cs.washington.edu> > > wrote: > > > >> I'm happy to do that - but what about my requested changes to > >> src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java? > >> > >> 123c123 > >> < protected void addAnnotationEntry(final AnnotationEntryGen ag) // > >> TODO > >> could this be package protected? > >> --- > >> > public void addAnnotationEntry(final AnnotationEntryGen ag) // > >> > TODO could this be package protected? > >> 139c139 > >> < protected void removeAnnotationEntry(final AnnotationEntryGen ag) > // > >> TODO could this be package protected? > >> --- > >> > public void removeAnnotationEntry(final AnnotationEntryGen ag) > >> > // > >> TODO > >> > could this be package protected? > >> 155c155 > >> < protected void removeAnnotationEntries() // TODO could this be > >> package > >> protected? > >> --- > >> > public void removeAnnotationEntries() // TODO could this be > >> > package protected? > >> > >> -----Original Message----- > >> From: Gary Gregory [mailto:garydgreg...@gmail.com] > >> Sent: Monday, June 1, 2020 4:30 PM > >> To: Commons Developers List > >> Subject: Re: [bcel] Anything pending for a 6.4.2 release? > >> > >> Hi Mark, > >> > >> May you please try the latest from git master and see how that goes? > >> I've merged PR 39 and 40. > >> > >> Gary > >> > >> > >> On Mon, Jun 1, 2020 at 5:15 PM Mark Roberts > >> <mar...@cs.washington.edu> > >> wrote: > >> > >> > In order to support Java 11 in our tools set we needed to update BCEL. > >> > Hence, we made a private release (marked as version 6.4.2) that > >> > contained the following changes: > >> > > >> > Issue 333 - pull request 39 > >> > Issue 334 - pull request 40 > >> > Made AnnotationEntry methods public instead of protected. > >> > > >> > I sent at least two rounds of email on the latter item, the most > >> > recent in February of this year which drew no response. > >> > > >> > We would really like to see these three changes in an official 6.4.2. > >> > > >> > Thank you, > >> > Mark Roberts > >> > > >> > > >> > > >> > -----Original Message----- > >> > From: Gary Gregory [mailto:garydgreg...@gmail.com] > >> > Sent: Saturday, May 30, 2020 7:23 AM > >> > To: Commons Developers List > >> > Subject: [bcel] Anything pending for a 6.4.2 release? > >> > > >> > Mark and all: > >> > > >> > I see a few fixes in git master for the 6.4.2 release. Is there > >> > anything else? > >> > > >> > I am just taking stock of some components what could be useful to > >> release. > >> > > >> > Gary > >> > > >> > ------------------------------------------------------------------- > >> > -- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> > For additional commands, e-mail: dev-h...@commons.apache.org > >> > > >> > > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
