Hi.

2020-06-11 23:54 UTC+02:00, Alex Herbert <alex.d.herb...@gmail.com>:
>
>
>> On 11 Jun 2020, at 18:07, er...@apache.org wrote:
>>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> erans pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/commons-graph.git
>>
>>
>> The following commit(s) were added to refs/heads/master by this push:
>>     new b14766b  Travis CI configuration.
>> b14766b is described below
>>
>> commit b14766be60b3722007d19d015bc383e3d83d11b8
>> Author: Gilles Sadowski <gillese...@gmail.com>
>> AuthorDate: Thu Jun 11 19:06:35 2020 +0200
>>
>>    Travis CI configuration.
>> ---
>> .travis.yml | 33 +++++++++++++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> new file mode 100644
>> index 0000000..709f9ba
>> --- /dev/null
>> +++ b/.travis.yml
>> @@ -0,0 +1,33 @@
>> +# Licensed to the Apache Software Foundation (ASF) under one or more
>> +# contributor license agreements.  See the NOTICE file distributed with
>> +# this work for additional information regarding copyright ownership.
>> +# The ASF licenses this file to You under the Apache License, Version
>> 2.0
>> +# (the "License"); you may not use this file except in compliance with
>> +# the License.  You may obtain a copy of the License at
>> +#
>> +#     http://www.apache.org/licenses/LICENSE-2.0
>> +#
>> +# Unless required by applicable law or agreed to in writing, software
>> +# distributed under the License is distributed on an "AS IS" BASIS,
>> +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> +# See the License for the specific language governing permissions and
>> +# limitations under the License.
>> +
>> +language: java
>> +cache:
>> +  directories:
>> +    - $HOME/.m2
>> +jdk:
>> +  - openjdk8
>> +
>> +# The default build is so verbose the travis log file can exceed the
>> allowed limit.
>> +# Run a custom install that hides all the Maven ‘Downloading’ messages.
>> +install:
>> +  - mvn install -Dmaven.javadoc.skip=true -V -B
>> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
>> +
>> +script:
>> +  - mvn
>> +  - mvn verify apache-rat:check checkstyle:check
>
> I assume this is copied from [numbers].

Indeed.

> In that case maven is called a
> second time to run the examples profile for only the examples modules that
> are not included in the default goal.
>
> Here the second called to mvn is redundant

I thought so, but was not sure which one to remove. :-}

> as you are not targeting a
> specific profile and module. This is assuming that [graph] adds the same
> checks to the default maven goal in the pom.xml.

I assume that Amey will sort this out for every POM
in the "modularization" branch (that still misses a
Travis config).

>
> So:
>
> 1. Check the default goal in the pom includes what you want (test, various
> checks, javadoc build, etc)

I suggested that Amey uses a maintained component as
a model for updating all the POMs in the "modularization"
branch.

> 2. Remove the second ‘mvn’ call in the ‘script:' target above

Sure.  Unless he eventually adds a
   commons-graph-examples
module (?).

Best regards,
Gilles


>
>> +
>> +after_success:
>> +  - mvn jacoco:report coveralls:report
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to