Hi. I see in some places of the repo, two double fields are compared using ==. Shouldn't we use Double.compare? Or is it by design?
example places: PolarCoordinates.equals SphericalCoordinates.equals Vector1D.angle Vector2D.equals Vector3D.equals Vectors.isRealNonZero Xeno Amess <xenoam...@gmail.com> 于2020年7月4日周六 上午1:51写道： > Hi. > Please also consider about > https://github.com/apache/commons-geometry/pull/85 > > I will perform more analyze opun this repo when you solve this two prs. > > Xeno Amess <xenoam...@gmail.com> 于2020年7月4日周六 上午1:01写道： > >> Hi. >> Please check https://github.com/apache/commons-geometry/pull/84 >> In short, there be too many errors in javadoc. >> (and this is the reason why I made >> https://github.com/apache/commons-parent/pull/7) >> >> There still exist some other problems, but I'd prefer check them after >> this pr, as resolve conflict is boring. >> >> >> Xeno Amess <xenoam...@gmail.com> 于2020年7月4日周六 上午12:13写道： >> >>> Hi. >>> I see somethings not quite right already. >>> Will start pr directly. >>> >>> Xeno Amess <xenoam...@gmail.com> 于2020年7月3日周五 下午4:20写道： >>> >>>> I might review it tonight if I have time... >>>> Only if I have time. >>>> Really busy these days... >>>> >>>
