May we get more reviews please? Gary
On Thu, Sep 24, 2020 at 10:20 AM Rob Tompkins <chtom...@gmail.com> wrote: > +1 > Built with java8 and java11 “mvn clean test site” > Reports look good > Signatures check out. > > For signature validation I used the following scripts in a directory > intially containing: > > -rw-r--r--@ 1 chtompki staff 1874482 Sep 23 09:58 > commons-dbcp2-2.8.0-bin.tar.gz > -rw-r--r--@ 1 chtompki staff 499 Sep 23 09:58 > commons-dbcp2-2.8.0-bin.tar.gz.asc > -rw-r--r--@ 1 chtompki staff 130 Sep 23 09:58 > commons-dbcp2-2.8.0-bin.tar.gz.sha512 > -rw-r--r--@ 1 chtompki staff 2115454 Sep 23 09:58 > commons-dbcp2-2.8.0-bin.zip > -rw-r--r--@ 1 chtompki staff 499 Sep 23 09:58 > commons-dbcp2-2.8.0-bin.zip.asc > -rw-r--r--@ 1 chtompki staff 130 Sep 23 09:58 > commons-dbcp2-2.8.0-bin.zip.sha512 > -rw-r--r--@ 1 chtompki staff 643741 Sep 23 09:58 > commons-dbcp2-2.8.0-src.tar.gz > -rw-r--r--@ 1 chtompki staff 499 Sep 23 09:58 > commons-dbcp2-2.8.0-src.tar.gz.asc > -rw-r--r--@ 1 chtompki staff 130 Sep 23 09:58 > commons-dbcp2-2.8.0-src.tar.gz.sha512 > -rw-r--r--@ 1 chtompki staff 789105 Sep 23 09:58 > commons-dbcp2-2.8.0-src.zip > -rw-r--r--@ 1 chtompki staff 499 Sep 23 09:58 > commons-dbcp2-2.8.0-src.zip.asc > -rw-r--r--@ 1 chtompki staff 130 Sep 23 09:58 > commons-dbcp2-2.8.0-src.zip.sha512 > -rwxr-xr-x@ 1 chtompki staff 1167 Sep 24 10:10 downloader.sh > -rwxr-xr-x@ 1 chtompki staff 1511 Sep 24 10:14 validator.sh > > Where downloader.sh = > https://github.com/chtompki/notes/blob/master/commons-release-validation/commons-dbcp-2.8.0-RC1-downloader.sh > < > https://github.com/chtompki/notes/blob/master/commons-release-validation/commons-dbcp-2.8.0-RC1-downloader.sh > > > and validator.sh = > https://github.com/chtompki/notes/blob/master/commons-release-validation/commons-dbcp-2.8.0-RC1-validator.sh > < > https://github.com/chtompki/notes/blob/master/commons-release-validation/commons-dbcp-2.8.0-RC1-validator.sh > > > > All the files were intially retrieved from > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.8.0-RC1 < > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.8.0-RC1> > > Feel free to use my signature validation scripts. > > -Rob > > > On Sep 21, 2020, at 3:34 PM, Gary Gregory <ggreg...@apache.org> wrote: > > > > We have fixed a few bugs and added some enhancements since Apache Commons > > DBCP 2.7.0 was released, so I would like to release Apache Commons DBCP > > 2.8.0. > > > > Apache Commons DBCP 2.8.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.8.0-RC1 (svn > > revision 41530) > > > > The Git tag commons-dbcp-2.8.0-RC1 commit for this RC is > > 5dea53a5e089862c37c830c725315d90b444852e which you can browse here: > > > > > https://gitbox.apache.org/repos/asf?p=commons-dbcp.git;a=commit;h=5dea53a5e089862c37c830c725315d90b444852e > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-dbcp.git > --branch > > commons-dbcp-2.8.0-RC1 commons-dbcp-2.8.0-RC1 > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1528/org/apache/commons/commons-dbcp2/2.8.0/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Mon Sep 21 15:23:26 EDT 2020 > > > commons-dbcp2-2.8.0-bin.tar.gz=3f09d7eb45979d239454d4239984c920c42ba642b069d520408d613262d7f5d9b7c86e3041617bbefa460cd84f3babed7b6cde140dbfe46d95fdd733b66854f3 > > > commons-dbcp2-2.8.0-bin.zip=353e47ec4c927edf14e843732e24bce1ede3782589d45fae2ccb93584db3d413ff030bbdffb1f04c76084c4b2fda7a25c24802e1ca9de559ff5e375304ba266e > > > commons-dbcp2-2.8.0-javadoc.jar=28528baf0a5a3796fcd0a8cad3a040a6fc28ae8b44065ea188cf97d26eb6777c51657d6405c89457f8014d8683f51bbd601deb28aa1032850fc040f1b7ee561c > > > commons-dbcp2-2.8.0-sources.jar=61d06856441a8d9147f339e354f15742df9ab701d3cfafd81b927b24313d552cd7a3268c6bcf84090987f12953014e6eb712b660886b0ab04032fa54212d93a9 > > > commons-dbcp2-2.8.0-src.tar.gz=9a7d3877a83e961db77d4766c299db2fcb120a760c4d30db54faca983b97ab92e001435ce558ec7be7483b27744235fe246b4267c884add6dd0130fae78c2d6d > > > commons-dbcp2-2.8.0-src.zip=81a018d18f0213525350545afc82fb58de1521fd78cdaac7439a5c5af53652c2a1f5e46bf06a8651754e26fc542b99361eda1207703929b09e43f9037376837c > > > commons-dbcp2-2.8.0-test-sources.jar=255c2f456fceac57da0b215fa119a33152b0ef902e0a17b1211578dc042ec1881f8b02f5555fa1c144343c482ff728663090762dd806d9f4fb17c1467f2a3bd3 > > > commons-dbcp2-2.8.0-tests.jar=291dc8210b11fb5cd980c94587be1db1265b4c74ced9c26c793776b2339f4a470478a4dc5fd9f7a57739d1e25a5740e4eaeada1c2c1e13b5ddc5e3ad6bdc1ae9 > > > > > > I have tested this with: > > > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site > > deploy > > > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > > Maven home: C:\Java\apache-maven-3.6.3\bin\.. > > Java version: 1.8.0_251, vendor: Oracle Corporation, runtime: C:\Program > > Files\Java\jdk1.8.0_251\jre > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > > > Details of changes since 2.7.0 are in the release notes: > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.8.0-RC1/RELEASE-NOTES.txt > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.8.0-RC1/site/changes-report.html > > > > Site: > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.8.0-RC1/site/index.html > > (note some *relative* links are broken and the 2.8.0 directories are > > not yet created - these will be OK once the site is deployed.) > > > > JApiCmp Report (compared to 2.7.0): > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.8.0-RC1/site/japicmp.html > > > > RAT Report: > > > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.8.0-RC1/site/rat-report.html > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-dbcp.git --branch > > commons-dbcp-2.8.0-RC1 commons-dbcp-2.8.0-RC1 > > cd commons-dbcp-2.8.0-RC1 > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > you > > then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page which > > you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > which > > you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > >
