May we get more reviews please? Gary
On Sun, Sep 27, 2020 at 9:57 AM Rob Tompkins <chtom...@gmail.com> wrote: > +1 > Build works with java8 and java11 > Signatures validate appropriately > Site and reports look good > > Validation scripts: > > https://github.com/chtompki/notes/blob/master/commons-release-validation/commons-pool-2.9.0-RC1-downloader.sh > < > https://github.com/chtompki/notes/blob/master/commons-release-validation/commons-pool-2.9.0-RC1-downloader.sh > > > > https://github.com/chtompki/notes/blob/master/commons-release-validation/commons-pool-2.9.0-RC1-validator.sh > < > https://github.com/chtompki/notes/blob/master/commons-release-validation/commons-pool-2.9.0-RC1-validator.sh > > > > Cheers, > -Rob > > > On Sep 25, 2020, at 1:44 PM, Gary Gregory <ggreg...@apache.org> wrote: > > > > We have fixed quite a few bugs and added some significant enhancements > > since Apache Commons Pool 2.8.1 was released, so I would like to release > > Apache Commons Pool 2.9.0. > > > > Apache Commons Pool 2.9.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/pool/2.9.0-RC1 (svn > > revision 41582) > > > > The Git tag commons-pool-2.9.0-RC1 commit for this RC is > > e855619858edd5aae1a6b49788bb7212eb77ec23 which you can browse here: > > > > > https://gitbox.apache.org/repos/asf?p=commons-pool.git;a=commit;h=e855619858edd5aae1a6b49788bb7212eb77ec23 > > You may checkout this tag using: > > git clone https://gitbox.apache.org/repos/asf/commons-pool.git > --branch > > commons-pool-2.9.0-RC1 commons-pool-2.9.0-RC1 > > > > Maven artifacts are here: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1529/org/apache/commons/commons-pool2/2.9.0/ > > > > These are the artifacts and their hashes: > > > > #Release SHA-512s > > #Fri Sep 25 13:37:44 EDT 2020 > > > commons-pool2-2.9.0-bin.tar.gz=5cbf5e3c33240710e27e74214034cef4dafedc3a433fa70bec6623f509234731be44709bfabcc3f12d9c555c600bc479077f3e0865f35afc9c9c4ad367e8bbc2 > > > commons-pool2-2.9.0-bin.zip=37bf92bc544269ef7a6808d8c62690b38e3c3b28dc64bfb6dcf84537622006ee41e9883338b1ce43b6e425c16742cb186438d0b2d8238869660e5a7a2a647ffb > > > commons-pool2-2.9.0-javadoc.jar=b6f0c68c56ebfe0bc455729b304ff93bdf3bba356587302b8775bedbf9c913b134685b29dd4dcc89cd8dc4984d37241130cc2a323db5322049cc0aea4d6fcc3f > > > commons-pool2-2.9.0-sources.jar=e3a7f14613c24d15eb8381d189f511f6821b1ccdc61eb5e34850bec867c14ad385410ede240f6e7cba78bc9cd8d4cff9bcc6a9b8128b9fc310b8d562c3e29113 > > > commons-pool2-2.9.0-src.tar.gz=0a9d8520629acbc606eaf0fdaecbfc553b3c79fc605eff0dabd1a1ee5e269c6fdfc61c5858f52fbf09b994dce7fd5855568383f7639cd3a33b442fff6ba6ae0f > > > commons-pool2-2.9.0-src.zip=bdbd373194fde3745c0fa2f17ece2c6db75f1c12c3e26a4e6f685a582f10fcabc18846d231cb410ecb773c10343b33d7c1178a65f57c5be268a30a08cd26e1b1 > > > commons-pool2-2.9.0-test-sources.jar=7f8ae61e3766bc50ae98d4338a220143610ded06649b4d21e035a0c08f93d42c44bc1706d3ce6d77597ed7b5f3a895fc86bc1174c1679199df6d9c4bb5f60ca0 > > > commons-pool2-2.9.0-tests.jar=5fd904d5d6c96be5902e1aeb81ee0826b370adbef6d2e125a21c17411fbc220621171d3c87a536e672f6dd987f74f090524c3d65a57ef8fba4a21d3361ba168f > > > > > > I have tested this with > > > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site > > deploy > > > > Using: > > > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > > Maven home: C:\Java\apache-maven-3.6.3\bin\.. > > Java version: 1.8.0_251, vendor: Oracle Corporation, runtime: C:\Program > > Files\Java\jdk1.8.0_251\jre > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > > > Details of changes since 2.8.1 are in the release notes: > > > > > https://dist.apache.org/repos/dist/dev/commons/pool/2.9.0-RC1/RELEASE-NOTES.txt > > > > > https://dist.apache.org/repos/dist/dev/commons/pool/2.9.0-RC1/site/changes-report.html > > > > Site: > > > > > https://dist.apache.org/repos/dist/dev/commons/pool/2.9.0-RC1/site/index.html > > (note some *relative* links are broken and the 2.9.0 directories are > > not yet created - these will be OK once the site is deployed.) > > > > > > > https://dist.apache.org/repos/dist/dev/commons/pool/2.9.0-RC1/site/japicmp.html > > > > RAT Report: > > > > > https://dist.apache.org/repos/dist/dev/commons/pool/2.9.0-RC1/site/rat-report.html > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner than 72 hours from now. > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thank you, > > > > Gary Gregory, > > Release Manager (using key 86fdc7e2a11262cb) > > > > For following is intended as a helper and refresher for reviewers. > > > > Validating a release candidate > > ============================== > > > > These guidelines are NOT complete. > > > > Requirements: Git, Java, Maven. > > > > You can validate a release from a release candidate (RC) tag as follows. > > > > 1) Clone and checkout the RC tag > > > > git clone https://gitbox.apache.org/repos/asf/commons-pool.git --branch > > commons-pool-2.9.0-RC1 commons-pool-2.9.0-RC1 > > cd commons-pool-2.9.0-RC1 > > > > 2) Check Apache licenses > > > > This step is not required if the site includes a RAT report page which > you > > then must check. > > > > mvn apache-rat:check > > > > 3) Check binary compatibility > > > > Older components still use Apache Clirr: > > > > This step is not required if the site includes a Clirr report page which > > you then must check. > > > > mvn clirr:check > > > > Newer components use JApiCmp with the japicmp Maven Profile: > > > > This step is not required if the site includes a JApiCmp report page > which > > you then must check. > > > > mvn install -DskipTests -P japicmp japicmp:cmp > > > > 4) Build the package > > > > mvn -V clean package > > > > You can record the Maven and Java version produced by -V in your VOTE > reply. > > To gather OS information from a command line: > > Windows: ver > > Linux: uname -a > > > > 5) Build the site for a single module project > > > > Note: Some plugins require the components to be installed instead of > > packaged. > > > > mvn site > > Check the site reports in: > > - Windows: target\site\index.html > > - Linux: target/site/index.html > > > > -the end- > >
