> So we could do 1.21 as is followed by 1.22 with pack200 support. > +1
Lee On 11, 1, 2020, at 11:59, Gary Gregory <garydgreg...@gmail.com> wrote: > It's been quite a while since this thread started so I will review my > branch today but might wait for 1.22. > > While we indicated that we would address building and running pack200 in > some way on Java 14+ for 1.21, an option is to release 1.21 as is since > there are quite a few changes there already and we are updating to Java 8. > > So we could do 1.21 as is followed by 1.22 with pack200 support. > One step at time. > Gary > On Sun, Aug 30, 2020, 18:58 Gary Gregory <garydgreg...@gmail.com> wrote: > > Hi All, > > > > As the next step in the pack200 branch, I've renamed the package > > org.apache.harmony to org.apache.commons.compress.harmony to more easily > > track potential future changes. If this looks acceptable, it can be merged > > and documented. > > > > The builds are green here > > https://github.com/apache/commons-compress/actions/runs/231719106 > > > > Gary > > > > > > On Mon, Aug 24, 2020 at 11:14 AM Gary Gregory <garydgreg...@gmail.com> > > wrote: > > > >> Thanks Peter, I updated the branch and the build passes for me locally, > >> the CI is building now here > >> https://github.com/apache/commons-compress/actions/runs/222219115 > >> > >> Gary > >> > >> > >> On Sun, Aug 23, 2020 at 11:40 PM Peter Lee <peter...@apache.org> wrote: > >> > >>> After some debugging I found this at > >>> org.apache.harmony.pack200.Archive#171 : > >>> > >>> if (classes.size() > 0 && files.size() > 0) { > >>> segmentUnitList.add(new SegmentUnit(classes, files)); > >>> } > >>> Seems the Pack200 implementation in harmony requires existing of both > >>> classes AND files at the same time. The tests are passing if I modified a > >>> little bit here : > >>> > >>> if (classes.size() > 0 || files.size() > 0) > >>> Not sure if this is a problem, cause I'm not familiar with Pack200 and > >>> Apache Harmony. > >>> > >>> Lee > >>> On 8 23 2020, at 11:27 , Gary Gregory <garydgreg...@gmail.com> wrote: > >>> > Hi All, > >>> > > >>> > I created a branch called *pack200* which contains the Apache Harmony > >>> > Pack200 code. > >>> > > >>> > If there are 2 failing unit test ATM if anyone wants to help out. > >>> > Gary > >> > >> >
