Hi Boris, Thank you for your email and PR.
I will take a look but can you handle your TODO comment in the test? It would be better if this change/feature could also be tested on Windows, not just Linux. I think there is another test in this situation as well... TY! Gary On Wed, Jan 13, 2021, 16:21 <bunc...@vhv.de> wrote: > Hello Gary, > > finally, I found it. It seems to be related to the underlying OS or > filesystem. I filed a bug and created a patch: > > https://issues.apache.org/jira/browse/IO-701 > https://github.com/apache/commons-io/pull/186 > > Could you please review it and consider the plan for a 2.9.0 version? > > Kind regards > Boris > > -----Ursprüngliche Nachricht----- > Von: Gary Gregory <garydgreg...@gmail.com> > Gesendet: Montag, 11. Januar 2021 17:49 > An: Commons Developers List <dev@commons.apache.org> > Betreff: Re: [IO] Release 2.8.1 or 2.9 for IO-692 fix > > It's possible that this is a bug in the tests or that your account does > not have the proper krama, nevertheless, I'll try and reproduce... what > branch are you building? > > When I build master (commit 1e20522d8882a0ea5ee1ed44d34a1f01ea576236 (HEAD > -> master, origin/master, origin/HEAD)) without changes I get: > > [ERROR] Errors: > [ERROR] ChildFirstClassLoadingTest.testSingleClassFromDirectory:99 » > ExceptionInInitializer > [ERROR] ChildFirstClassLoadingTest.testSingleClassFromJar:121 » > NoClassDefFound Could ... > [ERROR] MavenSettingsTest.testWithPassedRepository:66 » Runtime > java.io.IOException: C... > [ERROR] MavenUtilTestCase.testRepositorySystem:14 NoClassDefFound Could > not initialize... > [INFO] > [ERROR] Tests run: 13, Failures: 0, Errors: 4, Skipped: 0 [INFO] [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary for WildFly: Core Parent Aggregator > 14.0.1.Final-SNAPSHOT: > [INFO] > [INFO] WildFly: Core Parent Aggregator .................... SUCCESS [ > 5.766 s] > [INFO] WildFly: Protocol Utilities ........................ SUCCESS [ > 21.750 s] > [INFO] WildFly: Controller Client ......................... SUCCESS [ > 3.424 s] > [INFO] WildFly: Core Security parent ...................... SUCCESS [ > 0.025 s] > [INFO] WildFly: Core Security API ......................... SUCCESS [ > 0.165 s] > [INFO] WildFly: Core Security Utilities ................... SUCCESS [ > 0.244 s] > [INFO] WildFly: Version ................................... SUCCESS [ > 0.176 s] > [INFO] WildFly: Controller Core ........................... SUCCESS [ > 46.176 s] > [INFO] WildFly: Core Management Aggregator ................ SUCCESS [ > 0.029 s] > [INFO] WildFly: Core Management Client .................... SUCCESS [ > 0.269 s] > [INFO] WildFly: Domain Management ......................... SUCCESS [ > 25.814 s] > [INFO] WildFly: Domain HTTP Interface ..................... SUCCESS [ > 0.059 s] > [INFO] WildFly: Domain HTTP Interface ..................... SUCCESS [ > 4.818 s] > [INFO] WildFly: Deployment Repository ..................... SUCCESS [ > 12.502 s] > [INFO] WildFly: Platform MBean integration ................ SUCCESS [ > 2.161 s] > [INFO] WildFly: Process Controller ........................ SUCCESS [ > 2.408 s] > [INFO] WildFly: IO aggregator ............................. SUCCESS [ > 0.019 s] > [INFO] WildFly: IO Subsystem .............................. SUCCESS [ > 0.667 s] > [INFO] WildFly: Network ................................... SUCCESS [ > 1.278 s] > [INFO] WildFly: Remoting Subsystem parent ................. SUCCESS [ > 0.014 s] > [INFO] WildFly: Remoting Subsystem ........................ SUCCESS [ > 1.067 s] > [INFO] WildFly: Server .................................... SUCCESS [ > 22.146 s] > [INFO] WildFly: Management Client Content ................. SUCCESS [ > 0.499 s] > [INFO] WildFly: Common Code for Subsystem and Non-subsystem Test Harness > FAILURE [ 20.094 s] [INFO] WildFly: Host Controller > ........................... SKIPPED [INFO] WildFly: Embedded > .................................. SKIPPED [INFO] WildFly: Command line > interface .................... SKIPPED [INFO] WildFly: Bootable Jar parent > ....................... SKIPPED [INFO] WildFly: Bootable Jar boot > ......................... SKIPPED [INFO] WildFly: Bootable Jar runtime > ...................... SKIPPED [INFO] WildFly: Core Model Test Parent > .................... SKIPPED [INFO] WildFly: Subsystem Test Harness > .................... SKIPPED [INFO] WildFly: Subsystem Test POM > ........................ SKIPPED [INFO] WildFly: Elytron Subsystem > ......................... SKIPPED [INFO] WildFly: Core Event Logger > ......................... SKIPPED [INFO] WildFly: Core Management Subsystem > ................. SKIPPED [INFO] WildFly: Deployment Scanner > ........................ SKIPPED [INFO] WildFly: Discovery Subsystem > ....................... SKIPPED [INFO] WildFly: Domain HTTP Error Context > ................. SKIPPED [INFO] WildFly: Logging Subsystem > ......................... SKIPPED [INFO] WildFly: JMX Subsystem > ............................. SKIPPED [INFO] WildFly: Patching Core > ............................. SKIPPED [INFO] WildFly: Request Controller > ........................ SKIPPED [INFO] WildFly: Security Manager Subsystem > ................ SKIPPED [INFO] WildFly: Threading Subsystem > ....................... SKIPPED [INFO] WildFly: Launcher API > .............................. SKIPPED [INFO] WildFly: Core Feature Pack > Parent .................. SKIPPED [INFO] WildFly Core: Feature Pack Common > Resources ........ SKIPPED [INFO] wildfly-core-feature-pack-ee-8-api > ................. SKIPPED [INFO] WildFly: Core Model Test Parent > .................... SKIPPED [INFO] WildFly: Core Model Test Framework > ................. SKIPPED [INFO] WildFly: Core Galleon Pack > ......................... SKIPPED [INFO] WildFly: Build Core > ................................ SKIPPED [INFO] WildFly: Core Feature Pack > ......................... SKIPPED [INFO] WildFly: Legacy Build Core > ......................... SKIPPED [INFO] WildFly Core: Distribution > ......................... SKIPPED [INFO] WildFly Core: Legacy > Feature-pack-based Distribution SKIPPED [INFO] WildFly Core: Component > matrix builder ............. SKIPPED [INFO] > wildfly-core-feature-pack-galleon-common ........... SKIPPED [INFO] > wildfly-core-feature-pack-galleon-pruned ........... SKIPPED [INFO] > WildFly: Core Model Test Controller Optional ....... SKIPPED [INFO] > WildFly: Core Model Tests .......................... SKIPPED [INFO] > WildFly: IO Subsystem tests ........................ SKIPPED [INFO] > WildFly: Remoting Subsystem Test ................... SKIPPED [INFO] > WildFly: Subsystem Test Framework Tests ............ SKIPPED [INFO] > WildFly: Test Runner ............................... SKIPPED [INFO] WildFly > Core Test Suite: Shared .................... SKIPPED [INFO] WildFly: Vault > Test Feature Pack ................... SKIPPED [INFO] WildFly Core Test > Suite: Aggregator ................ SKIPPED [INFO] WildFly Core Test Suite: > Standalone Integration Tests SKIPPED [INFO] WildFly Core Test Suite: > Elytron Integration Tests . SKIPPED [INFO] WildFly Core Test Suite: > Embedded Integration Tests SKIPPED [INFO] wildfly-script-tests > ............................... SKIPPED [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 02:52 min > [INFO] Finished at: 2021-01-11T11:15:18-05:00 [INFO] > ------------------------------------------------------------------------ > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) > on project wildfly-model-test: There are test failures. > [ERROR] > [ERROR] Please refer to > > /Users/garydgregory/git/garydgregory/wildfly-core/model-test/target/surefire-reports > for the individual test results. > [ERROR] Please refer to dump files (if any exist) [date].dump, > [date]-jvmRun[N].dump and [date].dumpstream. > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, > please read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > [ERROR] > [ERROR] After correcting the problems, you can resume the build with the > command > [ERROR] mvn <args> -rf :wildfly-model-test > > Gary > > > > On Sun, Jan 10, 2021, 06:14 <bunc...@vhv.de> wrote: > > > Hello Gary, > > > > thanks for your advice. All test mentioned run fine with commons-io > > 2.5, addressing it here seems right. > > > > There are new issues with the current 2.9.0-snapshot. Previously with > > 2.8.0 it was > > https://github.com/wildfly/wildfly-core/blob/ce3b0e1b66ac39c1832dfea17 > > 35069e17bbc4fe1/testsuite/standalone/src/test/java/org/jboss/as/test/i > > ntegration/management/cli/ModuleTestCase.java#L395 > > addModuleWithDirectoryAndInvalidLinks2 which failed. > > > > With 2.9.0 different tests fail, please find details below: > > > > commons-io 2.9.0-snapshot out of git commit > > 4b92e65963105eedf469ace591ae0b84aa1c3afc > > > > > > https://github.com/wildfly/wildfly-core/blob/ce3b0e1b66ac39c1832dfea17 > > 35069e17bbc4fe1/testsuite/standalone/src/test/java/org/jboss/as/test/i > > ntegration/management/cli/ModuleTestCase.java#L430 > > > > [ERROR] > > > > addModuleWithDirectoryAndInvalidLinks3(org.jboss.as.test.integration.m > > anagement.cli.ModuleTestCase) > > Time elapsed: 0.006 s <<< ERROR! > > java.io.IOException: Unable to delete > > > > > /home/borisunckel/javaprojects/wildfly/wildfly-core/testsuite/standalone/target/C > > at org.apache.commons.io.FileUtils.delete(FileUtils.java:1122) > > at org.apache.commons.io > > .FileUtils.deleteDirectory(FileUtils.java:1143) > > at > > > > > org.jboss.as.test.integration.management.cli.ModuleTestCase.addModuleWithDirectoryAndInvalidLinks3(ModuleTestCase.java:468) > > at > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > > Method) > > at > > > > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > > at > > > > > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > at java.base/java.lang.reflect.Method.invoke(Method.java:566) > > at > > > > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > > at > > > > > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > > at > > > > > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > > at > > > > > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > > at > > > > > org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) > > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) > > at > > > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) > > at > > > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) > > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > > at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > > at > > > > > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > > at > > > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > > at > > > > > org.wildfly.core.testrunner.WildflyTestRunner.run(WildflyTestRunner.java:157) > > at org.junit.runners.Suite.runChild(Suite.java:128) > > at org.junit.runners.Suite.runChild(Suite.java:27) > > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > > at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > > at > > org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158) > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) > > at > > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:4 > > 18) > > > > > > https://github.com/wildfly/wildfly-core/blob/ce3b0e1b66ac39c1832dfea17 > > 35069e17bbc4fe1/testsuite/standalone/src/test/java/org/jboss/as/test/i > > ntegration/management/cli/ModuleTestCase.java#L267 > > > > [ERROR] > > > > addModuleWithDirectoryError(org.jboss.as.test.integration.management.c > > li.ModuleTestCase) > > Time elapsed: 0.008 s <<< ERROR! > > org.apache.commons.io.IOExceptionList: 1 exceptions: > > [java.io.IOException: Unable to delete file: > > > > > /home/borisunckel/javaprojects/wildfly/wildfly-core/testsuite/standalone/target/1610275423109dir/1610275423109file.txt] > > at org.apache.commons.io > .FileUtils.cleanDirectory(FileUtils.java:301) > > at org.apache.commons.io > > .FileUtils.deleteDirectory(FileUtils.java:1140) > > at > > > > > org.jboss.as.test.integration.management.cli.ModuleTestCase.addModuleWithDirectoryError(ModuleTestCase.java:289) > > at > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > > Method) > > at > > > > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > > at > > > > > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > at java.base/java.lang.reflect.Method.invoke(Method.java:566) > > at > > > > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > > at > > > > > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > > at > > > > > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > > at > > > > > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > > at > > > > > org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) > > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) > > at > > > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) > > at > > > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) > > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > > at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > > at > > > > > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > > at > > > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > > at > > > > > org.wildfly.core.testrunner.WildflyTestRunner.run(WildflyTestRunner.java:157) > > at org.junit.runners.Suite.runChild(Suite.java:128) > > at org.junit.runners.Suite.runChild(Suite.java:27) > > at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > > at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > > at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > > at org.junit.runners.ParentRunner.run(ParentRunner.java:413) > > at > > org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75) > > at > > > > > org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158) > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) > > at > > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:4 > > 18) Caused by: java.io.IOException: Unable to delete file: > > > > > /home/borisunckel/javaprojects/wildfly/wildfly-core/testsuite/standalone/target/1610275423109dir/1610275423109file.txt > > at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1344) > > at org.apache.commons.io > .FileUtils.cleanDirectory(FileUtils.java:294) > > ... 44 more > > Caused by: java.nio.file.AccessDeniedException: > > > > > /home/borisunckel/javaprojects/wildfly/wildfly-core/testsuite/standalone/target/1610275423109dir/1610275423109file.txt > > at > > > > > java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:90) > > at > > > > > java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) > > at > > > > > java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116) > > at > > > > > java.base/sun.nio.fs.LinuxDosFileAttributeView.updateDosAttribute(LinuxDosFileAttributeView.java:278) > > at > > > > > java.base/sun.nio.fs.LinuxDosFileAttributeView.setReadOnly(LinuxDosFileAttributeView.java:191) > > at > > org.apache.commons.io.file.PathUtils.setReadOnly(PathUtils.java:875) > > at > org.apache.commons.io.file.PathUtils.deleteFile(PathUtils.java:486) > > at org.apache.commons.io.file.PathUtils.delete(PathUtils.java:393) > > at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1341) > > ... 45 more > > > > > > -----Ursprüngliche Nachricht----- > > Von: Gary Gregory <garydgreg...@gmail.com> > > Gesendet: Freitag, 8. Januar 2021 15:51 > > An: Commons Developers List <dev@commons.apache.org> > > Betreff: Re: [IO] Release 2.8.1 or 2.9 for IO-692 fix > > > > In the meantime, you would be well advised to test with a > > 2.9.0-SNAPSHOT build. > > > > Gary > > > > On Fri, Jan 8, 2021, 09:50 Gary Gregory <garydgreg...@gmail.com> wrote: > > > > > I plan on creating a release candidate for 2.9.0 "soon", maybe this > > > weekend or next, no guarantees though... > > > > > > Gary > > > > > > On Fri, Jan 8, 2021, 05:18 <bunc...@vhv.de> wrote: > > > > > >> Dear IO developers, > > >> > > >> > > >> > > >> you already fixed https://issues.apache.org/jira/browse/IO-692 The > > >> underlying issue blocks the component upgrade in WildFly Core, due > > >> to a breaking integration unit test. (Pull is here: > > >> https://github.com/wildfly/wildfly-core/pull/4400 ) It would be > > >> great to have the new enhancements and fixes of IO to be integrated > there. > > >> > > >> > > >> > > >> Could you please release a 2.8.1 or 2.9 version including the > > >> IO-692 > > fix? > > >> > > >> > > >> > > >> Kind regards > > >> > > >> Boris > > >> > > >> ------------------------------------------------------------------- > > >> -- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > >> For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > Diese Mail wurde aus Datenschutzgründen verschlüsselt versandt. > > > Diese Mail wurde aus Datenschutzgründen verschlüsselt versandt. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org >
