I’m curious….does this change break BC????

https://github.com/apache/commons-io/commit/6803ac145c274546d0f2e06374a9723a4d4d7ce6
 
<https://github.com/apache/commons-io/commit/6803ac145c274546d0f2e06374a9723a4d4d7ce6>

with the removal of:

public FileVisitResult visitFile(final Path file, final BasicFileAttributes 
attributes) throws IOException;

japicmp only kinda complains, but I’m looking at it and think that it may break 
BC. Curious to hear what others think.

-Rob

> On May 22, 2021, at 1:49 PM, Gary Gregory <ggreg...@apache.org> wrote:
> 
> We have fixed a few bugs and added enhancements since Apache Commons IO
> 2.8.0 was released, so I would like to release Apache Commons IO 2.9.0.
> 
> Apache Commons IO 2.9.0 RC1 is available for review here:
>    https://dist.apache.org/repos/dist/dev/commons/io/2.9.0-RC1 (svn
> revision 47867)
> 
> The Git tag commons-io-2.9.0-RC1 commit for this RC is
> 75f20dca72656225d0dc8e7c982e40caa9277d42 which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-io.git;a=commit;h=75f20dca72656225d0dc8e7c982e40caa9277d42
> You may checkout this tag using:
>    git clone https://gitbox.apache.org/repos/asf/commons-io.git --branch
> commons-io-2.9.0-RC1 commons-io-2.9.0-RC1
> 
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1548/commons-io/commons-io/2.9.0/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> #Sat May 22 12:55:53 EDT 2021
> commons-io-2.9.0-bin.tar.gz=3e28fb033d43c5c2f423db45a190410ffbc2c4d091ec5e2abfdabcfd9cdab0729e37c14ce618f7c9cd74d2a075052165a2fe43e525859a2a353f087dee293ae7
> commons-io-2.9.0-bin.zip=6cdaac5428a49d44b1674e39edd829774359a2450c418988d5e2c0b54a55580a294c30a948b218930ec9f33e14b7302d5f242ccfc542fde364b136063eebba92
> commons-io-2.9.0-javadoc.jar=df424e1bad9b1a83031d23c13d189651bcad146e79234eae36cc734e6ae888dd692ab36da51e82a39f533c603d20ca431d80f46b607ea928d521772b0d29461f
> commons-io-2.9.0-sources.jar=19ad8cd150871f41f21a57d277da01b965f12ecb901e980d434384e6e11aa6de45803c6aa982c4cc9a154eb97e7055132f25e0deb1b9e4819279aa49bbac32f4
> commons-io-2.9.0-src.tar.gz=3dfc39e9b8286119e58ace7713b77f06145b440d54b9be0f9ae08897bcce1bbb02797c18d9b29010081b89e7a12b44dd644c851f8ca4bd9eb5c579298f117611
> commons-io-2.9.0-src.zip=b5f63b20821ffda626494190241b3877e91f4c9d434c4a6c2478d0619d206541286f64b6adea4de6bb0d092d70caa90535ea98810295e278120f127d7e2d8eee
> commons-io-2.9.0-test-sources.jar=dc8dac2b0a207b5ce18dcc1a56e24b227dccf6ab4f9d2b84512c90961cdd41db4416b98cfc98ef8c576afb80beb41831f24258f2ab430154251539e55c462262
> commons-io-2.9.0-tests.jar=3cbd95e3b09954b04125f661a2c972948c1d6ef5ee3bd6bbc4ff679de6573ee4c90db2da4815c3fa69332db4a6319214ce98fd72b69cc72134f49def21401dfb
> 
> 
> I have tested this with 'mvn' and 'mvn -V -Duser.name=$my_apache_id
> -Dcommons.release-plugin.version=$commons_release_plugin_version -Prelease
> -Ptest-deploy -P jacoco -P japicmp clean package site deploy' using:
> 
> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /usr/local/Cellar/maven/3.8.1/libexec
> Java version: 1.8.0_292, vendor: AdoptOpenJDK, runtime:
> /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"
> 
> Details of changes since 2.8.0 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/io/2.9.0-RC1/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/io/2.9.0-RC1/site/changes-report.html
> 
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/io/2.9.0-RC1/site/index.html
>    (note some *relative* links are broken and the 2.9.0 directories are
> not yet created - these will be OK once the site is deployed.)
> 
> JApiCmp Report (compared to 2.8.0):
> 
> https://dist.apache.org/repos/dist/dev/commons/io/2.9.0-RC1/site/japicmp.html
> 
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/io/2.9.0-RC1/site/rat-report.html
> 
> KEYS:
>  https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
> 
> For following is intended as a helper and refresher for reviewers.
> 
> Validating a release candidate
> ==============================
> 
> These guidelines are NOT complete.
> 
> Requirements: Git, Java, Maven.
> 
> You can validate a release from a release candidate (RC) tag as follows.
> 
> 1) Clone and checkout the RC tag
> 
> git clone https://gitbox.apache.org/repos/asf/commons-io.git --branch
> commons-io-2.9.0-RC1 commons-io-2.9.0-RC1
> cd commons-io-2.9.0-RC1
> 
> 2) Check Apache licenses
> 
> This step is not required if the site includes a RAT report page which you
> then must check.
> 
> mvn apache-rat:check
> 
> 3) Check binary compatibility
> 
> Older components still use Apache Clirr:
> 
> This step is not required if the site includes a Clirr report page which
> you then must check.
> 
> mvn clirr:check
> 
> Newer components use JApiCmp with the japicmp Maven Profile:
> 
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
> 
> mvn install -DskipTests -P japicmp japicmp:cmp
> 
> 4) Build the package
> 
> mvn -V clean package
> 
> You can record the Maven and Java version produced by -V in your VOTE reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
> 
> 5) Build the site for a single module project
> 
> Note: Some plugins require the components to be installed instead of
> packaged.
> 
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
> 
> -the end-

Reply via email to