Le jeu. 2 sept. 2021 à 16:30, Erik Svensson <[email protected]> a écrit : > > Hi! > > > > I’ve implemented profiles, where you can choose to use either AccurateMath or > jlM and it works on j8.
Can you provide a link to the code? > Building on later versions of the jdk fails on the > AccurateMathTest.checkMissingAccurateMathClasses test (not surprise there). > > I can implement the missing methods using the same algorithms as OpenJDK, Do you mean copying (Java?) code that is maintained somewhere else? > we can remove the test or maybe something else? Perhaps refactor the test using assumptions.[1] > The second alternative depends on if AccurateMath is going to keep on being a > drop-in replacement for jlM. "FastMath" was a rewrite of the functions defined in "java.lang.Math" as of Java 8. Its usefulness was in the implementations being equally or more accurate and sometimes faster (on Java 5). As mentioned in another thread, we should know whether that's still the case in environments where the upcoming version of CM could potentially be used. > > How do you guys want to play this? > [1] https://junit.org/junit5/docs/current/user-guide/#writing-tests-assumptions --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
